warning indentation; statement is not part of the previous 'for' [-Wmisleading-indentation]
if (__builtin_expect(!!(clients.removeAll(client) == 0), true)) {} else { ::Utils::writeAssertLocation( "\"" "clients.removeAll(client) == 0""\" in " "/data/dev/creator-out/src/plugins/languageclient/languageclientmanager.cpp" ":" "114"); } do {} while (0
Change-Id: I14297567627801d3a5436abf2df8fec23bff85dd
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
In an accompanying change, the installer writes versioned
settings keys. The version string will be appended to the
existing key, after a single underscore character.
When reading from the settings, the plugin first looks for
keys matching one of the requested versions from the kit.
Optionally, if no key for a matching version is found, the
key for the newest version available is chosen. This only
applies to the Qul SDK package for the time being.
If no suitable versioned key is found, the plain unversioned
settings key is picked
Task-number: QTCREATORBUG-29194
Change-Id: I2db888390cfb64a4b7c78ebcf795543251cb7a1b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
No need to create lambda on every call to credentialKey().
This should remove the warning about the
Performance inefficiencies (AUTO_CAUSES_COPY).
Change-Id: I9a7dc9cabcc6f80e58e39ef8be6a5445a11e0433
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This option is only shown when View3D item is selected.
Fixes: QDS-12207
Change-Id: I0a98b59a5eb3fe7abd689711939b649fe496eeb7
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Add a Clangd specific function hint model that alwys highlights the
current parameter based on the number of commas in front of the cursor
position, like the builtin code model. It also correctly closes the
proposal after typing the closing parenthesis.
Fixes: QTCREATORBUG-26346
Fixes: QTCREATORBUG-30489
Change-Id: I09d3ac6856acfe5e0f206d8c3a96dbb561ea2ce7
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Rename process.h back to qtcprocess.h
MSVC's "threads" standard header includes <process.h>, and that ends up
including our process.h from Utils.
There already was a hacky workaround in place for a similar issue with
MINGW, but that doesn't work with MSVC because that doesn't have
Simply use a name that doesn't conflict.
Change-Id: I1159cd2096b4f2dbc4a1728d0131dd6edd30ebd3
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
(cherry picked from commit 5af531cd39)
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The model needs the project store, the path cache, the imports and the
file path. So we now use a method in the model to copy them over to the
new model.
Task-number: QDS-12102
Change-Id: I80f911d55c5a5fdf9d1a87c1f4888e498086374b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
If the project storage is activated the old API will be deprecated.
Hepefully people now stop to use the old API. You can still use it but
you have to write an implementation for the new one too.
Task-number: QDS-12102
Change-Id: Iac23da1648ff44e27a2ee7840e0d3eeb1fb8caf9
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
When triggering them from the context menu while debugging.
Fix used settings group when triggering writeSettings() on
the aspect instead of the AspectContainer.
Explicitly persist respective settings when triggering them
on the context menu.
Fixes: QTCREATORBUG-30491
Change-Id: I6f429bb54630cbe61c8b2ee063028f323a2d08f6
Reviewed-by: hjk <hjk@qt.io>
User feedback was gathered and in part implemented in form of a design
update:
- Update dark and light tokens
- Add Token_Text_Accent and use it for session/sroject names, tags, etc.
- Change card hover from Token_Foreground_Subtle to
Token_Background_Subtle
- Remove font-style changes on hover
Change-Id: Ia428d43828c9c76ea91d142356457846b932e2d6
Reviewed-by: hjk <hjk@qt.io>
Give the dialog back its minimize and maximize buttons (on Windows),
without setting the Window flag.
Amends: 24796279f3
Change-Id: I2bca972c0351d0749ea3771e418449a052703329
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Also if the click was over a visible model in View3D, that model will
be selected. 3D view edit camera will be aligned to the scene camera
currently in use.
Fixes: QDS-12188
Change-Id: I25823dbbcf9d1706b2cdefb8c34aa78ecd93e407
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Skip targets list if function name is add_subdirectory
Fixes: QTCREATORBUG-30510
Change-Id: I8c601fb2134fc8a9b2814df01f6ec5eec380c51a
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
The only caller of refreshSourceFiles() is updateSourceFiles(), which
already does the respective filtering.
Amends 1960503ae9.
Change-Id: Ief7b2a728138c3693276edbd1912fa59cadaf4a6
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
There were some problems regarding removal of the default kit:
- A precondition of setDefaultKit() was violated.
- The new default kit was set to a kit that was possibly removed later
as well (and never updated afterwards).
- The new default kit was only set if it wasn't null, leaving a
dangling pointer in m_defaultKit.
Also turned some checks into assertions.
Amends e31a06a0f4.
Done-by: Christian Kandeler <christian.kandeler@qt.io>
Fixes: QTCREATORBUG-30493
Fixes: QTCREATORBUG-30502
Change-Id: I3283f02c90d0ec84b579d7cfdf845b03663f5768
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
On macOS the action was correctly switching between "Enter Full Screen"
and "Exit Full Screen", but on Windows & Linux the text was fixed to
"Full Screen" and the code tried to set the check state - but forgot to
make it checkable in the first place.
Actually it is unclear what the "correct" behavior is on Windows &
Linux. Neither on Gnome or KDE or Windows the action shows a check mark
when in Full Screen mode though. Either there is a tool button with an
icon, or some variation of "Exit Full Screen" or "Leave Full Screen".
Change the text of the action on all platforms, use "Exit Full Screen"
on all of them, but stay with just "Full Screen" on Windows & Linux (as
opposed to "Enter Full Screen" on macOS).
Fixes: QTCREATORBUG-30365
Change-Id: Ic55a30e32302ceb12f75449781b1aefecb370c97
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
Provide actions to open the selected issue or table inside
the system web browser.
Change-Id: I43d31368444fd4664db7d908c40b898e430cede3
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
It should be what FilePath::specialRootName() returns,
"__qtc_devices__". Looks like nothing used the string retured by next()
so this didn't cause issues before.
Change-Id: Ib9c48d8ea032b1ca7d9ec08003f9d51c5a2ae528
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
The other two parameters, QDir::Filter and nameFilters string list, can
be retrieved from the baseIterator.
Change-Id: Id33a95f3b490e8f5846e9728fc66da0df5195be9
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
panelWidget() and isInUnstyledDialogOrPopup() in ManhattanStyle.cpp
would mark the contents of this dialog as "panel widgets". In order to
evade this, we don't set the dialog type of the Crop&Trim dialog to
Qt::Windows.
The author of this dialog did not leave us a comment on why Qt::Windows
was chosen, so we can assume it was done for no particular reason.
Fixes: QTCREATORBUG-29893
Change-Id: I90f653e39cee839203b8767cb30eadab69baaf09
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
But this time ignore unhandled exceptions which were caused by the
'threads' command in certain situations.
Amends db307978bf
Change-Id: I50819306eeb392ebae8dc869694ed588739c44fb
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Use less specific #include to get EnvironmentAspect.
Change-Id: I570c6a0871c63f5857d56ff640e95f10463fce5e
Reviewed-by: Dominik Holland <dominik.holland@qt.io>
It is supposed to be shown in the tool tip, so set the tool tip instead.
Fixes: QTCREATORBUG-29174
Change-Id: Ib2572b71dfccf18276e63fadb7dbe386949b0275
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
We do not go out of our way to retain the old settings value, as the
setting affects only the UI behavior in the same widget it is displayed
in.
Change-Id: Ie0d66b3909364e15a05013eddaf742b161941f67
Reviewed-by: David Schulz <david.schulz@qt.io>
Button states can have individual text tokens assigned. Depending on the
used fonts and platform-specific renderer, any of these states may have
the highest widts. Consider all of them and use the maximum.
Change-Id: I51caccef9e34c1911c2773b8836dba722ad63c47
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
