That terminate handler is only installed if any event queue is
activated. That is only the case if you compile with a special
option.
Change-Id: I4d8661c0fa11d8bb14b49b7b963471f626b3b950
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
The constructor for the category was missing. Otherwise the CTAD is not
working.
Change-Id: I4d4c2aaba8915fbbade0b8ce4f1310046d748cd1
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
The warning was not shown when opening a project with the QML debugging
option enabled.
The `changeHandler` was explicitly called at construction, but at this
point the `warningLabel` doesn't have a parent. The `setVisible` call
was skipped in this case, to prevent opening a toplevel window (for a
short time) for it until it has a parent.
Unfortunately there is no Qt API for setting the "visibility to the
parent". Instead invert the logic: Let the label have default visibility
to start with (which is "visible if the parent is visible"), and force
it to hidden in `changeHandler` if necessary.
Amends eda5fbd645
Change-Id: I69b86a967ee1fe7bd3d5d035765349981b64eb72
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
In cases when a CMake project is using a CMake preset with a toolchain
file, the CMAKE_C|XX_COMIPLER value was not set in the CMakeCache.txt.
This commit makes sure that the cache from the CMake preset probe
contains CMAKE_C|XX_COMPILER values.
Task-number: QTCREATORBUG-30474
Change-Id: I63ac6fe2b043e49dda98e286b6d85950e34be920
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
ConPTY on windows will send "clear line" characters in response
to resizing the PTY.
During re-showing the terminal pane the widget receives a "height=0"
resize event. We have to ignore this otherwise the conpty might try to
clear the screen.
Another issue was that we are calling resize on the pty even thought the
process has ended and won't be able to respond to the clear attempty by
the pty anymore.
Fixes: QTCREATORBUG-30523
Change-Id: I24caeaffb31d255a0640952e2d35bda23fd16280
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Url properties should be set as urls to avoid asserts.
Change-Id: I990e731f4555943ce35443226ab053286c58bd58
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Deeply under the hood, the color for ther Spinner was determined by the
QApplication palette, color role "Text".
In order to run the spinner on a dark toolbar (in a non-dark theme),
though, the color needs to be bright. It is the case for the
ScreenRecorder.
This change adds a color setter to the Spinner classes, adds colored
Spinners to tst_spinner and makes use of the feature in the
ScreenRecorder.
The default color of the Spinner remains QApplication palette, color
role "Text".
Change-Id: Ia75758707f225b1f994e73c5a314478101c80f5e
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
If the user selects "Record Screen" while the ffmpeg/ffprobe are not
set, the ScreenRecorder settings are shown. The ScreenRecorder dialog
did open up after the settings page, even if the user just pressed OK
without setting the tools.
With this change, not the settings page return value determines whether
to show the ScreenRecorder dialog, but rather a second check if the
tools are set/registered.
Change-Id: I35b8f4e3afe7ea5e6834fcff74ce8f73d3a115b4
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Put the future into the future synchronizer.
Otherwise, when (un)registedDocumentationNow() is still executed
on shutdown we are destroying the locked mutex and crash.
Change-Id: Ic8e7f8252719a3015101a0f5fc7b48ba57956562
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
There is no reason to limit the environment modifications to unique
variables. The environment modifications are processed sequentially
from top to bottom and there may modifications that are done on the
same variable (e.g. once a prepend, once an append,..)
Change-Id: I8a187737be1108e537a926239088c6352dc92957
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
It mostly broke when Qt changed containers from int to qsizetype:
When we use QDataStream to serialize the value of `QList::indexOf`, but
deserialize that into an `int` variable, we don't get the same value
back.
Fix that, and also use begin/endMoveRows, which results in a better
selection behavior after dropping.
Fixes: QTCREATORBUG-30469
Change-Id: Ic99181ea7f75958766977ce7cf9d17c3d96103e2
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Right click on 3D view will now always clear selection if
there is no model under the cursor when click happens.
Fixes: QDS-12227
Change-Id: I922fc79472ced4a3aa5e518c03731edf240e1d43
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Previously the SettingsDialog did not call Aspect::cancel().
Without this, the volatile value is not reset if the user did some
changes before pressing cancel.
This "should" mean that re-opening the settings dialog should present
the changed values again. But since not all aspects are implemented
correctly, they reinitialize from their value instead of their
volatileValue.
When the Settings Dialog is reopened and applied, a warning is triggered
as the container thinks its dirty, but the Aspect::apply returns false.
Change-Id: I8fac66fc95f9118d69c789ced22481d121769f0b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Edit camera speed configuration consists of a slider and a multiplier,
which combine into the total camera speed.
Speed and multiplier are stored per scene.
Fixes: QDS-12187
Change-Id: I587c04cf80d1ca95b5a38c406158e46cdb91d06f
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Makes it easier to reason in mixed setups.
Change-Id: I4f7aa43847dab51d4041fb1b9850ed9860a6dafc
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This occasionally triggered crashes on static destruction when
hard-killing Qt Creator.
Giving QtVersionManagerImpl the plugin as QObject parent effectively
re-instates the lifetime behavior from before we moved to delayed
initialization. We keep the delayed initialization, at the (acceptable)
prize of a somewhat quirky setup.
Change-Id: I1b4be284a1b573325ed5cc441778eeb48b94c24b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
It is important that the LicenseChecker's initialization (if that is
available) happens before QmlDesigner's, so add an optional dependency
to reflect that.
Add a PLUGIN_MANUAL_DEPENDS option to add_qtc_plugin, which explicitly
specifies the name, version and type. The existing PLUGIN_RECOMMENDS
requires the plugin target to exist to extract the plugin's version.
Change-Id: Ie2cf84e75964ce91ed8bbcdbeee9fa9770bed641
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This changes the JDK download link to the JDK 17 packages on
adoptium.net, which is the latest source for JDK binaries for all three
host OSses.
Fixes: QTCREATORBUG-30335
Change-Id: I54322c82b7854d948fe15462f198f8eac1f58981
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
This got lost when replaced the default header implementation
with a customized one.
Change-Id: I5824b0e35a39746eb7056fbc95ea085505129f4e
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
If we use the same ID for the new kit as for the original, we get into
problems if the original kit re-appears.
This can happen when uninstalling a Qt version with the online
installer, and later re-installing it. Or when changing the install
settings path to a different online installation and back again via the
command line or the "Link with Qt" functionality.
Change-Id: Id99a3560ebed6264ad13dab5ff48945b30a8229f
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
... in a situation where no device is present. This happened to me
when trying to restore a "vanished" kit.
Change-Id: I7019385af115a5cd653b9a79e4420f1f8df4797d
Reviewed-by: Dominik Holland <dominik.holland@qt.io>
While showing examples from remote Qt versions would probably be
possible, it is not a great idea performance-wise.
Task-number: QTCREATORBUG-30512
Change-Id: I2d00640bc8cbb3b19a89af1b17108e28604ef5a8
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Disallow the unauthenticated access when the username doesn't
match the dashboard's username.
Change-Id: If4a38091b0bba42d89da911be45f823c248cc25f
Reviewed-by: Andreas Loth <andreas.loth@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Break the authorization process on any error coming from
unauthorized access trial except the UnauthenticatedException.
Call onUnauthorizedGroupDone only after successful execution
of dashboard's dtoRecipe(). Rename it to onUnauthorizedDashboard.
Change-Id: Ia7ce0f326c91722d0e68d5228cb46b94b47a7892
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Andreas Loth <andreas.loth@qt.io>
Reviewed-by: hjk <hjk@qt.io>
... and make sure to use notifyInferiorIll only in states
where the inferior might still be alive.
Change-Id: Ie002cd8b70cc610b15bab00554c027494a0ad2e3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
