Makes it easier to reason in mixed setups.
Change-Id: I4f7aa43847dab51d4041fb1b9850ed9860a6dafc
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This occasionally triggered crashes on static destruction when
hard-killing Qt Creator.
Giving QtVersionManagerImpl the plugin as QObject parent effectively
re-instates the lifetime behavior from before we moved to delayed
initialization. We keep the delayed initialization, at the (acceptable)
prize of a somewhat quirky setup.
Change-Id: I1b4be284a1b573325ed5cc441778eeb48b94c24b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
It is important that the LicenseChecker's initialization (if that is
available) happens before QmlDesigner's, so add an optional dependency
to reflect that.
Add a PLUGIN_MANUAL_DEPENDS option to add_qtc_plugin, which explicitly
specifies the name, version and type. The existing PLUGIN_RECOMMENDS
requires the plugin target to exist to extract the plugin's version.
Change-Id: Ie2cf84e75964ce91ed8bbcdbeee9fa9770bed641
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This changes the JDK download link to the JDK 17 packages on
adoptium.net, which is the latest source for JDK binaries for all three
host OSses.
Fixes: QTCREATORBUG-30335
Change-Id: I54322c82b7854d948fe15462f198f8eac1f58981
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
This got lost when replaced the default header implementation
with a customized one.
Change-Id: I5824b0e35a39746eb7056fbc95ea085505129f4e
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
If we use the same ID for the new kit as for the original, we get into
problems if the original kit re-appears.
This can happen when uninstalling a Qt version with the online
installer, and later re-installing it. Or when changing the install
settings path to a different online installation and back again via the
command line or the "Link with Qt" functionality.
Change-Id: Id99a3560ebed6264ad13dab5ff48945b30a8229f
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
... in a situation where no device is present. This happened to me
when trying to restore a "vanished" kit.
Change-Id: I7019385af115a5cd653b9a79e4420f1f8df4797d
Reviewed-by: Dominik Holland <dominik.holland@qt.io>
While showing examples from remote Qt versions would probably be
possible, it is not a great idea performance-wise.
Task-number: QTCREATORBUG-30512
Change-Id: I2d00640bc8cbb3b19a89af1b17108e28604ef5a8
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Disallow the unauthenticated access when the username doesn't
match the dashboard's username.
Change-Id: If4a38091b0bba42d89da911be45f823c248cc25f
Reviewed-by: Andreas Loth <andreas.loth@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Break the authorization process on any error coming from
unauthorized access trial except the UnauthenticatedException.
Call onUnauthorizedGroupDone only after successful execution
of dashboard's dtoRecipe(). Rename it to onUnauthorizedDashboard.
Change-Id: Ia7ce0f326c91722d0e68d5228cb46b94b47a7892
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Andreas Loth <andreas.loth@qt.io>
Reviewed-by: hjk <hjk@qt.io>
... and make sure to use notifyInferiorIll only in states
where the inferior might still be alive.
Change-Id: Ie002cd8b70cc610b15bab00554c027494a0ad2e3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
I got a crash when clicking "Test" in the configuration of an
already existing ("Local Remote") device that was intentionally
not yet set up with working authorized keys after dismissing the
qtc-askpass dialog. The full reason is unclear, but this here
fixes it for me.
Change-Id: Ie07b89b85576beb59583370191e337fd1219db51
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
If no CMake is found, show an error message (reusing an existing
translated string).
Fixes: QTCREATORBUG-30505
Change-Id: I6e3037ee97dfba21791191483fffab769a451125
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Some styles (e.g. macOS, KDE) disable the hover effect on
QAbstractButton. Setting the Qt::WA_Hover on our own button enforces the
hover effect.
Change-Id: I9f2f22c7e7c869a70ebb0e9032d162bd29e94166
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Qt installations on KDE systems may insert shortcut ampersands into
widgets texts. For self-painted widgets, we need therefore consider
Qt::TextShowMnemonic when retrieving metrics of a text and when drawing
it.
This change addresses the issue for Utils::DetailsButton and
Core::Button. Most likely, there are more places where this needs to be
fixed.
Task-number: QTCREATORBUG-30534
Change-Id: I98ef9bf8c8502d92d3a3884d1588be190934f5bd
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
If the column is too narrow we may overlap the text of the
column header. Explicitly clear the area before painting the
icon.
Change-Id: If73c1e2cc66c21dd9ffa41710873faa654bf235e
Reviewed-by: hjk <hjk@qt.io>
Limiting starting the container only from main thread is worse than the
potential for data access races. DockerDevice needs a rewrite here.
Change-Id: I485f5253d1f0ba0e7fb40ca7e1ddb37dd615212c
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Remove output data from FormatText and rename it into FormatInput.
Use Utils::expected_str<QString> for output data and alias it with
FormatOutput.
Change-Id: I2cf21d73d2e973eeeb4431ae30b56bb5987986f6
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
Fix the warning:
QFutureWatcher::connect: connecting after calling setFuture()
is likely to produce race.
Amends e8ad29d3af
Change-Id: I834f41bd3b7c51520fb36945d4c09a8eafd2affc
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Apparently the reasoning for having it, i.e. make
std::unique_ptr<Utils::MacroExpander> "copyable" is not
valid anymore.
This change also fixes the leak of a MacroExpander
returned by QtVersion::createMacroExpander().
Change-Id: I811ecf2eca8e5ce3a1da267da8290ba89df66db6
Reviewed-by: hjk <hjk@qt.io>
DebuggerProcessFinished in EngineSetupRequested means EngineSetupFailed.
Could be triggered with LLDB "Run as Root" plus <Cancel> in the dialog.
Change-Id: Idbfcaebfc302c7646f9b85275d1d57be17cd0922
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
qt_findAtNxFile does a better job at returing a suited @Nx-image for
"exotic" device pixel ratios. This change fixes for example the active
mode icon when running Qt Creator at 250% ui scaling.
Task-number: QTCREATORBUG-30464
Change-Id: Ia90ba3573fcd4af7941322d7dbc8905fe140192b
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Use the actual image dpr for arithmetics rather than the application
dpr.
Fixes: QTCREATORBUG-30464
Change-Id: I52083bcca067282a677a9d0e1b7c62e9c7270c64
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
