We have to check if the semantic info is actually valid.
Task-number: QDS-12203
Change-Id: Ia4fa411708f0235de4754ced057fb86dd9a4aa7a
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
There are new operator== overloads that are causing this to now be
ambiguous.
qlist.h: In instantiation of ‘qsizetype QtPrivate::indexOf(const QList<T>&, const U&, qsizetype) [with V = QByteArray; U = Utils::SmallStringView; qsizetype = long long int]’:
qlist.h:935:20: error: ambiguous overload for ‘operator==’ (operand types are ‘const QByteArray’ and ‘const Utils::SmallStringView’)
qbytearray.h:520:5: note: candidate: ‘bool operator==(const QByteArray&, const QByteArrayView&)’
smallstringview.h:117:16: note: candidate: ‘constexpr bool Utils::operator==(SmallStringView, SmallStringView)’
Change-Id: I6818d78a57394e37857bfffd17b9ffb5101cdc5c
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Setting m_status to BaseIteratorEnd should only be done in hasNext(),
because the latter is always called first, before any other member
function.
Change-Id: Ie55518a850655730fb760226d58c4fb171a7f2e1
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Only call setPath() in hasNext(), the latter is called before any other
member method, and setPath() is guarded by a bool to only run a single
time.
Split some code to a helper function, which will be reused when porting
to new QAFEngine API.
Change-Id: Ibda0ede18593a3a20729b31e03e994ad2de126de
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
It turns out caching the information is unreliable due to a variety of reasons.
We remove the cache for now as its less dangerous than trying to fix each
use case.
Change-Id: I8238166486a2fb29c101f700af1c8d7e4ad7a172
Reviewed-by: hjk <hjk@qt.io>
Rewrote almost the whole page, renamed the topic, and updated the image.
Fixes: QDS-12025
Change-Id: Id8b4dcdb8513e726db933158833ba032ca9b8125
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
It tried to use an existing string, but missed the full stop
Amends 124c62a5a0
Change-Id: Idf66621b714da86be700d4ac18c6df2c7a83a468
Reviewed-by: Yasser Grimes <yasser.grimes@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
We want to support more than one back-end in the future.
Task-number: QTCREATORBUG-28116
Change-Id: I72020c94b36072a297e13f44130e5e2482922cd4
Reviewed-by: David Schulz <david.schulz@qt.io>
Also remove the taskbar window (on Windows) that appears when the popup
appears, and make the FlagsComboBox buttons smaller
Fixes: QDS-12215
Change-Id: Ief8ab3b746a3d18b391b46a391cb53e775ecd624
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Hide it from the QDS Manual.
Task-number: QTCREATORBUG-29361
Change-Id: I7c44aaed42e374b8e07d093279c8078ada18c250
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Do not use the icon of the root function for the artificial "Incoming"
and "Outgoing" items in the call hierarchy. In the case of deprecated
functions this can be a warning icon.
Change-Id: Ib75a66296210d4da24208e98efb527b9af37b793
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Without the export, when compiled on macOS (with clang), the call
"runControl()->aspect<RunAsRootAspect>()" in runcontrol.cpp would
return a nullptr, since ProjectExplorer and libUtils had different
vtables for TypedAspect<bool>.
Task-number: QTCREATORBUG-30516
Change-Id: Ic3cef6545e97f59af2a1138f13762c07d9402e4a
Reviewed-by: hjk <hjk@qt.io>
warning indentation; statement is not part of the previous 'for' [-Wmisleading-indentation]
if (__builtin_expect(!!(clients.removeAll(client) == 0), true)) {} else { ::Utils::writeAssertLocation( "\"" "clients.removeAll(client) == 0""\" in " "/data/dev/creator-out/src/plugins/languageclient/languageclientmanager.cpp" ":" "114"); } do {} while (0
Change-Id: I14297567627801d3a5436abf2df8fec23bff85dd
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
In an accompanying change, the installer writes versioned
settings keys. The version string will be appended to the
existing key, after a single underscore character.
When reading from the settings, the plugin first looks for
keys matching one of the requested versions from the kit.
Optionally, if no key for a matching version is found, the
key for the newest version available is chosen. This only
applies to the Qul SDK package for the time being.
If no suitable versioned key is found, the plain unversioned
settings key is picked
Task-number: QTCREATORBUG-29194
Change-Id: I2db888390cfb64a4b7c78ebcf795543251cb7a1b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
No need to create lambda on every call to credentialKey().
This should remove the warning about the
Performance inefficiencies (AUTO_CAUSES_COPY).
Change-Id: I9a7dc9cabcc6f80e58e39ef8be6a5445a11e0433
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This option is only shown when View3D item is selected.
Fixes: QDS-12207
Change-Id: I0a98b59a5eb3fe7abd689711939b649fe496eeb7
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Add a Clangd specific function hint model that alwys highlights the
current parameter based on the number of commas in front of the cursor
position, like the builtin code model. It also correctly closes the
proposal after typing the closing parenthesis.
Fixes: QTCREATORBUG-26346
Fixes: QTCREATORBUG-30489
Change-Id: I09d3ac6856acfe5e0f206d8c3a96dbb561ea2ce7
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Rename process.h back to qtcprocess.h
MSVC's "threads" standard header includes <process.h>, and that ends up
including our process.h from Utils.
There already was a hacky workaround in place for a similar issue with
MINGW, but that doesn't work with MSVC because that doesn't have
Simply use a name that doesn't conflict.
Change-Id: I1159cd2096b4f2dbc4a1728d0131dd6edd30ebd3
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
(cherry picked from commit 5af531cd39)
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The model needs the project store, the path cache, the imports and the
file path. So we now use a method in the model to copy them over to the
new model.
Task-number: QDS-12102
Change-Id: I80f911d55c5a5fdf9d1a87c1f4888e498086374b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
