The constructor for the category was missing. Otherwise the CTAD is not
working.
Change-Id: I4d4c2aaba8915fbbade0b8ce4f1310046d748cd1
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
The QmlDesigner landing page appears if a *.ui.qml document is open, and
user selects the "design" mode. Between QtC 12 and 13, the landing page
broke (unnoticed) due to the removal of the "Welcome_*" theme colors.
This change lets the Landing page use the new color tokens. A few fixes
in the PushButton component were needed.
Fixes: QTCREATORBUG-30547
Change-Id: I93319665bb283fba7f7a8892b671aaeb11479c7e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The warning was not shown when opening a project with the QML debugging
option enabled.
The `changeHandler` was explicitly called at construction, but at this
point the `warningLabel` doesn't have a parent. The `setVisible` call
was skipped in this case, to prevent opening a toplevel window (for a
short time) for it until it has a parent.
Unfortunately there is no Qt API for setting the "visibility to the
parent". Instead invert the logic: Let the label have default visibility
to start with (which is "visible if the parent is visible"), and force
it to hidden in `changeHandler` if necessary.
Amends eda5fbd645
Change-Id: I69b86a967ee1fe7bd3d5d035765349981b64eb72
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
In cases when a CMake project is using a CMake preset with a toolchain
file, the CMAKE_C|XX_COMIPLER value was not set in the CMakeCache.txt.
This commit makes sure that the cache from the CMake preset probe
contains CMAKE_C|XX_COMPILER values.
Task-number: QTCREATORBUG-30474
Change-Id: I63ac6fe2b043e49dda98e286b6d85950e34be920
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Using the same value for two topics hides the old topic, but
QDoc did not complain during local builds.
Change-Id: Id5d927cca60c9d288323429c99969475c9ecd15b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
ConPTY on windows will send "clear line" characters in response
to resizing the PTY.
During re-showing the terminal pane the widget receives a "height=0"
resize event. We have to ignore this otherwise the conpty might try to
clear the screen.
Another issue was that we are calling resize on the pty even thought the
process has ended and won't be able to respond to the clear attempty by
the pty anymore.
Fixes: QTCREATORBUG-30523
Change-Id: I24caeaffb31d255a0640952e2d35bda23fd16280
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Otherwise the cog menu appears below the popup
Change-Id: If3b541bd98b2d771687373c9259ad017349d4215
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Other code expects all of them to be collapsed, but Creator 13 expands
them when checking. This change makes sure they are collapsed afterwards.
The new code is backwards compatible with the old behavior.
Change-Id: Ic698fb17f3ad1573195e7e0f7bcf722beed74ffc
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
...to "Configuring Projects"
Turn "Linking Projects with GitLab" to a separate how-to
topic.
Some style edits.
Change-Id: I3fd68b303126770965c7ca68ca2e041daf593d74
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Url properties should be set as urls to avoid asserts.
Change-Id: I990e731f4555943ce35443226ab053286c58bd58
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Deeply under the hood, the color for ther Spinner was determined by the
QApplication palette, color role "Text".
In order to run the spinner on a dark toolbar (in a non-dark theme),
though, the color needs to be bright. It is the case for the
ScreenRecorder.
This change adds a color setter to the Spinner classes, adds colored
Spinners to tst_spinner and makes use of the feature in the
ScreenRecorder.
The default color of the Spinner remains QApplication palette, color
role "Text".
Change-Id: Ia75758707f225b1f994e73c5a314478101c80f5e
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
If the user selects "Record Screen" while the ffmpeg/ffprobe are not
set, the ScreenRecorder settings are shown. The ScreenRecorder dialog
did open up after the settings page, even if the user just pressed OK
without setting the tools.
With this change, not the settings page return value determines whether
to show the ScreenRecorder dialog, but rather a second check if the
tools are set/registered.
Change-Id: I35b8f4e3afe7ea5e6834fcff74ce8f73d3a115b4
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Put the future into the future synchronizer.
Otherwise, when (un)registedDocumentationNow() is still executed
on shutdown we are destroying the locked mutex and crash.
Change-Id: Ic8e7f8252719a3015101a0f5fc7b48ba57956562
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The old sources used deprecated features.
Done by:
1. Assuming that current Creator works correctly because
it is passing the test with the old sources.
2. Replacing the .tsv's contents with what Creator
generates from the new sources on Linux.
3. Removing everything from the .tsv which is not found
in the same place on Windows.
Change-Id: I31f0f1a46c1972d8c717c216275dd453ca74fc27
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
...to decouple them from the sources used in other tests.
Change-Id: I80b3ea1478cdffdc28933e4320971f98a11d1898
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Add the following topics to the creator-tutorials group:
- Building and Running an Example
- Debugging a C++ Example Application
Task-number: QTCREATORBUG-29361
Change-Id: Ib6de92e99caf552ee8337b49af48bd04d6760474
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
And move the general information to the Overview (or the Code
view docs in the QDS Manual).
Task-number: QTCREATORBUG-29361
Change-Id: Ib1d13f3d81d707691c84aa4241ed28662e2bc8ee
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
There is no reason to limit the environment modifications to unique
variables. The environment modifications are processed sequentially
from top to bottom and there may modifications that are done on the
same variable (e.g. once a prepend, once an append,..)
Change-Id: I8a187737be1108e537a926239088c6352dc92957
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
- Pastecode.xyz has been replaced with DPaste.com
- The process has changed
Task-number: QTCREATORBUG-30209
Change-Id: I1c52923ada597bd741787a8c7ad66425ed5168f9
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
It mostly broke when Qt changed containers from int to qsizetype:
When we use QDataStream to serialize the value of `QList::indexOf`, but
deserialize that into an `int` variable, we don't get the same value
back.
Fix that, and also use begin/endMoveRows, which results in a better
selection behavior after dropping.
Fixes: QTCREATORBUG-30469
Change-Id: Ic99181ea7f75958766977ce7cf9d17c3d96103e2
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Right click on 3D view will now always clear selection if
there is no model under the cursor when click happens.
Fixes: QDS-12227
Change-Id: I922fc79472ced4a3aa5e518c03731edf240e1d43
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Previously the SettingsDialog did not call Aspect::cancel().
Without this, the volatile value is not reset if the user did some
changes before pressing cancel.
This "should" mean that re-opening the settings dialog should present
the changed values again. But since not all aspects are implemented
correctly, they reinitialize from their value instead of their
volatileValue.
When the Settings Dialog is reopened and applied, a warning is triggered
as the container thinks its dirty, but the Aspect::apply returns false.
Change-Id: I8fac66fc95f9118d69c789ced22481d121769f0b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
It is not in the dialog described in the topic.
Change-Id: Ia0d1a399a2926e78cb8a0cc772abb7e2adc14840
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
And hide it from the top level TOC in the manual.
Link to "How To: Build with CMake" from CMake topics.
Task-number: QTCREATORBUG-29361
Change-Id: If0522cdd9636ac075e8bdeafa0fc7248199aaf2a
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Edit camera speed configuration consists of a slider and a multiplier,
which combine into the total camera speed.
Speed and multiplier are stored per scene.
Fixes: QDS-12187
Change-Id: I587c04cf80d1ca95b5a38c406158e46cdb91d06f
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>