Commit Graph

68765 Commits

Author SHA1 Message Date
Brook Cronin
8127f9d2d5 QmlDesigner: Add medium size 3d primatives to icon font
Change-Id: Ia421e47a3b98e2d83a1bdb0b529f22ec93dc4dce
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-07 15:52:26 +00:00
Mahmoud Badri
23c6698b15 QmlDesigner: Add "Show in explorer" option to assets context menu
Fixes: QDS-9061
Change-Id: Id91336819f6836a98c8fd34562c0f8672c11a288
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-02-07 15:37:31 +00:00
Miikka Heikkinen
a5949543b6 QmlDesigner: Fix condition chains in 3D import options
When an import option conditionally depends on another option that
depends on a third option, toggling the third option needs to change
the enabled state of the first option controls as well as the second
option controls.

For example, consider this set of options (actual case with options
for generating mesh levels of detail in Qt 6.5):

optA
  optB, enabled when optA is true
    optC, enabled when optB is true
    optD, enabled when optB is true

If optA is false, optC and optD controls need to be disabled even if
optB is true, because of the chained conditions.

Fixes: QDS-9055
Change-Id: I10aeb7596cf9c8a9053c7d08ec9ebb7a46db2cd2
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-02-07 14:55:18 +00:00
Thomas Hartmann
980a9044f9 QmlDesigner: Add 'the' to feedback dialog
Task-number: QDS-8870
Change-Id: Ic5aab691d4ed1714ebc078fc5c985e39640d2ba8
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
Reviewed-by: Pranta Ghosh Dastider <pranta.dastider@qt.io>
2023-02-07 14:32:15 +00:00
hjk
89880907f2 Debugger: Simplify paramenter setup on Windows
Change-Id: Iec44dd33287ac23d2b51ef32483eae831d2ce4bd
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-02-07 14:07:52 +00:00
hjk
cbf2b23787 QmlDesigner: Remove unused global static
Building CXX object src/plugins/qmlde...dir/components/componentcore/designericons.cpp.o
/data/dev/creator-out/src/plugins/qmldesigner/components/componentcore/designericons.cpp:84:21: warning: ‘const QStringList& {anonymous}::iconFontMandatoryKeys()’ defined but not used [-Wunused-function]
   84 | const QStringList & iconFontMandatoryKeys()
      |                     ^~~~~~~~~~~~~~~~~~~~~

Change-Id: I978d6a52cf4030fe07352d6ee89c2db3d0433c05
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-07 14:01:42 +00:00
Christian Stenger
d2656c60e6 AutoTest: Widen scope for run under cursor
..and debug under cursor for QtTest and GTest.

Depending on the information coming from the code model
we may be able to get a correct scope even when standing
inside the function that is defining the test.
This makes more sense than the original behavior which
made it a hard requirement to stand on a literal to
run or debug a test under cursor.
But as the codemodel does not provide usable information
for all frameworks keep the original behavior as fallback.

Task-number: QTCREATORBUG-28752
Change-Id: I13ea7b0ad1e8207da6cb884d212667c4c657957c
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-02-07 13:56:07 +00:00
Christian Stenger
9277bb5111 AutoTest: Extract function to get active frameworks
For later re-use.

Change-Id: I87cf6db4de861b626e4669351df3f5119952328f
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-02-07 13:56:01 +00:00
Marcus Tillmanns
96185ca4f1 Utils: Use QtcProcess in FilePath::fileContents
Change-Id: Ia7236632c6d9b887d054a3254762b7e3592e73e1
Reviewed-by: hjk <hjk@qt.io>
2023-02-07 13:55:31 +00:00
Christian Kandeler
8096b9f524 Update qbs submodule to HEAD of 2.0 branch
Change-Id: If53431a0cf8bf412a28e606b0712e0acb26e07f5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-02-07 13:48:59 +00:00
Mahmoud Badri
435dfda150 QmlDesigner: Fix assets view wrong scrolling after drag-n-drop
Change-Id: I3904beb63441d1cf9a0d577fc6c96bbecc8e2ebf
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-02-07 13:34:49 +00:00
Marcus Tillmanns
78cf3eb671 Docker: Check writeData
Previously only the process mode was checked to decide
whether we need an interactive docker session when starting
a process.

Change-Id: Ia80c78d861107239d0c86c405e06f30e7770ff8e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-02-07 13:06:56 +00:00
Jarek Kobus
84ba73be8c RunExtenstions: Remove StackSizeInBytes
It's currently not used.

Change-Id: I223a2e8add92a107b85518bcaf44bbd8a5e3fb9a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-02-07 12:56:43 +00:00
David Schulz
fbcf0fb3bf ClangCodeModel: Fix initial processor state
It is expected that the processor that is created by the provider is not
running.

Fixes: QTCREATORBUG-28769
Change-Id: Icef270c5f9255b97aa04fc3d0ea0cf872787bd24
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-02-07 12:54:47 +00:00
Mahmoud Badri
6291ee4e79 QmlDesigner: Fix Components lib wrong scrolling after drag-n-drop
Change-Id: Ibd3f3c155496443eac0accf468280a15cad51351
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-02-07 12:52:38 +00:00
Thomas Hartmann
51864d0808 QmlJS: Allow string::arg() in ui.qml files
Task-number: QDS-9037
Change-Id: Ie91e745ae4d20e0fd96df1d767fc875475a0be7a
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-02-07 12:31:55 +00:00
Marcus Tillmanns
96ebe93ecb Debugger: Rebuild AttachCoreDialog
The old dialog was based on local vs. remote file paths.
These days we can simply treat them the same.

If the selected files are not on the same device as the
debuggger they will be copied first.

Change-Id: If5ec93d1e1e49c51b3032fec8384682d2a5e35b4
Reviewed-by: hjk <hjk@qt.io>
2023-02-07 12:31:40 +00:00
Christian Kandeler
cc52478a93 LanguageClient: Export LanguageClientOutlineItem
To enable more customizations by specialized clients.

Change-Id: I0ad92e248e931389c3fa239df424df8883e1d86e
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-02-07 12:01:31 +00:00
Mahmoud Badri
ce1092ea50 QmlDesigner: Fix content library autoscrolls after drag-n-drop
Fixes: QDS-8711
Change-Id: I1ca399928a299d4917814bf651a8291b981f0f32
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-02-07 11:56:26 +00:00
Christian Stenger
1e92039dc1 Utils: Fix build of sdktool
Amends d829d9ff33.

Change-Id: Ib2c7543f04444b30c389346eb910861957e19b8d
Reviewed-by: hjk <hjk@qt.io>
2023-02-07 11:26:44 +00:00
Marcus Tillmanns
e780ca991c Docker: Use rootPath() for Shell
Change-Id: Ie2578b768d8fcb91c55a33b4eb62e43c127ccee2
Reviewed-by: hjk <hjk@qt.io>
2023-02-07 11:16:02 +00:00
Marcus Tillmanns
9d6b3b4cb4 Utils: Remove status= when using dd
Some versions of dd don't support the status= option.
(e.g. the dd version in boot2qt)

Change-Id: I22aa6571b223b7707e962bd2df9abdd11b438d69
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-02-07 11:15:49 +00:00
Alessandro Portale
5342fa5757 Fossil: Register wizards path only once
Change-Id: I5b3d6bfb035dc364d4ec8c379b8b3214541c2ff8
Reviewed-by: hjk <hjk@qt.io>
2023-02-07 10:29:02 +00:00
hjk
a459a70ed3 Haskell: Convert to SPDX-style copyright headers
Change-Id: I9b31b209a4c43617d2a7a02880b10a573e3d8540
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-02-07 10:20:14 +00:00
Eike Ziller
541aafecbb QML: Fix crash when opening context menu
The AssistInterface changed to unique_ptr, but the internals of how the
QmlJSEditor looked for quick fixes still wrapped it into a
QSharedPointer, which then deleted the assist interface in addition to
the unique_ptr.

Amends 0e4b0a26d3

Fixes: QTCREATORBUG-28742
Change-Id: If685dbb2c49b09d529d0dcb3677dc90b03a039f0
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-07 10:12:25 +00:00
Thomas Hartmann
c51320b3ad ADS: Fix crash when loading worksapaces
The formeditor workspace did exist twice.

Change-Id: If3ecd5918df46975a15bab2330246d338a5cea51
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-02-07 09:52:14 +00:00
David Schulz
2293488536 ClangCodeModel: prevent accessing nullptr
There is a certain amount of time between resetting the processor to
nullptr in ClangdFollowSymbol::VirtualFunctionAssistProcessor::cancel
and the destruction of the ClangdFollowSymbol sentinel. So we also need
to check the processor before calling update.

Task-number: QTCREATORBUG-28769
Change-Id: Idec7c9dd7648285ecf2360c309d9751303f6209c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-02-07 09:44:01 +00:00
Mahmoud Badri
cae28d82d3 QmlDesigner: Fix material browser wrong scrolling after drag-n-drop
The actual bug is somewhere deep in the Qml ScrollBar's implementation.
The workaround is to disable the scrollbar while dragging is on.

Fixes: QDS-7849
Change-Id: I9bedd8a8f0947c0e3d1a01e6d6e9962e9826d460
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-02-07 09:40:06 +00:00
Marcus Tillmanns
516fce6f53 Utils: Add FilePath::tmpDir and createTempFile
Change-Id: I6f3143e59a87edffeee5e08708ba721293a8a369
Reviewed-by: hjk <hjk@qt.io>
2023-02-07 09:28:38 +00:00
Amr Essam
13a93a6b57 QmlDesigner: Enable effect animation by default
Also included some enhancements to ModelNodeOperations

Task-number: QTBUG-110486
Change-Id: Ibaeef035121fff070119100560efcdab03e1a273
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-02-07 09:19:46 +00:00
Alessandro Portale
02777c4179 Fossil: Inline configuredialog.ui
Change-Id: I74e7372ef4839788f4cf9bf0595c9f0a41c0a604
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-02-07 08:59:01 +00:00
Marcus Tillmanns
0c1b59fb1a Utils: Use isSameDevice in copyFile
Change-Id: I36389a88c4474d46ef4fdb9369cf9f4219f6099d
Reviewed-by: hjk <hjk@qt.io>
2023-02-07 08:17:16 +00:00
Marcus Tillmanns
144dff8d74 Gdb: Use path() of executable
Change-Id: I872da3995344b6337b5d72925768034b58f9b339
Reviewed-by: hjk <hjk@qt.io>
2023-02-07 08:17:08 +00:00
Eike Ziller
3358f94cb7 CMake: Detect cmake from ARM homebrew on macOS
Change-Id: I67c539c9e9a42de086df9e0c12fa4e661494e121
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-07 08:01:33 +00:00
Eike Ziller
c1656c2f3c UpdateInfo: Fix never ending progress spinner in settings
When searching for updates from the settings page. We need to always
send the signal that the search finished.

Fixes: QTCREATORBUG-28745
Change-Id: Ia4c764081916fdde4175799ab6d74fb7c4045810
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-02-07 08:00:40 +00:00
hjk
f1c302af0c Fossil: Inline fossilcommitpanel.ui
Change-Id: I9be4ed8cd598bc6c9b1bdef00b8eb28d2f0ac0dd
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-02-07 07:20:56 +00:00
Alessandro Portale
c4f6887b1d GlslEditor: Tr::tr()
Change-Id: I261cad5b85535d42a9b96d1a0ade53dbc7addf86
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-06 22:45:18 +00:00
Alessandro Portale
b919171375 EmacsKeys: Tr::tr()
Change-Id: I52ccb149237e01595a515c6bb380490276e343b7
Reviewed-by: hjk <hjk@qt.io>
2023-02-06 22:45:05 +00:00
Thomas Hartmann
e7803a20d7 QmlDesigner: Properly initialize member
m_qmlPuppetPath was not initialized

Change-Id: I80f4b17888373db64f40790d9e80d8fd30ae805e
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-02-06 17:12:31 +00:00
Jarek Kobus
930312546d ClangFormatPlugin: Don't leak ClangFormatStyleFactory
Detected by memory analyzer.
Remove unneeded includes.

Change-Id: I270b8a6f1d98fc25297b1f69e899551399437cf0
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-02-06 14:52:58 +00:00
Miikka Heikkinen
e534c3224d QmlDesigner: Fix Qt version check in Assets view
The order of arguments in modelIndex call is only swapped for Qt 6.4.

Fixes: QDS-9044
Change-Id: I826ef8136d4669796645e8bbeed5ff53bb77275e
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-02-06 13:51:23 +00:00
Jarek Kobus
10295fc0fa PublicKeyDeploymentDialog: Reuse new StringUtils methods
Change-Id: I7f207a158b8a22ab94327d6c43b4c898b31cf646
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-06 11:52:25 +00:00
Thomas Hartmann
27dc19aeb3 QmlDesigner: Implement kit changing in status bar
Task-number: QDS-8975
Change-Id: Ie28585b76697f785bea2d5bb3360a6949c9c55d8
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-06 11:19:47 +00:00
Jarek Kobus
33badfa660 PathChooser: Don't leak menu
Found by memory analyzer.

Amends b3f82887a3

Change-Id: I580ab0873f5c3556445a87d9fc2c806eeb48c57e
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-02-06 10:51:44 +00:00
Jarek Kobus
a423caba13 ClangFormatBaseIndenter: Initialize llvmFileSystemAdapter
Otherwise memory analyzer reports use of uninitialized value.

Amends eeeb5f0aad

Change-Id: Ic0cb0a40062a82caef73987109e8970fc57f93b6
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-06 10:25:51 +00:00
Eike Ziller
dc5d416937 Merge remote-tracking branch 'origin/10.0'
Change-Id: I40658d2a1166733c508a348d6df8034f2df1be0a
2023-02-06 10:39:08 +01:00
Eike Ziller
d278135497 Merge remote-tracking branch 'origin/9.0' into 10.0
Change-Id: I8d73198561f6ff7877d580681ca2a0018b7dc3b1
2023-02-06 10:14:18 +01:00
Miikka Heikkinen
0c0e7f1fe1 QmlDesigner: Insert added dynamic properties to correct position
Dynamic properties were sorted on initial open, but newly added
properties were just appended.

Fixes: QDS-9019
Change-Id: I20a47e3f3554274c794ee2cdea8b8c925c1c57fd
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-02-06 09:05:09 +00:00
Jarek Kobus
23309b5977 TestCodeParser: Reuse TaskTree
Change-Id: Idf42f2c732151d32d70db9d2344bb18664119857
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-02-06 06:53:24 +00:00
Christian Stenger
82d2f02c3f DiffEditor: Fix compile
Amends bf64af6f52.

Change-Id: I68cae9b6444156c9d4be3f54d09c3abd415fae91
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-02-06 05:51:25 +00:00