* Calling it for each parsed line mixes unrelated logic.
* I consider adding a cache later, but that will require data for
all the remotes before this call.
Change-Id: Ic3ee975fc6172f2a8848bc8d0a6620d4ccbf9cd2
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Instead of just providing the hidden search, provide a more
obvious present filter functionality for the text output
similar to what is done in other output windows.
This still has the find functionality present as well.
Task-number: QTCREATORBUG-28706
Change-Id: I8f8b1494d86c90cbb9ea6bfad3f0e74caf3de2c9
Reviewed-by: David Schulz <david.schulz@qt.io>
It's a very short command, so the time penalty for spawning another
process doesn't worth the additional termination protection.
Amends commit 371e674967.
Change-Id: I151f0bc1838cd9ddbdf822cbe5cf8923da6a9499
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This reduces executions in BranchModel::updateUpstreamStatus (which is
called for each local branch with a tracking branch) from 3s to ~700ms
on Windows.
Change-Id: I92651ba8f37987bef49a80b46963964ae8cacb3c
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Calling <Module>::Tr::tr() is preferred over
QCoreApplication::translate("::<Module>", "..."). This changes
occurrences in .cpp files.
Change-Id: I3311ef0dbf3e7d105a3f181b6b988f3b444468f1
Reviewed-by: hjk <hjk@qt.io>
This changes several tr() calls which were either missed during Tr::tr-
ization or were added later.
Found with regular expression: (?<!(Tr::)|([\w]))tr\(
Change-Id: I1c0c03589e941614a7a8449ecfebc7d2cad396c3
Reviewed-by: hjk <hjk@qt.io>
We can use NodeMetaInfo instead of directly accessing the code model.
Task-number: QDS-8800
Change-Id: I1d73e2a470c40a15e5237544746cb4b841f8e1b7
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
...in the main thread.
Set QTC_PROCESS_THRESHOLD (in ms) to receive warnings for them.
Change-Id: Ia9e9c14b5ca339bfa2be82930518f988f56620c2
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Keyboard navigation now accounts for collapsed sections and
items hidden with search filter. Also, navigation is suppressed
while search box has focus.
Fixes: QDS-9108
Change-Id: I9fb555803cd72fb3550d5e30e20c62a40f845ef3
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
If kits are broken, then users can end up in the edit mode.
We should allow changing kits and settings here.
Change-Id: Ic6410942c3b0c1d9e7c04989efab57d7690c0694
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
If we delete the item we also delete the children.
This will crash if the children is further down the list.
We have to delete without children.
Task-number: QDS-8961
Change-Id: Ia17f9ef23339dbe36e848fa49928cb3c0077d6f1
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Make it possible to mix synchronous and asynchronous calls
inside task tree.
Basically, it's a shortcut for:
bool syncMethod();
Group {
OnGroupSetup([syncMethod] { return syncMethod()
? TaskAction::StopWithDone
: TaskAction::StopWithError; })
}
Please note: similarly to Group, Sync isn't counted as a task
inside taskCount() and doesn't emit TaskTree::progressValueChanged()
when finished. It's being considered as a simple handler
that doesn't last long and shouldn't block the GUI thread.
Otherwise, use AsyncTask instead.
Change-Id: If71c5da2f9b202a69c41a555cc93d314476952f4
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The price of having to loop in two places seems small compared
to cleaner relations between the classes.
There's a new hack in the helpmanager to make sure we aren't
looping to often. The hack wouldn't be needed if the (odd(?))
check there weren't there.
Change-Id: Ifed50213b2de8feedfb45c185808d163c00c19ca
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
And handle the consequences in qmakebuildconfiguration.cpp.
Change-Id: Ic24d99927254e8d16decea49b880a2446bf322e6
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
QtQuick.Controls has sub imports like QtQuick.Controls.macOS/windows
that wil lbe invalid on other platforms. In this case we do not want
to mark the original import as invalid, since it turns
off checks in QmlJSCheck.
Therefore moving the setting to invalid into the block that is only
executed for non optional sub imports.
Task-number: QDS-9094
Change-Id: If0ad4e32c14d608f88b8239f390208e51a93fbd8
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Only update the changed blocks and use sets instead of lists to
store the info and create the diff.
Change-Id: I08d81b326ceebdc6bf2ba322886b7bf5671b2769
Reviewed-by: David Schulz <david.schulz@qt.io>
- Use map for merging intervals instead 2 times list iteration.
- Time complexity O(nlogn) instead O(n^2)
Change-Id: If65391999e1ff191752447935602fcc9847243fe
Reviewed-by: David Schulz <david.schulz@qt.io>
This change makes it possible to bake in settings for bundled/shipped
Qt versions like we have in the QtDesignStudio.app package.
The result is that the installer does not need to write absolute
paths to the settings anymore, so it stays like it was signed.
A signed package on macOS is more and more necessary
and recommended for a while. Especially If the application will
touch files in special folders like Download, Documents, or Desktop.
Change-Id: I3153ffd4229b34a59bdfe740937c21ee93de3e9b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
There is no advantage to excluding the tools by default that outweighs
the risk for them to get out of sync with the rest of the codebase.
Change-Id: I3ad292aa5648a4448babdf5d06c84b3f5ec94482
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Environment::searchInPath() does not know from which device it came.
Therefore it will take the PATH variable as it is ( without the
device://... prefix ) and search for files on the local device.
Change-Id: Iecddb5ee1beb4ac821a9ac592f6edb1fc0f68b54
Reviewed-by: David Schulz <david.schulz@qt.io>
And clean up a bit
Change-Id: Idcc95ec94a437428caf97b7866b2c1e40f9a35c4
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Reviewed-by: hjk <hjk@qt.io>
If declaration and definition of a symbol are present, offer only the
definition, as in the function and class locators.
Fixes: QTCREATORBUG-13894
Change-Id: I6794607c4c45831df53b022bbdad9db7205a890b
Reviewed-by: David Schulz <david.schulz@qt.io>
Assignment and compare in a while() loop is trouble. Fixed
bug where index always was 1.
Change-Id: I037d8c2290cf44c6200354b7c44950009e26c583
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Remove the Qt SDK detection of conan. This is no longer valid with the
scripts being copied to ${buildDir}/.qtc/. Qt SDK also doesn't ship
conan anymore.
Do validation for conan via "conan --version" and vcpkg via "vcpkg
version".
For vcpkg the program path is resolved for symlinks and for Windows the
target architecture is being detected from the compiler path.
Change-Id: If0da79c952392d5ac9f8352e262b0802d6eb9ed3
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
- Old icons applied to the actions of the DesignerActionManager
in order to prevent showing texts on the old top toolbar.
- Reset icon is now available only for on state.
Task-number: QDS-8910
Change-Id: Ibd2d703b5e760709e5da81e6a3d3d93d5ba0e104
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
