Commit Graph

68765 Commits

Author SHA1 Message Date
Ali Kianian
3d02d08612 QmlDesigner: Clean up 3D Toolbar
* Item orders for 3D toolbar is modified
* ParticleSeeker is available as an action, and also an Edit3DAction

Task-number: QDS-9082
Change-Id: I210feaa416934c3e287a1a177720db69138ffab3
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-02-21 08:01:38 +00:00
Alessandro Portale
a5d4187630 Squish: Use Tr::tr() where possible
It is more "type-safe"

Change-Id: If406de0e2c8896913ecc3b9b86cc603de7d22d3f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-02-21 07:56:03 +00:00
Jarek Kobus
69ec9c4361 TaskTree: Add TreeStorage::operator*()
Reuse it in some places.

Change-Id: I335f38fa0384ea17bd8e981d743f835c3f05b731
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-02-21 07:31:48 +00:00
Alessandro Portale
36c6a255b1 QmlDesigner: Add missing plugin dependency to QmakeProjectManager
Otherwise, launching with "-noload all -load QmlDesigner" fails.

Change-Id: Icae219fd90aad799257384bccc4bb4ab60cf5e2a
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-02-21 07:31:07 +00:00
hjk
dce7025969 MarkdownView: Merge into TextEditor
Make it a bit more compact, too.

Change-Id: I448164371c5a1d6969a292feba17caa2826f58c3
Reviewed-by: Tasuku Suzuki <tasuku.suzuki@signal-slot.co.jp>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-02-21 07:17:29 +00:00
Marco Bubke
b0ae85096e QmlDesigner: Fix warning
Change-Id: I334d1b508175885933b1f14212af353f29b7414c
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-02-21 07:08:50 +00:00
Thomas Hartmann
3534e0d27e QmlDesigner: Remove min-wdith for dockwidget tabs
The min-width does not play nicely in all cases.

Change-Id: Ic60d602aee02ea7e924ebed9b43d753665028c3a
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-02-20 16:41:09 +00:00
Thomas Hartmann
479924497f QmlDesigner: Fix feedback dialog on macOS
Qt::SplashScreen prevents the widget from getting any keyboard focus.
Using TextEdit for neutral styling.

Change-Id: I56b9a3ac10d68aebdef4064fed4dd2e31bf82b8e
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-02-20 16:18:50 +00:00
Artem Sokolovskii
25178ed8f4 Core: Speed up opendocumentsfilter
Do not rebuild the complete list of editors every time anything changes.
Handle the incremental update via the DocumentModel::model() signals
(while ignoring the "<no document>" item at the top).

Fix a bug that DocumentModel sent a dataChanged signal from
disambiguateDisplayNames for an index before the corresponding
rowsInserted signal was sent (by endInsertRows).

Change-Id: If9c02fef94e9c744b859db7a07c8464c4e06a73b
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-02-20 15:00:31 +00:00
Miikka Heikkinen
0b9eb65d97 QmlDesigner: Allow texture/light probe creation for hdr and ktx files
Also refactored Asset class a bit to optimize cases where multiple type
checks are done against same asset by resolving type at constructor
instead of on demand. Pretty much all cases where Asset instance
is needed also require resolving the type, so this makes sense.
Refactored the remaining cases to not create Asset instance
unnecessarily.

Fixes: QDS-9128
Change-Id: If9d518c9dcfcc70962e5d4e9881889c6ac243c97
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-02-20 14:45:35 +00:00
Jarek Kobus
efc4a0f1af AsyncTask: Make it possible to run with promise
Using QtConcurrent API.
Adapt asynctask tests according to new API.
The old API in going to be removed, soon.

Change-Id: I3cf163e9492526f0b49bd162c27e6c55a98ace7a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-02-20 14:21:06 +00:00
Marco Bubke
ba6c1344b6 QmlDesigner: Integrate ProjectStoragePathWatcher
Task-number: QDS-9170
Change-Id: Iedbb07e41232beeb73cd12c89f892eec7968d084
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2023-02-20 14:12:43 +00:00
Marco Bubke
96ea9e3891 QmlDesigner: Stop on every warning
We already had some bugs because warnings were ignored. So we generate
errors now for the qml desinger plugins.

Task-number: QDS-9135
Change-Id: I9276a1b5cdbec554bc33c0c6ed3706817518f39c
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-02-20 14:12:28 +00:00
Marco Bubke
332b2fb421 QmlDesigner: Integrate ProjectStoragePathWatcherNotifier into updater
Task-number: QDS-9092
Change-Id: I6f262367898e54f1c029d6c6b83778919d18ddee
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-02-20 14:03:25 +00:00
Thomas Hartmann
407167cf90 QmlDesigner: Adjust CSS for dockwidgets
* Add padding on the left to account for close button.
* Set minimum size of 80px for tab
* Use different colors for hover

Change-Id: I87dd98aa939c85278bd2312de50117f1f32fb274
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-02-20 13:44:46 +00:00
Thomas Hartmann
27b93900bf QmlDesigner: Use DSdockWidgetTitleBar for close icon in ADS
Change-Id: I28d479490a5c0550199a0d0a20e7cffa8494146a
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-02-20 13:39:44 +00:00
Artem Sokolovskii
41aeb175b8 Android: Move tests from sdkmanager class to test class
Change-Id: I2e7be8f33b40d7c67e72efa88ca5528deb046ade
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-02-20 13:35:16 +00:00
Jarek Kobus
b9dca8f8fa ExtensionSystem: Use TestCreator in more places
Amends b59e632ac3

Change-Id: I11000c488c6a69b4c55b8ccb164fa6587abb8b5b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
2023-02-20 13:33:30 +00:00
Thomas Hartmann
68a6b12b5a StudioWelcome: Open design mode if project is opened again
If an already opened project is opened again we swtich to design
mode instead of edit mode and showing an error message.

Task-number: QDS-9183
Change-Id: I291e32a9824103a8f14f4fd618cc9211408ff2da
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-02-20 13:33:16 +00:00
Samuel Ghinet
1a6cc6fa5e QmlDesigner: Make ContentLibrary textures downloadable
At this point the textures_bundle is still required, but only because
of the icons of the textures. Also, some changes should be done for the
visuals of the downloading.

Also, did a fix in FileDownloader: In case the URL given does not look
to be an image file, we should cancel the download instead of treating
it as a zip archive--it can be that eg we were redirected to a sign-in
page and we don't want to download the content of the page and save it
as a zip file.

Task-number: QDS-8664
Change-Id: Iec40e540c116030288df76e1922eab56ba323d1e
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-02-20 12:28:44 +00:00
Henning Gruendl
519b9e3c52 QmlDesigner: Fix startup crash on linux
Task-number: QDS-9198
Change-Id: I1e0f87a941ccbd2131f0e86ae20f7a2d0c2d7856
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-02-20 10:15:55 +00:00
Jarek Kobus
6c50298fa5 RunWorker: Remove watchdog functionality
Not used anymore.

Change-Id: Ib28287648dd15a31775a72c5a821ba33cae255fa
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-02-20 10:14:10 +00:00
Jarek Kobus
ce082b7bc4 RunWorker: Remove unused virtual function
Change-Id: I70788a0a17f5fcb214b63c812a6bb8a3547e7ebc
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-02-20 10:11:59 +00:00
Alessandro Portale
50d2565c68 Translations: Fix occurrence of tr() call with randomn context
Change-Id: Iaba347e3611f894c9f76cffa7e8b7870d13d9920
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-02-20 10:03:14 +00:00
Christian Kandeler
7fe9363395 CPlusPlus: Use categorized logging in lexer
Not suprisingly, the #ifdef-based debugging produced uncompilable code
when enabled.

Change-Id: I4a6646bfa98a8500491be4892d464ec88512bec7
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-02-20 09:03:55 +00:00
Alessandro Portale
e27f82b49e Translations: Merge "OpenWith::Editors" into "QtC::Core"
Change-Id: I241ccc53afa11fa3faa1f1ca9363421827081812
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-02-20 08:00:37 +00:00
Andre Hartmann
b9af26adf3 Git: Fix soft asserts on failing instant blame
When git blame returns no output, silently avoid creating
annotations instead flooding soft asserts.

This situation can easily happen when navigating to a
header file that is not under version control.

Fixes: QTCREATORBUG-28768
Change-Id: I8d2f443dec98575221995a9016bd2f8442c682cf
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-02-19 14:56:14 +00:00
Orgad Shaneh
10dc4f93f4 VCS: Recover clearer actions when closing commit editor
Amends commit d63bfa4a29, and recovers the
actions that were introduced in 15b176e30c
(relates to QTCREATORBUG-18799).

I keep being confused by these Yes/No myself :)

Change-Id: I0429ef9c25231b96bd595a1bfb6808b621db54e5
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2023-02-18 16:58:22 +00:00
Tasuku Suzuki
8b70e59cdb Add markdown viewer plugin
Fixes: QTCREATORBUG-27883
Change-Id: Ie4099b8a322797d300bc15a80333bcb361ecafc3
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2023-02-18 16:40:10 +00:00
Miikka Heikkinen
5248922e0e QmlDesigner: Focus the content widget of the dock when focusing tab
When DockWidgetTab or DockWidget is focused, typically user actually
wants to focus the content widget, so we now do that.
Focusing content widget is done asynchronously to avoid complications
from doing another setFocus in middle of setFocus handling.

Fixes: QDS-9104
Change-Id: I569639c2f36f0721aafcdcab3498c875e98993a9
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-17 16:28:30 +00:00
Thomas Hartmann
f681b696e9 QmlDesigner: Add StudioQuickWidget
This makes it easy to share the QQmlEngine between different
QQuickWidgets.
All StudioQuickWidgets share the same engine.

Change-Id: I2b370a45a14fdc143e161e2aca62b45aa0d91da9
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-02-17 16:01:32 +00:00
Brook Cronin
9e2926c537 QmlDesigner: Update component icon in nav to new design
Change-Id: I1cdcc9aeb1b654b2a3e01a08ce21f11bda94df2e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-02-17 15:52:48 +00:00
Thomas Hartmann
1cbbcea8cc QmlDesigner: Move global annotations to edit mode
Task-number: QDS-9194
Change-Id: Iadba8028e5c4c91195413094086ec5c87329dff3
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-02-17 15:44:19 +00:00
Thomas Hartmann
9b06fa46fb QmlDesigner: Fix FlowView issue
NodeMetaInfo is always valid since last refactoring.

Task-number: QDS-9188
Change-Id: Idc7e7de9031485b12a0764e0aca3f89d482cdd72
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-02-17 15:40:46 +00:00
Thomas Hartmann
a4605a962e QmlDesigner: Fix crash
Task-number: QDS-9187
Change-Id: I3711da6a3dbab1bda1bf2c33da1834ca017e4d30
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-02-17 15:38:38 +00:00
Thomas Hartmann
2b9fcb8132 QmlDesigner: Use StudioQuickWidget for states editor
Change-Id: I4c6c85b9f92769700f979b070dd96cb0c50a58cd
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-02-17 15:28:53 +00:00
Mahmoud Badri
0fb12133bb QmlDesigner: Fix drag reset animation after drop on mac
Fixes: QDS-8933
Change-Id: Iab88c996c98e2f1eb01c0282445409411226ff95
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-02-17 15:25:54 +00:00
Ali Kianian
b6bfa5bd1f QmlDesigner: Clean up curve editor toolbar
- Slider size is adjusted
- Zoom actions are available
- Spinbox controls and labels are aligned to right
- Control styles are modified

find better style for the controls

Task-number: QDS-9079
Change-Id: I3fa376102d71ea6f904e72de1e6cc2f50ad1c8b6
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-02-17 14:45:59 +00:00
Christian Stenger
1a4badb705 SyntaxHighlighting: Fix qbs build
Broke with 30c768badb.

Change-Id: Id8b56247acc9d2eb447ca85d1c5c7c5bc77f70bb
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-02-17 13:39:53 +00:00
Christian Kandeler
9098357471 Update qbs submodule to HEAD of 2.0 branch
Change-Id: I7451d19dfc52fc416ecb3e4594912480fb131549
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-02-17 11:54:58 +00:00
Eike Ziller
330a6f793c Link with Qt: Remove now harmful check
The check was trying to find out if the Qt Creator installation is part
of the online installer or a Qt installer, by checking if there are
install settings without the key "Settings/InstallSettings".

Since we made Qt Creator optional in the installer, the install settings
contain that redirection key anyway, so it is no longer an indicator for
Qt Creator being part of the online or an Qt installer anymore.

Actually the check now _disables_ the Link with Qt button for the
commercial Qt Creator offline installer on macOS, because that ships
install settings that add the plugin path to the commercial plugins
outside the Qt Creator app bundle, but does not contain "Settings/
InstallSettings".

Just remove the check.

Change-Id: I88c3ef007a728dff0f4214e5a5683ffcede23796
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-02-17 11:35:55 +00:00
Marcus Tillmanns
8ed10639b6 Utils: Make getFileAccess static
Change-Id: I6af1ee8be88bf378bd1ddff8fee02005cc9ed6cb
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-02-17 11:22:50 +00:00
Ali Kianian
c4cae904ee QmlDesigner: Style particle slider for new theme
The style for slider is overridden in ManhattanStyle.
SeekSlider is modified.

Task-number: QDS-9134
Change-Id: Ib96413f2bb7918d611adf4fc19c184efae1c4f4c
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-02-17 10:57:10 +00:00
Alessandro Portale
6e24d3eec8 Translations: Fix some Tr::tr() calls
Tr::Tr::tr("Foo") would introduce extra translation contexts.

Change-Id: I43903d53d7d65677bb6b7a8bfd85eb5013c1fe6b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-02-17 10:17:40 +00:00
Mahmoud Badri
3f816fdc77 QmlDesigner: Create texture id based on name
Fixes: QDS-9131
Change-Id: I76d7a0aa132625664518b6d785f4a9edc9ee8e50
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-02-17 10:12:30 +00:00
hjk
9af5ebe856 ProjectExplorer: Use new plugin test object setup
Here a bit less mechanical due to the indirection.

Change-Id: Ia328a267ad0adc0ce1ea1ad56ffc67dc67666418
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-17 10:10:33 +00:00
Jarek Kobus
af03f49bf7 LlvmFileSystemAdapter: Don't use uninitialized memory
Create std::string explicitly using pointer to data and data size.
SmallVectorImpl<char> doesn't include terminating \0, so passing
data size is needed.

Fixes: QTCREATORBUG-28812
Change-Id: I63bd290e990ec8e4cd4fb609764a79e6feff92bc
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-17 09:37:46 +00:00
hjk
6ed246e5e2 Core: Use CommandLine for Spotlight locator filter
Change-Id: I2325ae2e55400ddf119bbc1ab2069dc54a79b687
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-02-17 09:32:11 +00:00
hjk
dcb7a1a119 SilverSearcher: Convert to rew plugin test setup
Change-Id: I219c921df1d073ae3e3405d595a4abc3efbce289
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-02-17 09:31:58 +00:00
David Schulz
30c768badb Editor: update ksyntaxhighlighting engine to v5.103.0
Task-number: QTCREATORBUG-22558
Change-Id: Ifbb0fe4b02c07d3d6afb35d84644fe8e3542e8d2
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-02-17 08:57:46 +00:00