Commit Graph

68765 Commits

Author SHA1 Message Date
hjk
9b0d90ec33 Help: Clean up constants definitions
Some unused, some style.

Change-Id: I3308e2c7a6a4ce861d32889682f4a57b45d4f894
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-07-20 12:37:12 +00:00
Eike Ziller
31312dc23e Examples: Re-add categories for sorting
that got accidentally lost while merging 11.0
because the code moved

Change-Id: I786d89f0909ccf5f3159a734b1d10d78e96904c5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-07-20 12:35:32 +00:00
Eike Ziller
9dbd129ab6 Merge remote-tracking branch 'origin/11.0'
Change-Id: I39643590e2753a1079980e5f9fbcbc33318aa0a5
2023-07-20 13:17:09 +02:00
Henning Gruendl
bb635325e7 ADS: Integrate newest base repository commits
* Add drag and drop to auto hide

Base repository was merged until commit
65600a4dcd072fd2773b661823816db6392c34eb

Change-Id: I09dd6613869368d3cf0c701055a6972db915561d
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-07-20 11:00:54 +00:00
Henning Gruendl
16ef838f23 ADS: Integrate newest base repository commits
* Update to newest version of ADS
* Remove native window and title bar support on linux

Base repository was merged until commit
8d4507e9d83434be976ff8c7bc9f59733937a08d

Task-number: QDS-10242
Change-Id: If74b6b50421be3b759c61b0f76f4a330991f71fa
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-07-20 11:00:24 +00:00
Jarek Kobus
e8669653f1 Icon: Pass const reference to QList in c'tor
Change-Id: I8e009cdd29d08fc0dbcac3c812885779c928337c
Reviewed-by: hjk <hjk@qt.io>
2023-07-20 10:51:44 +00:00
hjk
635e8c1614 Utils: Introduce a FilePathAspect::expandedValue()
Currently and long-term synonym for operator(), to be used in
cases where (*this)() or such looks ugly.

Change-Id: I3f70ecd3298a1df394a0e3cc593917b4c7d36d82
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-07-20 10:39:43 +00:00
hjk
e8de9d44c9 Qmake: Use aspects more directly in QmakeBuildConfiguration
Change-Id: Ida1f62939242944e25986b71183164cd15c8de94
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-07-20 10:36:38 +00:00
Marco Bubke
21983a8377 Utils: Fix SmallString::append(QStringView string)
It used the size of the destination string but it had to use the size of
the appended string to inquire the maximum required size.

Change-Id: I1c910abab0ac60ed5fec1b3dc3a358e438532281
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-07-20 10:30:25 +00:00
Jarek Kobus
6cc471f38d Utils: Replace QVector with QList
Make usages of QList consistent. In some cases the
declaration contained QVector arg, while the definition
had QList arg.

Remove some unneeded includes of QList.

Change-Id: I7c15b39f261cefdeec6aaaf506ff4cc981432855
Reviewed-by: hjk <hjk@qt.io>
2023-07-20 09:57:07 +00:00
hjk
52ba040e60 Utils: Emit TypedAspect::volatileValueChanged when it changes
Change-Id: I9a2cf591955332453e6ff9d99c5e18249510599a
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-07-20 09:40:42 +00:00
Marco Bubke
601308edcd QmlDesigner: Remove misplaced EffectMaker
I could not find any qml module for effect maker. So it will break the
meta info system.

Change-Id: I7a9593a3033e51cb3a0cc922a6f913dfee63338d
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-07-20 09:39:14 +00:00
hjk
ddff28150d ClangTools: Convert two persisting values to aspects
Change-Id: Ida296c35f08951eaef698f53bceb705728f55aa9
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-07-20 09:31:59 +00:00
hjk
b14b7b1a5f Replace a few more Aspect::value() calls with operator() uses
Change-Id: I9343e74bfb51af41df02a411976b82b9260be2fb
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-07-20 09:31:09 +00:00
Leena Miettinen
6603c247d6 Doc: Fix reference to an image whose format changed to WEBP
Change-Id: I123af115096b17fdbe500af37f25704a45ad78a1
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-07-20 09:27:26 +00:00
hjk
7dfdb6d36c Android: Hide some manifesteditorwidget code in the .cpp
Change-Id: I4478cb2d85535c8d92aeef5e1e664e001d168ec5
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-07-20 09:09:38 +00:00
hjk
944a1e8a11 Android: Remove a few unnecessay Q_OBJECT
Change-Id: Ic57a7cfc58d741547cb793b24ff1358d900eaf5d
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-07-20 09:09:29 +00:00
Eike Ziller
3da1adc442 sdktool: Fix writing files
Fix an error when copying the file operations to sdktool.

resolveSymlinks was (basically) always returning an empty string.
Instead it should return the first file path that is not a symlink.

Amends bb4d9c92e7

Change-Id: Id6bfcc3332c14f074ab635e11ca0536b5326dbb1
Reviewed-by: hjk <hjk@qt.io>
2023-07-20 08:34:06 +00:00
Jarek Kobus
9f3e0db3e4 Unarchiver: Replace QVector with QList
Change-Id: Ib8a954f1b29ee475b645191424eb0e391dbb6baf
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-07-20 07:14:48 +00:00
Jarek Kobus
6bb8bbabd2 Utils: Rename archive.{cpp, h} -> unarchiver.{cpp, h}
Change-Id: I0c3fdb68a15a6ad7419405d2bef86d4e75537df5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-07-20 07:14:43 +00:00
Jarek Kobus
694c29d67b Utils: Get rid of Archive
Use Unarchiver instead.

Change-Id: I7544b36ca11578d7ae7eb8571e6fe823cf74dee1
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
2023-07-20 07:13:42 +00:00
Jarek Kobus
cd8bb1d923 ExampleCheckout: Replace the usage of Archive with Unarchiver
Change-Id: I76550b618bcc631fc9575343eb4b8552cb21a018
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
2023-07-20 07:13:28 +00:00
Eike Ziller
626378de2d Merge remote-tracking branch 'origin/11.0'
Conflicts:
	src/plugins/cmakeprojectmanager/cmakebuildstep.cpp
	src/plugins/qtsupport/examplesparser.cpp

Change-Id: I2a0808261969e8c7cef7fae86d9027a155bf9b14
2023-07-19 16:10:37 +02:00
hjk
f10d0bad01 TextEditor: Push back explicit use of core settings
It's meant to be handled via aspects in the long term.

Change-Id: I2a2792f7bb5e75ede18e2328bb31729c212e30e6
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-07-19 14:00:39 +00:00
hjk
74ff10001a Squish: Set only category icon path in settings page
... instead of icon directly.

Change-Id: Ie16cb23323bd2ef90b5169ecc0bd8f4fb6d406f0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-07-19 14:00:30 +00:00
hjk
2b7e8599c8 CppCheck: Move widget creation for manual run closer to its use
Change-Id: I08d50f5e4534b8a58d374ae37bfd03dbd234a483
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-07-19 14:00:17 +00:00
Marco Bubke
e204af5cac QmlDesigner: Modernize Enumeration
Save some allocations and return a view instead of a new value. If you
want a value because you depend on a null terminated string you have to
use toScope() and toName().

Task-number: QDS-10290
Change-Id: Ia87b8d559fc1fe9bb1992e61da0aa86c68d53535
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-07-19 13:16:44 +00:00
Marco Bubke
194b7d49b0 StudioWelcome: Fix more warnings
Change-Id: I1c1fa8fdfd33b50d47afe4eab82347cf3c0eff08
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-07-19 12:16:53 +00:00
hjk
d7461a380b Squish: Use new settings scheme
Change-Id: I262342c2797a03a774c89f7b7caae3f9d8c79a6c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-07-19 08:25:36 +00:00
hjk
e157ac82a1 Debugger: Paddle back on multiple inheritance for settings
This is fairly close to the new "standard" pattern for an
individual page but still allows flat access using the same
'settings().' stanza.

Change-Id: I1edbbd64a857a3d3936fb2c21fdc7e3c8ae7a44c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-07-19 06:39:56 +00:00
hjk
2a31f17354 Utils: Use handleGuiChanged more consistently in aspect implementations
Change-Id: I53eb3416b27dca45bd30860f1fb0ec674c98240e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-07-19 05:16:32 +00:00
hjk
c7cf450bd8 VcsBase: Remove almost unused access to VcssBaseClientImpl::settings()
Change-Id: I090714e9724dcc00b37651bb1310d7848066e03e
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-07-19 05:14:27 +00:00
hjk
bedab22e63 Replace a few aspect.value() calls with operatpor()
Change-Id: Icaada671fe8dbe59d4f596da49476b3ec2137c25
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-07-19 05:14:13 +00:00
hjk
3e2e0d9393 Meson: Delay settings creation
Change-Id: Ib4de981670c9f70e5ddd4c6e0b31bfd4b6a61851
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-07-19 05:14:01 +00:00
Jarek Kobus
481d301c5c GitPlugin: Replace QVector with QList
Change-Id: I20218a5fcd9b4af6e6633de55d41d4ba771bcd75
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-07-18 20:48:28 +00:00
Jarek Kobus
171675099c DiffEditor: Replace QVector with QList
Change-Id: I79246cc79a2cdcd6150b060386b34ce2f9923456
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-07-18 20:48:22 +00:00
Burak Hancerli
98c32d2043 QmlDesigner: Soften asserts on invalid URLs
Change-Id: I45ff2b98c45c1c39c1fbd28e89ddc15bde1adb93
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-07-18 19:44:17 +00:00
Marco Bubke
fa28c29781 QmlDesigner: Optimize ModelNode a little bit
The functions are doing not much but are called often. So they are a
good case for inlining.

Change-Id: I755c63287d7d518b55d4f131077b98dd0345930c
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-07-18 15:11:13 +00:00
Ali Kianian
6f78cd1a3c QmlDesigner: Select the correct text editor for paste action
The text editor was declared changed even in non-design mode. Now it's
notified only when the design mode is selected.

Task-number: QDS-9953
Change-Id: I64d0d7c1eec0e56d00f91e9522325ecb8660cd2d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-07-18 14:33:28 +00:00
Christian Stenger
ab70a04461 VcsBase: Fix missing include
Change-Id: I99cf36c0d1b4b91d828c241c6cad56bdc94e56f7
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-07-18 13:52:18 +00:00
Ali Kianian
a34b991448 QmlDesigner: Cleanup designer plugin for show/hide designer methods
Change-Id: I824ced5f1bf921d7336b3c4fe86ac37060129cd3
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2023-07-18 13:47:23 +00:00
hjk
a0a461668c Vcs: Distribute readSettings() calls to individual settings
Isn't a benefit here, but what the other settings do, so it's easier
to ponder more centralized solutions later.

Change-Id: I3837e5bedc8771dd56b8bacda8c23e40281b4fe3
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-07-18 12:15:28 +00:00
hjk
9a69c78ca5 Vcs: Convert settings pages to latest style
Last change in that area for this year.

Change-Id: Ibae9f1869cb20faf85c0c1669b84751ad022b8fd
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-07-18 12:15:07 +00:00
hjk
89a64a19e8 VcsBase: Contruct CommonSettings on first access
Change-Id: Ifa425e2f1952017769accd855e33d1fa53b7b6c9
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-07-18 12:12:37 +00:00
Jarek Kobus
1042323e8c RunControl: Check autoDelete state on finish
Amends a5ecc6207b

Change-Id: I0a762fb41e00416f295f9d71cc23091799359f07
Reviewed-by: hjk <hjk@qt.io>
2023-07-18 11:52:27 +00:00
Christian Stenger
9338f7a4d7 Utils: Fix visibility handling for aspects
Otherwise we may fail to hide widgets of aspects that are explicitly
set invisible while construction.

Change-Id: I2679c8fa22e79e4eb32ca5ae4266010d8cf9387d
Reviewed-by: hjk <hjk@qt.io>
2023-07-18 11:45:43 +00:00
hjk
814fabfe4b CppCheck: Rename options to settings
That's the by far more common name nowadays.

Change-Id: Iae987221f9fa2e955fdee21496f895d25d44be4e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-07-18 11:43:41 +00:00
hjk
b779223bb3 Nim: Remove Q_OBJECT from NimCompletionAssistProcessor
Not really used.

Change-Id: Ide97d5d60fcf3b4e6efa93a089028d8293b02dde
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-07-18 11:25:37 +00:00
Jarek Kobus
ee3658904a FileExtractor: Replace the usage of Archive with Unarchiver
Keep a pointer to the unarchiver inside the FileExtractor
in order to not to leak it on FileExtractor destruction.

Change-Id: I517bfb5997612db36e7ca8e61709b022caf5dc09
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
2023-07-18 10:34:18 +00:00
hjk
0db2beeff9 Cmake: Make line edit in formatter settings editable again
... and improve layout a bit

Change-Id: Ib1f7626259ca59190804faab5e2f453e8520de58
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-07-18 09:07:39 +00:00