Commit Graph

68765 Commits

Author SHA1 Message Date
Jarek Kobus
799dd9d101 AbstractProcessStep: Introduce defaultProcessTask()
Task-number: QTCREATORBUG-29168
Change-Id: Ic10a2edefd1a2ce1ffffd0eb051a720d9462e099
Reviewed-by: hjk <hjk@qt.io>
2023-07-13 07:42:00 +00:00
Jarek Kobus
d42e1756ef AbstractProcessStep: Make isExecutableFile check a part of setupProcess
Task-number: QTCREATORBUG-29168
Change-Id: I47cc43f1465528354802fdc033fc6369e413b526
Reviewed-by: hjk <hjk@qt.io>
2023-07-13 07:41:50 +00:00
Jarek Kobus
5385f84d55 AbstractProcessStep: Make checkWorkingDirectory a part of setupProcess
Task-number: QTCREATORBUG-29168
Change-Id: I5cfedc83a3817c64c67c9797c831084c26f1cab9
Reviewed-by: hjk <hjk@qt.io>
2023-07-13 07:24:54 +00:00
hjk
ec92d47103 Meson: Inline MesonBuildSystem::init() into ctor
Change-Id: I94c33f824dcbdf97562ecf1353fb83dcf726f040
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-07-13 07:19:10 +00:00
Christian Kandeler
fdc834c0d1 CPlusPlus: Remove TranslationUnit::getTokenStartPosition()
It was exactly the same as getTokenPosition().

Change-Id: I292522faa18933ec400b556c384786eb9efdfb3a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-07-13 07:16:29 +00:00
Jarek Kobus
3093142a70 AbstractProcessStep: Pass reference to the setupProcess()
Conform to the handleProcessDone() and the task tree interface.

Task-number: QTCREATORBUG-29168
Change-Id: I25394a877a86434ea5ac26cd85fe50640e55db11
Reviewed-by: hjk <hjk@qt.io>
2023-07-13 07:14:23 +00:00
hjk
f489a3e4d5 Meson: Inline mesonbuildsettingswidget file pair into buildconfiguration
Less code, leaner header.

Change-Id: Ibc018a60434f5dfeb67a7a77192c30e4cefeea96
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-07-13 07:11:26 +00:00
Jarek Kobus
b37b94f0e5 AbstractProcessStep: De-virtualize finish() method
Provide a setDoneHook() setter instead. The hook is
introduced temporarily, as when all the subclasses
are transformed to use the task tree, the done hook
is going to be a part of the subclass' recipe.

Task-number: QTCREATORBUG-29168
Change-Id: Idbc0f8b8a32c8df2fa5ecb73ed1cbaedad99620d
Reviewed-by: hjk <hjk@qt.io>
2023-07-13 06:50:07 +00:00
hjk
66ecfb15d1 Ios: Use aspects more directly in build configurations
Change-Id: I1fa9583fccd5bb6a93fcfea9e3977f626b790afb
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-07-13 06:42:09 +00:00
Jarek Kobus
dff33fa84b AbstractProcessStep: Simplify process done handling
Change-Id: If520052b364789cb830b41a83e9ff3b86082a1e3
Reviewed-by: hjk <hjk@qt.io>
2023-07-13 06:37:47 +00:00
hjk
69008e390c CMakeProjectManager: Use aspect more directly in CMakeInstallStep
Change-Id: Ibdd1fea42b93282b387693ea3d8cb155deeaed8a
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-07-13 06:37:32 +00:00
hjk
d69302ad61 Nim: Use aspect more directly in NimCompilerCleanStep
Change-Id: I8433dfa96c65ea3e1f7e9b0daef2e64e6cc65684
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-07-13 06:29:03 +00:00
Eike Ziller
835201060d Merge remote-tracking branch 'origin/11.0'
Change-Id: I2e0e8dd5f9b42533c665255f8539e837938846de
2023-07-13 08:28:42 +02:00
hjk
a7ad779525 RemoteLinux: Use aspects more directly in MakeInstallStep
Change-Id: I0586f24154a42033e4c6c1a1ac6274e348447e2a
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-07-13 06:28:28 +00:00
Eike Ziller
77c7e26779 Tasks: Show tool tips with information about the categories
When hovering an entry in the filter menu in the Issues view.
Also remove some categories that shouldn't be there.

Change-Id: Ifb367d69b9396c2fdc45b83ec5ffd88ac2f0eda7
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-07-13 06:09:27 +00:00
hjk
f16f09c390 ProjectExplorer: Use aspects more directly in customexe runconfig
Change-Id: I0c68c3a3b5fcaa0b25f12b9feed5023400e0bd00
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-07-13 04:55:59 +00:00
hjk
f31007f40a Meson: Remove unnecessary MesonBuildSystem::kits
Base is good enough.

Change-Id: I3f9f1007336b8ae9a03c8e75da64a8eb5b73a8af
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-07-12 15:39:16 +00:00
hjk
38c3abb774 Meson: Move MachineFileManager near build system
Closely related

Change-Id: Id561dccd909bb4dc53e1a55d6ee77d008e5c4078
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-07-12 15:38:33 +00:00
Jarek Kobus
ae01e13d32 AbstractProcessStep: Move process done handler from QMakeStep
The done handler is going to be used for other processes, too.

Change-Id: I3c60ec75656aa45bd57ec3ca8336cf310c78bd3e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-07-12 14:57:34 +00:00
hjk
8ba6f11e9c Boot2Qt: Use aspects more directly in QdbRunConfiguration
Change-Id: I8a199f449824ff973f5278f39172307be0e11438
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-07-12 14:01:57 +00:00
Cristian Adam
ba755e50a3 Utils: Fix inverted logic for checkableDecider (continued)
Amends 6b6b1198dd

The commit above made sure that the display of the dialog was in sync
with the checkbox in the settings dialog.

Now also the "Do not show again" checkbox in the messagebox will be
reflected in the settings dialog.

Change-Id: Ieb186b134adac09c9846a64144056b3b89d297d8
Reviewed-by: hjk <hjk@qt.io>
2023-07-12 13:12:40 +00:00
hjk
323f29a3bd AutoTest: Merge settings and tools hierarchies [2/2]
Renaming files to match class names.

Change-Id: I3d75a79a5ad8e9d1c132530cbcc6973efc6dbadf
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-07-12 13:08:28 +00:00
hjk
0b83f110f4 CppEditor: Make a few CppModelManager functions static
... to simplify code using it.

Change-Id: Ib2bfbb5a17a1d48088a9cf4973d4c3f006cd34e4
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-07-12 13:08:09 +00:00
hjk
8f82e76ba1 ProjectExplorer: Centrally disable X11 forwarding aspect on windows
That's only the default value, but basically what all user code
occurrences do.

Change-Id: I2997744cf069455294ac35871109edc4328a1996
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-07-12 13:06:55 +00:00
hjk
90ba140545 CplusPlus: Use plainer callbacks to interact to the CppEditor
Lets us remove a few explicit CppModelManager::instance() call
in user code later.

Change-Id: Id8d846d06a0715b3d609cc5d52cc031e1d025fb1
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-07-12 13:00:48 +00:00
Christian Kandeler
1d59a37acb ClangCodeModel: Fix outdated message
... after applying a clangd warning suppression.

Change-Id: I6b6605edd80080dcfd070b4a2f4219463674421b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-07-12 12:57:06 +00:00
hjk
14e18fc92f AutoTest: Merge settings and tools hierarchies [1/2]
Currently living in the settings files to keep changes small,
will be renamed in a second step.

This allows the settings aspects to be used in their short form
and overall removes some indirections.

Change-Id: I099369b62239aed8192613a04bca958a660c36c7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-07-12 12:12:17 +00:00
hjk
345c946255 ProjectExplorer: Use direct aspect registration in ProcessStep
Task-number: QTCREATORBUG-29168
Change-Id: If83acc092689a935cf81c8133d6a07d802a07177
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-07-12 11:42:34 +00:00
Ali Kianian
c3dee68573 QmlDesigner: Unmark the reflection flage for valid Qml property changes
The reflection flag is unmarked for valid Qml property changes in order
to be updated in the puppet side.

Task-number: QDS-9881
Change-Id: Ibd36fb1ee844f08efa256d28514a3f0debd467e2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-07-12 09:49:18 +00:00
Eike Ziller
9e8bdc9836 Fix order of session vs recent files/projects menu
Got mixed up when moving the session manager to Core

Change-Id: I729dd505c0b58bbbe46ddee423c76ab21c6f1b25
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-07-12 08:59:09 +00:00
Alessandro Portale
f3654b8fd2 Autotest: Use LayoutBuilder in ProjectTestSettingsWidget
Change-Id: If9f67564323835334e123178806467a999ab73a1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-07-12 07:44:14 +00:00
Marco Bubke
fb9a7e2d3a QmlDesigner: Fix missing project storage include
Change-Id: Ifb7439e5998ef8d9fb89f3d21a20ed49c46cbe35
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2023-07-12 07:23:58 +00:00
Marco Bubke
e7a7914aa8 QmlDesigner: Fix skip auto moc
Actually the syntax was wrong.

You can use

SKIP_AUTOMOC foo.cpp

or

PROPERTIES SKIP_AUTOMOC ON

SKIP_AUTOGEN is skipping AUTOUIC and AUTORCC too.

Change-Id: Id4afdc2572fc287ae66368ba0fd70b3ce7fc04ba
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Burak Hancerli <burak.hancerli@qt.io>
2023-07-12 07:15:50 +00:00
Marco Bubke
98cff9e097 QmlDesigner: More test for NodeMetaInfo
Task-number: QDS-10055
Change-Id: I23a9d7ea87dff9f3e07f5beeb734cea7d01d2e94
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-07-12 07:13:39 +00:00
Eike Ziller
9144706000 Make showing tool tips for menu items more widely available
Change-Id: Ic9fcb61917c955a2b114c3a355dbdf5c291d75f3
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-07-12 06:34:51 +00:00
Eike Ziller
5b79efd0d6 Tasks: Save TaskCategory objects in the model
So data can be accessed more directly, instead of going through
individual methods categoryIds and categoryDisplayName.

Change-Id: Idb36050762e507480ba69de6a32b5f6f9bec8b75
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-07-12 06:34:40 +00:00
Eike Ziller
cd1b6a669b Tasks: Create a container class for category data
Reduce the number of arguments that need to be passed around.

Change-Id: I9fbfdcdf7b20f8f26e35f435bf8d65ba483e4114
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-07-12 06:34:25 +00:00
Alessandro Portale
918978ce89 Android: Remove unused androiderrormessage.h/.cpp
These have been added 10 Years ago with the plan to use them soon after,
but that did not happen.

Amends: db78293e7f

Change-Id: Ic916eafba56cbb5e4d1dadfb63222fa2870fbd2c
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2023-07-11 19:15:12 +00:00
Marco Bubke
8ab4968278 QmlDesigner: Introduce origin flags
metaInfo.isProjectComponent() is signaling if a file component is
directly part of the project. metaInfo.isInProjectModule() otherwise
shows if a type is inside of the project as a qmldir module. Both cannot
be true. If a type is not part of either it is a system type.

Task-number: QDS-10251
Change-Id: Iae2270827a500ad6393e3751b3af276f9b030679
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-07-11 15:42:48 +00:00
Marco Bubke
e1171359ab QmlDesigner: Disable auto moc for non-qobjects
Change-Id: Ibca60ac262a4d43f8963b23ab6c2de5fa0098b27
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-07-11 15:42:41 +00:00
Marco Bubke
a3f990d713 QmlDesigner: Add type lookup
Task-number: QDS-10246
Change-Id: I607f72e29734a3c59b7b5b33d96735d708cd18ec
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-07-11 15:42:06 +00:00
Eike Ziller
409591e6f9 MCU: Fix missing files in list of project files
MCU projects contain subnodes for the contents of QmlProject files, which
get populated after the project tree was already added to the tree.

To make sure that the added files are also listed in
`Project::files(...)`, and therefore be considered for e.g. Locator and
project searches, the code must trigger `Project::handleSubTreeChanged`,
so the cached list of nodes is updated. This doesn't happen with
`addNode` (which is for construction before the tree is added to the
`ProjectTree`), and forcing the `ProjectTree::emitSubtreeChanged` signal
is also not sufficient.

Use `FolderNode::replaceSubtree` which was made for this usecase and
triggers all the relevant code.

Fixes: QTCREATORBUG-29297
Change-Id: I3a1c4c1aebf978e2788de905231b83355db75030
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Yasser Grimes <yasser.grimes@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-07-11 14:03:00 +00:00
hjk
200ae0b40b Qnx: Use Aspects more directly in QnxRunConfiguration
Change-Id: I450144e91842792cc5841b2fb61e8fc39b0daa1e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-07-11 12:42:33 +00:00
hjk
cf7b2fb822 RemoteLinux: Add auto-registration ability to RemoteLinuxEnvironmentAspect
Change-Id: Ifec10445427c2f8125c29cdb4db44d45a99e6453
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-07-11 11:48:21 +00:00
Marcus Tillmanns
abf2234e4f Utils: Add ToolBar to layoutbuilder
Change-Id: I26ce85f73e625508d816c0e361a6afc65adf65ff
Reviewed-by: hjk <hjk@qt.io>
2023-07-11 11:37:23 +00:00
Christian Stenger
b5fa6be362 AutoTest: Retrigger scan if active frameworks change
...if the code parser is scanning for tests.
Otherwise we have the canceled state of the running scan.

Change-Id: Ief493c0bf66825e57c44c79193d5e8085ee98acd
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-07-11 11:10:52 +00:00
Christian Stenger
4f50b6b791 AutoTest: Postpone removal of root node
If a root node should get removed while scanning we may end up
crashing when still getting results.
As there is currently no mechanism to stop a certain parser
postpone the removal of the root node until the parsing is done.

Change-Id: I3766f9e67780e241801166339fa67f39536314b4
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-07-11 11:10:40 +00:00
Cristian Adam
c914e5f9c2 Wininterrupt: Add explicit stdlib.h include statement
strtoul is found in stdlib.h and with the llvm-mingw toolchain it
fails to compile due to the stdlib.h header not being indirectly
included.

Change-Id: I85fc5e5828c859572ff1ce2c050556bc087de277
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-07-11 10:35:50 +00:00
Ali Kianian
f7a7f55df5 QmlDesigner: Handle placeholder color for navigator line edit
Task-number: QDS-10099
Change-Id: Ieede8ffc7ef6251c32cd78f7a90fb6f56f3c0824
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-07-11 10:15:13 +00:00
hjk
ed93cff3ba ProjectExplorer: Allow to specific target device for EnvironmentAspects
Similar to what is done for ExecutableAspect.

The device related part is here not used yet, as only run related
setups are affected. This might change with an attempt to unify
EnvironmentAspect and RemoteLinuxEnvironmentAspect.

Change-Id: I6a620ad1d3443f0e8201c2572689edda1f84593c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-07-11 09:40:27 +00:00