Mostly namespaces, but also centralize access to the factory list
for better debugging.
Change-Id: Ic8b19b8c110dc925e0f7ae27af1da2b9e1ec6086
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
None of this had any affect after switching to clangd.
Change-Id: I806682fecff84bf6eb0b0eb382e096fc9a25fa3d
Reviewed-by: David Schulz <david.schulz@qt.io>
Silences a soft assert and re-allows to type paths
containing more than one directory separator.
Change-Id: I36c400e32b39206669278b89ab4bb033a1f0b6f6
Reviewed-by: hjk <hjk@qt.io>
Does not delay much yet, as settings() is accessed in
Plugin::extensionInitialized()
Task-number: QTCREATORBUG-29167
Change-Id: I8f7c7fbef78c4ce0f92302e57a81f6216456c27b
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
This should not happen, but when it happens, the resulting crash is
quite cryptic. Make it a bit more obvious.
Change-Id: Icbe40206cfdbae93ccb072d7027fcaf109f2f39f
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
This change contains various adjustments to the line column label:
- Display the number of selected characters
- Show the number of cursors instead of the position when multiple text
cursors are present in the current editor
- show detailed information for each cursor in the line column tooltip
Fixes: QTCREATORBUG-29381
Change-Id: Ib4f36b290797f1d84f268deeb9556e78ae921c37
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
... from StringAspect to FilePathAspect.
Task-number: QTCREATORBUG-29167
Change-Id: I6fc3bc22f905825443ebc31ebe44e7c27fdbcb56
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
This is still disabled by default until the UI gets polished.
Add roles to models. ConnectionModel, BindingModel and DynamicPropertiesModel.
In QML roles are used in the ListView to "mimic" columns. The columns are only
relevant for the "old" cpp QTableView and can be removed.
Making currentIndex part of the model. If rows are removed and added
again we have to "reset/keep" the currentIndex as part of the model, because
the index is temporarly invalid on the view.
Implementing DynamicPropertiesModelBackendDelegate as reference.
This is a pure "backend delegate" that exposes all relevant properties for
a current row to QML.
Adding StudioQuickWidget and exposing the backend.
Adding StudioQmlTextBackend and StudioQmlComboBoxBackend to
StudioQuickWidget (should be moved into their own files).
Those helper classes make is easy to expose a property to a combobox or
textfield. The backend has to know nothing about the actual frontend
and those classes act as a mini-model for a view in QML.
The API is similar to UI controls.
Change-Id: I7a2c6ad951306fbca1d586fb8f278acdd91a064b
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Knud Dollereder <knud.dollereder@qt.io>
Generally, aspects should use fromMap/toMap, but some older pages
use {from,to}Settings with always the same ICore::settings().
To make that less intrusive on the user code side, make that globally
implicit.
Task-number: QTCREATORBUG-29167
Change-Id: I29a8e23a31eb8061bb143e93931a07c6741eb7f9
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Apparently, it was mistakenly assumed that a non-zero lexer state
implies that the comment continues on the next line when it can also
mean that the line ends in a backslash. Adapt the check accordingly.
Fixes: QTCREATORBUG-29339
Change-Id: Ib239aca86dae9983d920f7715ae628ab4bf80220
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This functionality was never properly converted when we switched to
clangd.
Fixes: QTCREATORBUG-29385
Change-Id: Ie06c9ec8bbed6a539ce9f9bf5ba512ae1a7f4b98
Reviewed-by: David Schulz <david.schulz@qt.io>
In the code below min can be bigger than max.
qBound(widget->rect().height(), bounded.y(), parent->height())
Change-Id: Ia65b1ba5917bf3333606e16263ac30819a07a587
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Broke with the removal of the special BoolAspect-in-FormLayout handling
in the latest aspect revamp.
Change-Id: I61465b0a3318192ff8b7c92ebf45491c4b298b6c
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
When starting a Terminal Process with TerminalMode::Detached,
the Process object was not deleted on app exit and therefor
created warnings on exit.
This patch changes it so that the osascript does not wait for the
process to exit and therefor exits pretty much immediately which
deletes the Process object.
Fixes: QTCREATORBUG-29375
Change-Id: I08e8b753c98011fdafc32f03886b5c0be7aec801
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
... and expose that instead of the PythonRunConfiguration.
This makes the PythonRunConfiguration more the container of aspects,
similar to where the other runconfigs move.
Change-Id: Ibc76b706f2d4d334640ea8f3b91343f9e7c0f566
Reviewed-by: David Schulz <david.schulz@qt.io>
The FileFindParameters::additionalParameters,
holding QVariant, was ambiguous. Since GitGrep and
SilverSearcher need a search directory input
unconditionally, replace the additionalParameters field
with searchDir of FilePath type. For Internal
search engine, this field isn't used - the searchDir
is already passed in FindInFiles::fileContainerProvider()
with lambda capture; for other BaseFileFind subclasses,
not combined with non-Internal search engine, the field
isn't used anyway.
This change closes the chain of patches to eliminate
the usage of ambiguous QVariant type inside FileFindParameters.
Change-Id: Icddd1cfe46e86ea892221862d9d267f9c9fa173c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Get rid of ambiguous searchEngineParameters QVariant.
Pass the custom parameters through the lambda captures
of the SearchEngine::searchExecutor() overloads.
Change-Id: I971a3871199a17200ec662392dfd7095a7a56a50
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Provide the contents of the "usage" file for copy & pasting into
CMakeLists.txt. If the "usage" file is not available, provide the same
heuristic code that vcpkg generates.
Task-number: QTCREATORBUG-29333
Change-Id: I3daba7616451a43f93fd8f2e0353542ec5a2c48b
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
