Make it possible to use the default Task c'tor
and add selected handlers with onSetup/Done/Error()
methods.
Change-Id: I94f5806f347931faa07cff0ade620a3d30777cfe
Reviewed-by: hjk <hjk@qt.io>
Add JavaScriptRequest class that runs evaluation
for a given input data and for a given JavaScriptEngine.
The JavaScriptFilter holds the running JavaScriptEngine
instance.
Features:
- It creates, destroys and runs evaluation of QJSEngine
always in one, separate thread.
- In case of a busy run of evaluator (e.g. because
an input data contains a script with an endless loop)
it's possible now to cancel the task before the timeout
came. Useful when typing fast inside locator widget.
Add also the JavaScriptRequestTask to be included in
TaskTree.
Change-Id: I866069c72bad17ab899f4aca9a3f6d928738f3a3
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
A freshly started Qt Creator showed a smaller target chooser button
until a project was loaded. When loading a new project, the button
changed its height which caused a noticeable jumping of the layout in the FancyActionBar. After closing the project the higher height
remained.
This change has the effect that the button has the final height right
from the start of Qt Creator and that the jumping disappears.
Change-Id: I6c9ac57c661398ba03d0b31269f62db28672ec91
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Lookup any variables found in the target definition function in order to
find the source files.
This works for something like this:
set(SOURCE_FILES myfile.cpp)
add_executable(myexe ${SOURCE_FILES})
Change-Id: I8a47ea64b4efa467074f03ed5e1d1d05b2b1bf00
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
This reverts commit ca04d9afcd.
GCC 9 or later is the minimum required version nowadays, so this piece
of code can be more readable.
Change-Id: I939ee6cd62572d23d5b1de8d113472136752a590
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Large projects can have thousands of subdirectories, only a tiny subset
of which are supposed to be include directories. Use the directory name
as a heuristic instead.
Fixes: QTCREATORBUG-29099
Change-Id: I207ea2b7d2739c4f6c27fa96865dfde2570caf8a
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
We should only care about the file name. If the file's directory
contains "clang", the compiler is not necessarily clang.
Reported by hjk.
Change-Id: I079c59eca37a9dbaa2ef5d669aee8e185db528f9
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
"Welcome_ForegroundSecondaryColor" is less likely to burn a permanent,
straight line into user's retina.
Change-Id: Ie6c6f02d8b53c340b322945f0d735177f22ddd56
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
It is required for updating currently visible proposals. Also guard
against potential null assist interfaces.
Amends 0bd6d7a69f
Fixes: QTCREATORBUG-29096
Change-Id: Ic34d70561b471e7e529f2fb7c239b49712aca502
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Since this was in another repository, had to put it separately
as update. This would let the Component 3D to have tooltip in the
3D components space.
Fixes: QDS-9757
Change-Id: I91bbfbcd54776774989a12d4bbefe8c8deb93ab1
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
It may happen that still running LocatorMatcher is destructed
from the LocatorWidget destructor (i.e. from CorePlugin d'tor).
In this case the global future synchronizer is already reset,
so the d'tor of ResultsCollector can't put running deduplicator
task into the global synchronizer.
Check this case and place the deduplicator task into the global
future synchronizer only when it still exists. Otherwise, blocking
wait for the deduplicator to finish.
Change-Id: Ie788db923808dd91bdfdc4f1f53d336baf7c672a
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
fakevimhandler.{h,cpp} are meant to be re-usable outside of Qt Creator.
Amends 91605c3.
Change-Id: I569a393d13049ef92ed3ef0c4f69de5232b2fa32
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
layoutbuilder.{cpp,h} can now be re-used outside Creator
Change-Id: I306d2d8168d8a09658ea008f4606ca37a0dbbc01
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Adapt the TaskTree tests and the usage in FileStreamer.
The FileStreamer may be tested by running the
FileSystemAccessTest.
Change-Id: I1d8086dd359c458b7bdd3d4d47cf249184b04c65
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
* Changed signals to callbacks as only one receiver was ever added
* Added "tabPressedInInsertMode" callback to allow accepting
a suggestion with the Tab Key
Fixes: QTCREATORBUG-28830
Change-Id: Ie70ba595b8802b6100fff495164d8e0471b1354c
Reviewed-by: hjk <hjk@qt.io>
Block suggestions when FakeVim is enabled and the mode
is not "Insert" or "Replace".
Change-Id: I778eb25d9570b76e42652f9d938a8c580033c462
Reviewed-by: David Schulz <david.schulz@qt.io>
This primitive is going to replace the TaskTree's built-in
mechanism consisting of Wait, Condition and ConditionActivator
elements.
When combining 2 barriers, one placed in a custom storage,
and the other in a tree, it's possible to fully substitute
the Wait, Condition and ConditionActivator with the comparable
amount of code.
However, the Barrier is much more versatile, since it
makes it possible to:
1. distribute the decision about the ultimate barrier pass on the
whole tree.
In order to utilize it, increase the limit of the shared barrier
with setLimit() to the expected number of places that participate
in the decision about the ultimate barrier pass and use advance()
from multiple places in the tree. When the number of calls
to advance() reaches the limit(), the shared barrier passes
automatically.
Whenever some participant failed, so that the shared barrier
can not be passed, it may call stopWithResult(false).
Whenever some other participant decided that all the needed
data are already collected, so that the barrier may pass early,
it may call stopWithResult(true), making the remaining calls to
advance no-op.
2. wait for the same barrier from multiple places.
Before, only one WaitFor was possible for a single Condition.
3. insert multiple Barriers into one Group element.
Before, only one WaitFor could be placed in a single Group.
Provide ready-made SingleCondition and waitFor() helpers.
With the new approach, the following equivalents are provided:
- SingleBarrier (substitutes old Condition)
- WaitForBarrier() (substitutes old WaitFor)
- Barrier (substitutes old ConditionActivator)
This change replaces the mechanism introduced in
29f634a8ca.
This change conforms to the naming scheme proposed in QTCREATORBUG-29102.
Task-number: QTCREATORBUG-29102
Change-Id: I48b3e2ee723c3b9fe73a59a25eb7facc72940c3b
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
It's a common mistake to forget to insert the Storage
element into the tree, but reuse it from inside running
handlers.
This message should help in quick fixing the issue.
Change-Id: I771e89b06943667b56188d0655ec3da1b48f8a34
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Remove the redundant initialization of navigation views.
Change-Id: I26d0c199cfc8be11b364763c0dba37e41dedc64e
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Remove the workaround that always opens the Application Output when
the Output Pane view opens. This is no longer needed as the last used
output pane index is stored in the settings and used whenever the
output pane is opened the first time.
Change-Id: Ifbe6c60b5331489faff4bb0bce30c3f6fef8fba6
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Fix the title of the initially selected pane in the output pane
placeholder toolbar not being set by the output pane manager.
Change-Id: I94407c76454a632a9b5707edcbde0ce6dc990d61
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
- Fix views, workspaces and output menus being enabled in welcome mode
- Use mode instead of context change to enable/disable menus
Change-Id: I68053112d66e100e3bf3b07368310a3c3c50999d
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Add a setting to store the previously used output pane index to be able
to restore it on startup.
Task-number: QDS-9647
Change-Id: I2ef277e8d4c79a6d0b017e5422ad639b56b2140b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Don't leave the partially updated cache when the generate()
method was canceled. Before, it was possible that only
m_filePaths were updated, without updating m_lastInput and
m_cache, what could leave the cache in inconsistent state.
Remove unneeded namespace qualifier.
Some doc fixes.
Amends 19918129bf
Change-Id: Icef6389f45f0699d851ce412f134c93353728338
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This test corresponds to the old test for BaseFileFilter.
Change-Id: If1e775f0f8490943ff41fb6a7ccc4069914fe1f2
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
We have to if the project actually has a QmlBuildSystem.
Task-number: QDS-9804
Change-Id: I1740f1c0772641888a8828b10380f442308bfe46
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
It's going to be used as a BaseFileFilter replacement.
Add docs for it.
Change-Id: I20a52d948373238b07db6cbe1bbadf8c648ae3bf
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
