Commit Graph

82157 Commits

Author SHA1 Message Date
Mahmoud Badri
ffe3670d90 QmlDesigner: Implement changing effect maker preview image
Fixes: QDS-10625
Change-Id: I48ef68fd4b64a37de3dc60f5decfcda1b43496dc
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Amr Elsayed <amr.elsayed@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-19 14:17:12 +00:00
Henning Gruendl
da92e16a92 QmlDesigner: Add tooltip on elided pills
Change-Id: I4a40070b958a46e46009ba8f141fd5c286858ab7
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-19 12:43:34 +00:00
Brook Cronin
37c4937d6d QmlDesigner: Add new icons
* Add new icons
* Change position code editor button
* Add eliding to the code preview

Change-Id: Ib47b0e28ae9b4deebc7bace942f43d8249f46299
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-19 12:43:04 +00:00
Thomas Hartmann
0ef6c184c1 QmlProject: Add new options to cmakefiles.txt template
If the template was regernated (which is not the default), it
was missing features.

Change-Id: I446dd454127795e0e7edcb6669dc7025ce37be01
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-19 12:26:30 +00:00
Thomas Hartmann
096c825084 QmlJSCheck: Do not warn about visual properties in Connections
Change-Id: I1b8d9374021d337d87025290fd025dd600fc3967
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-09-19 12:25:44 +00:00
Thomas Hartmann
e156854fc3 QmlDesigner: One more missing qualification
Change-Id: I394e58b2cccdfbfcacd13ff2c5cefba8d4719ef4
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-19 12:24:47 +00:00
Brook Cronin
f5e01b8b09 QmlDesigner: Fix Pill eliding logic
Change-Id: I573251001b2e77ff3f3fb0046615d65de814c21d
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-19 11:25:10 +00:00
Miikka Heikkinen
5d7808f95b QmlDesigner: Don't show context on 2D view when editing 3D component
Fixes: QDS-10664
Change-Id: Ia4436b942ce79e0abe622adbba914903ab6a72bc
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-19 10:31:59 +00:00
Thomas Hartmann
f227dbf041 QmlDesigner: Fix appearance main toolbar
Using _q_custom_style_disabled had slight unwanted impact on appearance.
Introducing _q_custom_style_skipolish instead in studio style.
Using studio style whenever we are Qt Design Studio for all themes.

Change-Id: Iee460cfc0a62122b1aeb6d97746808658c4f3ebf
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-09-19 10:31:52 +00:00
Henning Gruendl
560b77d64b QmlDesigner: Fix Connections in ConnectionsEditor
Fix Implicitly defined onFoo properties in Connections are deprecated.

Change-Id: I0f2460dd4b69c070f4982ca0ec13b19cfda0342b
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-19 10:20:37 +00:00
Thomas Hartmann
94bd14eb46 QmlDesigner: Bump QDS version in template
Change-Id: If05eb88eabd59d0a63944887f896e32da2b9c202
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-19 09:03:17 +00:00
Thomas Hartmann
1b9ed62028 QmlDesigner: Close dialog if target is removed
If the target is removed also the connection is removed and
we close the dialog.

Change-Id: I361e89ef64484e39bc0068e103f542cbc9dcbf78
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Aleksei German <aleksei.german@qt.io>
2023-09-18 15:54:39 +00:00
Thomas Hartmann
ffa4aba2c8 QmlDesigner: Adjust priorities
Change-Id: I9e455b40eca108aee869a24606300f38d14b5326
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-18 15:53:03 +00:00
Thomas Hartmann
0547cff092 QmlDesigner: Update branch for designer components
Change-Id: I370fcd7eb15a26d28e60dc8bf2cdf24c29a43957
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-18 15:52:45 +00:00
Henning Gruendl
2a135f5d14 QmlDesigner: Fix long expression pill texts
* Elide static texts
* Clip dynamic texts

Change-Id: I90a511ec6dd35d2b65f4064bc09c0a83e8d1e905
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-18 15:43:02 +00:00
Thomas Hartmann
e0441a9aec QmlDesigner: Choose new target from filtered targets
Task-number: QDS-10137
Change-Id: Ic74262862996c73ab5119793b92575035d590f60
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-18 14:40:07 +00:00
Thomas Hartmann
5ff6fe0eba QmlDesigner: Add missing qualification
This was leading to random errors.

Change-Id: I51ec0c71ac1bd3ea7bd966eeb4d3a2b9cfeb0159
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-09-18 13:53:35 +00:00
Miikka Heikkinen
461340d245 QmlDesigner: Tie 3D helper grid to snap interval
Helper grid minimum step now changes to match set snap interval.

Fixes: QDS-10624
Change-Id: I82b8206774b3769bee19be5eb0f38930f3b49c12
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-09-18 13:52:55 +00:00
Amr Essam
7b183a774c QmlDesigner: Move effect maker to an independent plugin
Task-number: QDS-10656
Change-Id: I1c1e67d3461650bfaec46ccc10b832effce76ad9
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-09-18 13:23:06 +00:00
Miikka Heikkinen
a6e8a247b3 QmlDesigner: Fix minimum value for NumberAnimation to and from fields
Change-Id: Ic5fcb1d69ab0c3369dacbc93da71714b20253e25
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-18 13:03:43 +00:00
Thomas Hartmann
6dc4243995 QmlDesigner: Choose proper default signal
Change-Id: I2a9493d0cc2a49afd624d58b53df54686d827422
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-09-18 12:56:09 +00:00
Thomas Hartmann
c693bd06b3 QmlDesigner: Fix toolbar height for non QDS styles
Task-number: QDS-10687
Task-number: QDS-10596
Change-Id: Ia4a7e958c6719cafa3a3fe2fea588cbd20c5b703
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-09-18 12:47:16 +00:00
Aleksei German
106bb82d73 QmlDesigner: Remove Connections Editor action
Task-number: QDS-10606
Change-Id: I0b0d4364e6c80eddee3bb1d8b8491c8c00542593
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-18 12:42:51 +00:00
Aleksei German
4949c1911e QmlDesigner: Add code preview indentation
Task-number: QDS-10680
Change-Id: I61528f517ed4baef2115fbddf1b014b9f7f966d2
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-18 12:42:46 +00:00
Miikka Heikkinen
516a2238e2 QmlDesigner: Ensure we save the latest values on 3D snap dialog close
Track value property of spin boxes changes directly instead of the
extra valueModified signal, which is not emitted in all cases.

Also removed duplicate applying of snap configuration.

Fixes: QDS-10653
Change-Id: If0ce7bffa1dcfb5b01e80b6e962f356f91f44d51
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-09-18 10:09:31 +00:00
Miikka Heikkinen
1a88cf1446 QmlDesigner: Open 3D view toolbar popups to correct position
The button that is shown under extension menu is not actually the
same button widget that is tied to the action, so we need to resolve
the menu position based on toolbar dimensions in that case.

Fixes: QDS-10635
Change-Id: I0c2319041638f9f1cb19f3e57fccbb993e31c743
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-09-18 10:08:48 +00:00
Henning Gruendl
44699727ad QmlDesigner: Close dialog when view loses focus
Change-Id: Ib48229615ee9b2ccef1a8be98086a93851dae6af
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-18 09:58:43 +00:00
Henning Gruendl
f25ce01ead QmlDesigner: Close dialog when view loses focus
Change-Id: I4666953ff862886fbb02fb3982d6856a223fe969
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-15 19:50:41 +00:00
Brook Cronin
a496ac5d02 QmlDesigner: Design fixes for connections popout
Change-Id: I06968cfef23f8b296f1ba6b07e57cdc96701447b
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-09-15 17:21:33 +00:00
Henning Gruendl
5aa3e573ce QmlDesigner: Fix empty literal remove
Fix issue that literal token is not immediately when pressing backspace
and text is empty.

Change-Id: I7ba2401ad6adfa689f697188feb7b30a71d82eeb
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-15 16:58:01 +00:00
Henning Gruendl
9b2d6f5edd QmlDesigner: Fix Connections Popup layout
* Set proper width on labels
* Set proper width on StatementEditor
* Forward backend property into StatementEditor

Change-Id: Ia0db6ff7f235bd8d25eb0f36124fa158b76aaf04
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-15 16:57:51 +00:00
Henning Gruendl
55034b1cde QmlDesigner: Pill redesign
Change-Id: I3c28599c3cbc1555fbdb206e387dccf6f45a77cd
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-15 16:57:34 +00:00
Thomas Hartmann
fedb38a0f5 QmlDesigner: Priotize 3D related properties
Task-number: QDS-10682
Change-Id: Ib75877257ea34edfa539a198e56d9499810aca15
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-15 15:12:46 +00:00
Thomas Hartmann
1a1e898f0f QmlDesigner: Set Core::ICore::dialogParent() for QML windows
Change-Id: Ie09c7255495456cb76e94504392c9474e2a88688
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Aleksei German <aleksei.german@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-15 15:12:38 +00:00
Knud Dollereder
b18b7920bb Refuse to add properties from unselected nodes
... and select property after adding it to the model.

Change-Id: I4210e9b1e27b3d396ba5f421629a2b90d2771f50
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-15 13:23:02 +00:00
Thomas Hartmann
5ca59da1af McuSupport: Do not regularly restet code mode in QDS context
Resetting the code model on a regular base has quite a
negative performance impact and also generates unexpected
code paths and updates.

Change-Id: I5a62166d714beb6cc6c9a64333abf093a5a87ac6
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Yasser Grimes <yasser.grimes@qt.io>
2023-09-15 13:11:45 +00:00
Miikka Heikkinen
f3036d52e5 QmlDesigner: Fix dragging 3D snap configuration spinboxes
Changed to use HelperWidgets.DoubleSpinBox, which has the proper drag
support built into it and implemented required context functions.

Fixes: QDS-10639
Change-Id: I6fce39251d7f754985f95bba5784784fc6eb8fae
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-09-15 12:52:30 +00:00
Henning Gruendl
b73b94d27a QmlDesigner: Remove anchors from positioner child
Change-Id: Ibff848d5f80ac74491ab77e88baffb4d0e1454bf
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-15 12:48:05 +00:00
Henning Gruendl
954385c34d QmlDesigner: Fix wrong role name
Change-Id: I195ead9ade9c4bc430bdee630f533e6e04e15027
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-15 12:47:54 +00:00
Thomas Hartmann
b0a9481049 QmlDesigner: Remove qDebug from ConnectionView
Change-Id: I495525286ff96331ce560d468bf1445fcf7a061e
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-15 11:59:08 +00:00
Henning Gruendl
6d5ceadccf QmlDesigner: Improve type selection
* Disable custom item in Connection Editor type selection
* Rename Unknown to Custom

Change-Id: I9fa8c9ab6284503d5ccc61813454b9d10f291a06
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-15 11:33:49 +00:00
Henning Gruendl
5ed667c554 QmlDesigner: Add chevron to items with children
Add chevron to the ItemDelegates of the SuggestionPopup if items have
children. This indicates that the user can click on it and go deeper.

Change-Id: I905769b8190b81a92025861a3fc38817de5b56ed
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-15 11:33:41 +00:00
Thomas Hartmann
fc981ee54a QmlDesigner: Fix crash
Check for existing device.

Task-number: QDS-10137
Change-Id: I00065b63f09fb5691c52acaefd75fee0c4315d75
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-15 11:21:25 +00:00
Miikka Heikkinen
ac6d875d12 QmlDesigner: Display informative string for 3D support in Qt5 projects
Fixes: QDS-10661
Change-Id: I91ba32e478039711758e19c11d385af9fac4c99f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
2023-09-15 08:28:22 +00:00
Henning Gruendl
6fbf77b027 QmlDesigner: Fix open/close Connections Editor
Improve the selection mechanism in all 3 Connections Editor tabs. When
a new item is added automatically select it and open the popup. When the
current item is removed, close the dialog. When the dialog is closed
deselect the item.

Change-Id: I918bbff6b290b38d496de8c2fa5f31d617f4d21c
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-14 17:17:28 +00:00
Thomas Hartmann
32f8fc4311 QmlDesigner: Show dot properties if combobox is used
Change-Id: I3ea4539f178349551854843838948bf02740eb5b
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-14 17:17:15 +00:00
Aleksei German
26ac6c2606 QmlDesigner: Integrate Editor into Connections
Task-number: QDS-10530
Change-Id: I579c5e5d55b2136b96e32a448315dda8e720f2fb
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-14 17:16:47 +00:00
Knud Dollereder
3a7f41b78c Prevent creation of nonexistent binding expressions
Change-Id: Id6f9f35cd40667d694fcdf06d51c4642ae71afcd
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-14 17:09:42 +00:00
Henning Gruendl
9be23b73ea QmlDesigner: Align code preview properly
Change-Id: I05599041b69edf7c8ecaeeff0144d1a4ed6117c3
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-14 15:04:21 +00:00
The Qt Project
3473d9d388 Merge "Merge remote-tracking branch 'origin/11.0' into qds/dev" into qds/dev 2023-09-14 12:52:09 +00:00