Drop single-use service name constants in bosch_alarm

homeassistant/components/bosch_alarm/const.py

@@ -5,4 +5,3 @@ ATTR_HISTORY = "history"
 CONF_INSTALLER_CODE = "installer_code"
 CONF_USER_CODE = "user_code"
 ATTR_DATETIME = "datetime"
-SERVICE_SET_DATE_TIME = "set_date_time"

homeassistant/components/bosch_alarm/services.py

@@ -14,7 +14,7 @@ from homeassistant.exceptions import HomeAssistantError
 from homeassistant.helpers import config_validation as cv, service
 from homeassistant.util import dt as dt_util
 
-from .const import ATTR_DATETIME, DOMAIN, SERVICE_SET_DATE_TIME
+from .const import ATTR_DATETIME, DOMAIN
 from .types import BoschAlarmConfigEntry
 
 
@@ -61,7 +61,7 @@ def async_setup_services(hass: HomeAssistant) -> None:
 
     hass.services.async_register(
         DOMAIN,
-        SERVICE_SET_DATE_TIME,
+        "set_date_time",
         async_set_panel_date,
         schema=SET_DATE_TIME_SCHEMA,
     )

tests/components/bosch_alarm/test_services.py

@@ -8,11 +8,7 @@ from unittest.mock import AsyncMock, patch
 import pytest
 import voluptuous as vol
 
-from homeassistant.components.bosch_alarm.const import (
-    ATTR_DATETIME,
-    DOMAIN,
-    SERVICE_SET_DATE_TIME,
-)
+from homeassistant.components.bosch_alarm.const import ATTR_DATETIME, DOMAIN
 from homeassistant.const import ATTR_CONFIG_ENTRY_ID
 from homeassistant.core import HomeAssistant
 from homeassistant.exceptions import HomeAssistantError, ServiceValidationError
@@ -41,7 +37,7 @@ async def test_set_date_time_service(
     await setup_integration(hass, mock_config_entry)
     await hass.services.async_call(
         DOMAIN,
-        SERVICE_SET_DATE_TIME,
+        "set_date_time",
         {
             ATTR_CONFIG_ENTRY_ID: mock_config_entry.entry_id,
             ATTR_DATETIME: dt_util.now(),
@@ -62,7 +58,7 @@ async def test_set_date_time_service_fails_bad_entity(
     with pytest.raises(ServiceValidationError) as err:
         await hass.services.async_call(
             DOMAIN,
-            SERVICE_SET_DATE_TIME,
+            "set_date_time",
             {
                 ATTR_CONFIG_ENTRY_ID: "bad-config_id",
                 ATTR_DATETIME: dt_util.now(),
@@ -87,7 +83,7 @@ async def test_set_date_time_service_fails_bad_params(
     ):
         await hass.services.async_call(
             DOMAIN,
-            SERVICE_SET_DATE_TIME,
+            "set_date_time",
             {
                 ATTR_CONFIG_ENTRY_ID: mock_config_entry.entry_id,
                 ATTR_DATETIME: "",
@@ -110,7 +106,7 @@ async def test_set_date_time_service_fails_bad_year_before(
     ):
         await hass.services.async_call(
             DOMAIN,
-            SERVICE_SET_DATE_TIME,
+            "set_date_time",
             {
                 ATTR_CONFIG_ENTRY_ID: mock_config_entry.entry_id,
                 ATTR_DATETIME: dt.datetime(2038, 1, 1),
@@ -134,7 +130,7 @@ async def test_set_date_time_service_fails_bad_year_after(
     ):
         await hass.services.async_call(
             DOMAIN,
-            SERVICE_SET_DATE_TIME,
+            "set_date_time",
             {
                 ATTR_CONFIG_ENTRY_ID: mock_config_entry.entry_id,
                 ATTR_DATETIME: dt.datetime(2009, 1, 1),
@@ -158,7 +154,7 @@ async def test_set_date_time_service_fails_connection_error(
     ):
         await hass.services.async_call(
             DOMAIN,
-            SERVICE_SET_DATE_TIME,
+            "set_date_time",
             {
                 ATTR_CONFIG_ENTRY_ID: mock_config_entry.entry_id,
                 ATTR_DATETIME: dt_util.now(),
@@ -179,7 +175,7 @@ async def test_set_date_time_service_fails_unloaded(
     with pytest.raises(ServiceValidationError) as err:
         await hass.services.async_call(
             DOMAIN,
-            SERVICE_SET_DATE_TIME,
+            "set_date_time",
             {
                 ATTR_CONFIG_ENTRY_ID: mock_config_entry.entry_id,
                 ATTR_DATETIME: dt_util.now(),