Compare commits

...

1 Commits

Author SHA1 Message Date
Claude
15094c0693 Remove volume_up/volume_down overrides from group media player
The base class already handles volume stepping with the default step
size of 0.1, making these overrides redundant. The previous
implementation also had a bug where iterating over entities and calling
async_set_volume_level would set all group members to the last entity's
adjusted volume rather than stepping each independently.

https://claude.ai/code/session_01Gn8AeZ8HvyyDw53e1rynUA
2026-02-27 19:34:45 -05:00

View File

@@ -423,20 +423,6 @@ class MediaPlayerGroup(MediaPlayerEntity):
context=self._context,
)
async def async_volume_up(self) -> None:
"""Turn volume up for media player(s)."""
for entity in self._features[KEY_VOLUME]:
volume_level = self.hass.states.get(entity).attributes["volume_level"] # type: ignore[union-attr]
if volume_level < 1:
await self.async_set_volume_level(min(1, volume_level + 0.1))
async def async_volume_down(self) -> None:
"""Turn volume down for media player(s)."""
for entity in self._features[KEY_VOLUME]:
volume_level = self.hass.states.get(entity).attributes["volume_level"] # type: ignore[union-attr]
if volume_level > 0:
await self.async_set_volume_level(max(0, volume_level - 0.1))
@callback
def async_update_group_state(self) -> None:
"""Query all members and determine the media group state."""