wolfSSL/wolfssl
1
0
Fork 1
mirror of https://github.com/wolfSSL/wolfssl.git synced 2026-07-10 20:10:49 +02:00
Code Issues Packages Projects Releases Wiki Activity

tests: skip AES rounds-corruption under FIPS/self-test (fixes CCM segfault)

Browse Source 
test_wc_AesCcmArgMcdc segfaulted on the FIPS builds (apple-M1 config A, CAVP
self-test), exit 139. The AES *ArgMcdc tests reach the post-key-setup "ret != 0"
checkpoints by corrupting aes->rounds = 0 and calling wc_AesCcmEncrypt/Decrypt.
That relies on the pure-C AesEncryptBlocks_C guard (if r==0 return KEYUSAGE_E) to
turn the corruption into a clean error return. Under the FIPS / self-test module
the AES implementation has no such guard, so rounds=0 runs AES with a zero-round
key schedule and dereferences past the key schedule -> SIGSEGV.

The corruption is already gated by WC_TEST_AES_ROUNDS_OFFLOADED (crypto-cb / asm
offload). FIPS and self-test are the same situation - the pure-C guard is not in
the compiled path - so add HAVE_FIPS / HAVE_SELFTEST to that macro. The three
function-level FIPS-guarded tests (SetKey/Modes/Cmac ArgMcdc) were already
skipped; test_wc_AesCcmArgMcdc is not, and its non-corruption CCM coverage now
still runs under FIPS while only the rounds-corruption blocks are skipped.

Verified: --enable-all (non-FIPS) still runs and passes all rounds-corruption
tests; the corruption blocks compile out only under FIPS/self-test.
This commit is contained in:
Daniele Lacamera
2026-07-07 06:49:32 +02:00
parent e63555a924
commit 4755bb21c5
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/api/test_aes.c
+6 -1
View File
@@ -59,7 +59,12 @@
* (e.g. WOLFSSL_ARMASM on ARMv8 with crypto extensions).
* In all these cases the corrupted struct is ignored and the op returns 0. */
#if defined(WOLF_CRYPTO_CB_FIND) || defined(WOLF_CRYPTO_CB_ONLY_AES) || \
defined(WOLFSSL_ARMASM)
defined(WOLFSSL_ARMASM) || defined(HAVE_FIPS) || defined(HAVE_SELFTEST)
/* The aes->rounds=0 corruption trick relies on the pure-C AesEncryptBlocks_C
* guard (if r==0 return KEYUSAGE_E). When AES is offloaded (crypto-cb / asm)
* or provided by the FIPS/self-test module, that guard is absent: rounds=0
* runs AES with a zero-round key schedule and segfaults instead of erroring.
* Treat those builds as offloaded so the corruption blocks are skipped. */
#define WC_TEST_AES_ROUNDS_OFFLOADED
#endif