Commit Graph

57165 Commits

Author SHA1 Message Date
Orgad Shaneh
1678e9eb1e ProjectExplorer: Do not overwrite shared project settings
Change-Id: Iecf684677599975e6f44df0d354ce7cd8c7aeeb9
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2018-05-08 07:56:20 +00:00
Tobias Hunger
4ce6438b34 Tracing: Consistently use nullptr
Fixed by clang-tidy modernize-use-nullptr.

Change-Id: Ibdc872ddc2ea802b14c328a496eda3531b7e1718
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2018-05-08 07:44:03 +00:00
Tobias Hunger
d96d786c34 ExtensionSystem: Consistently use nullptr
Fixed by clang-tidy modernize-use-nullptr.

Change-Id: Ibf3797854e8f15940d363695ce30cc4558ed1ab8
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-05-08 07:43:52 +00:00
Tobias Hunger
053e4494cf Qml: Consistently use nullptr
Fixed by clang-tidy modernize-use-nullptr.

Change-Id: Ibe0dddaacbabd47b5a0519ae361132818d5b8be2
Reviewed-by: Marco Benelli <marco.benelli@qt.io>
2018-05-08 07:43:40 +00:00
Tobias Hunger
c6ba157155 Valgrind: Consistently use nullptr
Fixed by clang-tidy modernize-use-nullptr.

Change-Id: I9ae41e4d76168fa5a2e379eb1cdf605e4d106596
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2018-05-08 07:43:30 +00:00
Tobias Hunger
f402c22fdf Nim: Consistently use nullptr
Fixed by clang-tidy modernize-use-nullptr.

Change-Id: I9f9d29f4e2d32b94e805a3e0c8e372e373cf8a63
Reviewed-by: hjk <hjk@qt.io>
2018-05-08 07:43:20 +00:00
Tobias Hunger
44319ff6e2 RemoteLinux: Consistently use nullptr
Fixed by clang-tidy modernize-use-nullptr.

Change-Id: I2a608fec95a489b3bde426e46d288672c6d1d20d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-05-08 07:43:06 +00:00
Tobias Hunger
05dd3285fc Core: Consistently use nullptr
Fixed by clang-tidy modernize-use-nullptr.

Change-Id: I62a9388ab873410555f45a8a6f9b0149467ddbaa
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-05-08 07:42:55 +00:00
Tobias Hunger
e2c4186f99 ResourceEditor: Consistently use nullptr
Fixed by clang-tidy modernize-use-nullptr.

Change-Id: I1b13a1da542fd2edc2af65f892b0c01937ab1481
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-05-08 07:42:08 +00:00
Tobias Hunger
2bd400be5f TextEditor: Consistently use nullptr
Fixed by clang-tidy modernize-use-nullptr.

Change-Id: I7170c4cb1eef0aa5cd2b10d626ebcae38090a713
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-05-08 07:41:56 +00:00
Tobias Hunger
5c56f6878e Nim: Use override consistently
clang-tidy fixes from modernize-use-override check.

Change-Id: I70a611f5fb798c54d960b8969c77daf143dd9131
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2018-05-08 07:41:45 +00:00
Tobias Hunger
5af5fd0a73 GLSL: Use override consistently
clang-tidy fixes from modernize-use-override check.

Change-Id: I26e47da774cf1c156d85f28a86f84fa21c3470e3
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2018-05-08 07:41:33 +00:00
Tobias Hunger
5e2fe8aea2 TextEditor: Use override consistently
clang-tidy fixes from modernize-use-override check.

Change-Id: Ie98c08279d7bf01f2705f631500dcabac5ba85d1
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-05-08 07:37:17 +00:00
Ulf Hermann
b6f5ec3559 Tracing: Use the same "lock" mechanism in flame graph as in timeline
You can disable hover selection by "closing" the lock.

Task-number: QTCREATORBUG-19788
Change-Id: Ibfcbd17745b2928fd4951312770a673a2677d404
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-05-08 07:33:34 +00:00
Ulf Hermann
def017e5cb Unify flame graph and timeline details windows
They are mostly the same.

Change-Id: I41be570989ecc58cf2ae33f692c89946b55a0e1d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-05-08 07:02:39 +00:00
Ulf Hermann
f6b791815a Tracing: Reset the selected type ID when clicking empty space
We want to get rid of the selection after all.

Change-Id: I3a8b1b785d9d81870e5ff368a31e1642f399a47f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-05-08 07:02:23 +00:00
Ulf Hermann
3a379e5d1f Tracing: Don't call selectClicked() after changing the root
The selectedNode and hoveredNode are invalid at that point. Rather,
reset them before changing the root. As the whole tree is rebuilt, the
isSelected condition will be re-evaluated for each node, and the right
one will be selected anyway.

Change-Id: Id641accfae4f4e240740219013ad5f81e04dd054
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-05-08 07:02:12 +00:00
Ulf Hermann
22e523e504 Add generic FlameGraphView QML component
This allows us to reduce code duplication, but we first have to put
timeline and flame graph into the same library, so that we can use the
TimelineThere in FlameGraphView.

Change-Id: I72b27ffb1fc5aa6baf6a23d85e5ca6c610896b8c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-05-08 07:02:05 +00:00
Orgad Shaneh
bd91d938c4 Clang: Fix compiler warnings
MSVC64 reported implicit size_t to int/unsigned conversion.

Change-Id: I253626dd25f9f3eb67b8fffb26006b619e826034
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2018-05-08 06:31:28 +00:00
Christian Stenger
3b7d550a7c AutoTest: Do not connect on nullptr object
The application can be a nullptr. If so, do not try to
establish a connection.

Change-Id: Icdcd04a016105f163691144277f44c65f96d3847
Reviewed-by: David Schulz <david.schulz@qt.io>
2018-05-08 05:40:59 +00:00
Sergey Morozov
743a37dda2 Autotest: Add editor's mark for test's failed assertion
Tooltip shows failure details. Click navigates to test results pane.

Task-number: QTCREATORBUG-20328
Change-Id: I47ffaef1f035dfc5b244644a099e1c7d8db6715b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-05-07 18:28:15 +00:00
Tobias Hunger
c4530d64b8 Git: Consistently use nullptr
Fixed by clang-tidy modernize-use-nullptr.

Change-Id: I15944fd368fc9ee748545a295632fd1059048c46
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-05-07 16:47:16 +00:00
Tobias Hunger
98f779b8b9 ProjectExplorer: Consistently use nullptr
Fixed by clang-tidy modernize-use-nullptr.

Change-Id: Ibf8ae8c4ecc0cf779ef311dbfec35cda04d36a4f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-05-07 16:45:08 +00:00
Tobias Hunger
618923ddd2 VcsBase: Consistently use nullptr
Fixed by clang-tidy modernize-use-nullptr.

Change-Id: I496d3febae9c445dc96490582a5d4ae86fec71ee
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-05-07 16:44:21 +00:00
Aleix Pol
ca537013f7 Improve AppStream metadata
Solves the issues mentioned in the bug report by adding missing fields
and fixing broken URLs.

Task-number: QTCREATORBUG-20374
Change-Id: Iddea835d27ab914283b6b846a4a4379cbb0b546a
Reviewed-by: Lisandro Damián Nicanor Pérez Meyer <perezmeyer@gmail.com>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-05-07 16:10:49 +00:00
Tobias Hunger
005d81cc15 Designer: Use override consistently
clang-tidy fixes from modernize-use-override check.

Change-Id: Ied022e91ddcba80a6411ca70e4ea2cedfe0bbf6d
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
2018-05-07 15:45:23 +00:00
Tobias Hunger
c614c30dad QmlDebug: Use override consistently
clang-tidy fixes from modernize-use-override check.

Change-Id: Ied0d1ed13163fb8ddb9f332a0302a3081ceb7aa3
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2018-05-07 15:45:12 +00:00
Tobias Hunger
685f031cc3 QmlEditorWidgets: Use override consistently
clang-tidy fixes from modernize-use-override check.

Change-Id: I456fe6e6e10a5e4bf58868c8f3e0ed0eef87524e
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2018-05-07 15:45:05 +00:00
Tobias Hunger
0cb0c0451d QmlJsEditor/QmlJsTools: Use override consistently
clang-tidy fixes from modernize-use-override check.

Change-Id: I29716dcf73946b5762568d349a3f5a3da4f656e6
Reviewed-by: Marco Benelli <marco.benelli@qt.io>
2018-05-07 15:44:57 +00:00
Tobias Hunger
3f578757ff Help: Use override consistently
clang-tidy fixes from modernize-use-override check.

Change-Id: I3aec6d7ab1e8f088b745d2d9730e3d49ced42031
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-05-07 15:44:48 +00:00
Tobias Hunger
a0d560387e RemoteLinux: Use override consistently
clang-tidy fixes from modernize-use-override check.

Change-Id: Ie9272b33022bea665c305d6bb71d8451a0968d5d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2018-05-07 15:44:36 +00:00
Tobias Hunger
2ec6cf1041 Debugger: Use override consistently
clang-tidy fixes from modernize-use-override check.

Change-Id: I6a20484716dc5bd84fe9592b40ae57be66fe32bf
Reviewed-by: hjk <hjk@qt.io>
2018-05-07 15:44:21 +00:00
Tobias Hunger
3890f5d67d ExtensionSystem/Aggregation: Use override consistently
clang-tidy fixes from modernize-use-override check.

Change-Id: Ic10099c2a2f3a070c972442736e50e797a063597
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-05-07 15:44:10 +00:00
Tobias Hunger
743d3fbb50 QmlDesigner: Use override consistently
clang-tidy fixes from modernize-use-override check.

Change-Id: I7d2025b076a18bb42babf63e13129c89469d2d2a
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2018-05-07 15:44:01 +00:00
Tobias Hunger
60d94ee7b5 Core: Use override consistently
clang-tidy fixes from modernize-use-override check.

Change-Id: If33399d60e96cae766bbedbe30044ada411e862f
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2018-05-07 15:43:44 +00:00
Tobias Hunger
0e71ed1bfc QmlPuppet: Use override consistently
clang-tidy fixes from modernize-use-override check.

Change-Id: Ia9785ef4d5d236d9740abec26359495eaea2fad1
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2018-05-07 15:43:28 +00:00
Tobias Hunger
bd87969b63 QmakeProjectManager: Use override consistently
clang-tidy fixes from modernize-use-override check.

Change-Id: If75d8ae6b75edf271602e9352ea4cfac849c40ee
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-05-07 13:40:04 +00:00
Tobias Hunger
0b86937dda Beautifier: Use override consistently
clang-tidy fixes from modernize-use-override check.

Change-Id: I3909c20b7d4f6411f7d959f8524f2269cf8433c4
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2018-05-07 13:39:51 +00:00
Tobias Hunger
dc2fc415b7 ScxmlEditor: Use override consistently
clang-tidy fixes from modernize-use-override check.

Change-Id: I636077ee65961a797677ecab39741870470566e0
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2018-05-07 13:39:41 +00:00
Tobias Hunger
e30939fe4d Tracing: Use override consistently
clang-tidy fixes from modernize-use-override check.

Change-Id: I6ddeef87244c2242945dd91e29ef0cd8bb9fe636
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2018-05-07 13:39:29 +00:00
Tobias Hunger
1923d38e5b QtSupport: Use override consistently
clang-tidy fixes from modernize-use-override check.

Change-Id: I581aa9e84bf0376aaa894c62cd54bb8c1897ce48
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-05-07 13:39:13 +00:00
Tobias Hunger
5451413c2d VcsBase: Use override consistently
clang-tidy fixes from modernize-use-override check.

Change-Id: I4775c493dbeefaf832b862f8740f216a3aacbfc6
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-05-07 13:39:03 +00:00
Tobias Hunger
e7d13245a4 ResourceEditor: Use override consistently
clang-tidy fixes from modernize-use-override check.

Change-Id: Id6552ad0b704702fa7a839051714027b4f5ffc1d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-05-07 13:38:46 +00:00
Tobias Hunger
dee0207034 ProjectExplorer: Use override consistently
clang-tidy fixes from modernize-use-override check.

Change-Id: I216701aec0b4134321e220f9e599e053a8e22945
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2018-05-07 13:38:34 +00:00
Tobias Hunger
91c19ab19d CppTools: Use override consistently
clang-tidy fixes from modernize-use-override check.

Change-Id: I0e6d6a9df3e87b8042ccc5ea0adc70070a3821d6
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
2018-05-07 13:38:20 +00:00
Tobias Hunger
f531f76d04 Valgrind: Use override consistently
clang-tidy fixes from modernize-use-override check.

Change-Id: I86854125710ee2a24f4b663546f87baafefb9679
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2018-05-07 13:37:22 +00:00
Tobias Hunger
a939ec8244 QmlProfiler: Use override consistently
clang-tidy fixes from modernize-use-override check.

Change-Id: Ide82798f95e07be6c842a1c2fcf28573d9c635ed
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2018-05-07 13:37:07 +00:00
Orgad Shaneh
6947639d9f QmlProfiler: Fix signed/unsigned comparison warning
Change-Id: I325ce3490b8ea2d1883fb6ec8eb319b9c9145af8
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2018-05-07 09:16:46 +00:00
Christian Kandeler
b36965776c QbsProjectManager: Fix the paths of non-installed executables
... in run configurations. One check was missing.
This amends c6cd9e8fbe.

Change-Id: If398a719adbb5a5c2a527b70d274751ada91abe4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-05-07 09:01:58 +00:00
hjk
8b452b28d2 Inline complex RunConfigurationCreationInfo constructor
Names are easier to follow than positions in long argument lists.

Change-Id: Ia0ace9d864a1100e649f6725e7de338ab2653d05
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2018-05-07 07:46:20 +00:00