* Use range-based for
* Use nullptr
* Use inline member initialization
* Fix real/int implicit casts
Change-Id: I17fc35382ef22c97b34faba741915b9b914e38ff
Reviewed-by: David Schulz <david.schulz@qt.io>
This allows us to share code between the two, in particular the QML code
for the Details window, and the theme code. This way we can potentially
deduplicate some code.
Change-Id: I3a0d26b18488bd2a46b5b077b5b5d79ac2dfc5ce
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
When transforming between containers with different size_type, like
QList and std::vector.
Change-Id: Ife28aacdc8627e81901579cde8b563da1408d084
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Scale the highlight on the handle according to the number of lines
visible on screen. In case when document has huge amount of lines
and only couple of lines are visible on screen, this
generates a nice magnification effect.
Change-Id: I43d7cce859cbc14da77272685a6f8d2350b41bb7
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This configuration is used not only for static
analyzer but for all tools.
Change-Id: I5ef282500e0addb4ca104b34530e56fba80f59b8
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
We use custom clang executable and it does not make
sense anymore to give a choice of changing it.
Change-Id: Icf86042ac3fcd08c320ef2bbdaabef1102b023b5
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
The project tree will sort the nodes as needed, so there is no
need to sort the list beforehand.
Change-Id: I1ee71100aba003117c918c5295224ec1253dc807
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Remove FolderNode::addNestedNodes that take raw pointers now that the
last user is gone.
Change-Id: If2ca3864934d9239ac136e65c0b7dbcea7caf220
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Do the same as in case of sidebyside editor.
Task-number: QTCREATORBUG-18306
Change-Id: I1364aed0edb02dd9f5432e191ce4fb4b2db34430
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
The path of a .pro files is a qmake specific concept, the
build system should not play a role in running things.
Change-Id: I63657c803a7fb5b9c0b7fabbe42f4333827a44f9
Reviewed-by: David Schulz <david.schulz@qt.io>
Use simple project with only few ClangTidy and Clazy warnings.
Change-Id: Idfbbeb653c5f610bda502c3ec23e7497f503f8a9
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
Sometimes it makes sense to have the function call
settable. For example if the call on destruction is
needed only for one branch of 'if' but the required
lifetime scope is not limited to that if-scope.
Change-Id: I93dbc1ee3798a08e5778445286b83b2848a54e3e
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
This change limits the set of tokens that fall under
Token::isOperator(). That allows cpphighlighter.cpp to
distinguish operator tokens from punctuator tokens
(without changing any logic in cpphighlighter.cpp).
This change moves punctuators from "Operator"
to the "Text" style category where they belong.
Punctuators are not operators. Punctuators are
dumb text tokens.
Why don't we let the clang backend alone separate
these tokens for us?
1. Clang is slow on big files. Sometimes the
highlighting dictated by clang is painted _seconds_
after cpphighlighter.cpp runs. CppHighlighter is way
faster so we use it to "prepaint" code while clang is
busy in the background.
2. Secondly, clang cannot yet handle all operator types.
In particular, none if its "operator cursors"
CXCursor_UnaryOperator:
CXCursor_BinaryOperator:
CXCursor_CompoundAssignOperator:
CXCursor_ConditionalOperator:
includes the -> and . operators.
We still need CppHighlighter to paint those tokens.
However, once clang has finished processing the file some
operator tokens will be repainted. We need clang to get
all operators' semantics. In particular, we need clang to
tell us if < is a "smaller than"-operator or part of a
template parameter like set<int>.
Task-number: QTCREATORBUG-19659
Change-Id: I952cb58f7c79134b3281e2a8221425cc1d0ad263
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Color types and enable Ctrl+click for the functions
and types inside SIGNAL/SLOT macros.
Change-Id: Ic1c0b7372fe9a73c5607b1973d75a6656c75ef0e
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
The kit information needs to be shown in the tooltip.
Amends 460fdc02e0
Change-Id: Id661318d97244c6c35c5880842788fa265cc0098
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Soft-assert when a root project node is set again, except when
that node is nullptr.
Change-Id: Ib7c1891defc79d464a692c0e982b668be9a40cf9
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
...when closing editors fast (e.g. holding Ctrl+W).
Due to the queued connection the slot was invoked after the deletion of
the editor. There is no point in having a queued connection here, so
remove it.
Task-number: QTCREATORBUG-20191
Change-Id: I3872f8046b56f93c9aac832feccfd911d39e5995
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Not sure why it takes so much space, tried different tricks,
nothing was working - so just take the half and hope.
Change-Id: Ib9ea475281b860838391f370c4f1eed98e327903
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
* formattedDataSize was added in Qt 5.10
* We simply use KB instead
Change-Id: I2b09eb865ce27e097bc5fb2164f3da73b2437b5d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
we do not use clang-cl anymore but we can use this flag
to turn on the clang support of MSVC flags.
Change-Id: I1aefc4c0c2324a8f6ce77d93a488126ce8bb0253
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
We show now a dialog that allows to optional change the
target direcotory and gives an overview of the operations.
Change-Id: I3f3337be1049b1c35bfa783c5840fd49d1952806
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Do not double-free oldNode.
Change-Id: Icce2d13b6afd24f2e37c5ca7e2b572a6784e69e1
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This is for information only anyway, and leaving out the path makes
it less useful for e.g. cut&paste to a terminal or to double-check
whether the intended qmake binary is used.
Change-Id: Id35ee37363f58377a9da2e18c3ec6d89caf54312
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Otherwise they can't be deployed to Boot2Qt (and other) devices. Quick
application wizards already have these deployment rules.
Task-number: QTCREATORBUG-20358
Change-Id: I5a19ada3f6a382e8553750769478c398a50352c9
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Kari Hormi <kari.hormi@qt.io>
In case of C-header or C-source files the MSVC
language version was not switched to C.
Fixes static analyzer runs for C files.
Task-number: QTCREATORBUG-20198
Change-Id: I1da31a1048b7c258642cf00f5084681f5d384ee6
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
History completers need a respective key to work properly
and become restorable.
This patch avoids some soft asserts and warnings regarding
empty settings keys.
Change-Id: I7d24d738b29167b7ab9714b4c6d54dbc1f7e1181
Reviewed-by: hjk <hjk@qt.io>
This was the only remaining user of ProjectExplorer::
BuildTargetInfoLists::targetForProject was only.
The result after direct inlining shows that it relies on
the qmake-centered assumption that the the .pro file name
is used as build key in BuildTargetInfoLists, so replace
it with the now-generic projectFilePath member instead.
Change-Id: Ic4dccfb347289a3dcbb4c6a11b71cf568b054fd8
Reviewed-by: David Schulz <david.schulz@qt.io>
By delaying the execution of the action with a singleShot.
Both CommandLocator filters and the menu bar filter are affected.
Task-number: QTCREATORBUG-18863
Change-Id: I4f3d39410621c2d578bc9f7af7357af372a15b73
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
