If the vertical scrollbar is invisible, it reports a width of 100
pixels. Use the width of the size hint, instead.
Task-number: QTCREATORBUG-20353
Change-Id: I3d50041788f12360a98a8f41923c6a38e23a63e3
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
For rebase/merge strategies, this can cause real problems (when the target
branch is forwarded to a more recent branch...)
Task-number: QTCREATORBUG-20062
Change-Id: Ic7c282a1e0571b31d9333290141817c59daa0e7a
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
We use different rewriter for different purposes. Only
the rewriter that manages the current document should disable the UI.
Change-Id: Ic410f7ee62ce13bb0eef133619f93c05b5632a56
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This follows some of the recent changes to RunConfigurations:
- pass Id from factory to DeployConfiguration constructors
- de-object-ify DeployConfigurationFactory
- use addSupportedTargetDeviceType(Id) instead of
addSupportedTargetDeviceType(List<Id>)
Also, use stepList()->appendStep() instead of stepList()->insertStep(pos...)
with manual pos tracking in some cases.
Change-Id: I09c6a9d0f66f9f85b1c13361104f7878028e1ea8
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The functionality is spread over several plugins, not just the platform
plugin.
Task-number: QTCREATORBUG-20354
Change-Id: I3b120d1792be31c98707e2e60124911f3d138188
Reviewed-by: Johan Helsing <johan.helsing@qt.io>
Basically this reverts 08e73d1a93, but adds an
additional check for the column as the BaseTreeModel
implementation just allows children at the first column.
Main reason for this revert is that the variable choosers
used across Qt Creator did no more populate their
respective macro lists automatically.
Change-Id: I172506a9dbe18f20b152ec797f35feff717dc3cf
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
It worked well but the maintenance burden turned out to be too much.
Task-number: QTCREATORBUG-20055
Change-Id: Ic8663f808c50ca9fb17d52b6bc6c72baf7503358
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Makes it more useful as a navigation instrument. If new bookmarks are
always added to the end of the list, the "previous" bookmark will have
nothing to do with the context of the bookmark that was previously the
"current" one.
Task-number: QTCREATORBUG-20061
Change-Id: I0ea38391750371dec80872206d97f4934a37f7b4
Reviewed-by: David Schulz <david.schulz@qt.io>
If the text cursor is currently not at the "current bookmark", it is
more intuitive and useful if "Previous Bookmark" first moves to the
current bookmark, instead of jumping to the one before that.
That solves two issues:
- creating a bookmark, jumping somewhere else, and then going back to
that bookmark
- deleting a bookmark, and then going to the previous one
Task-number: QTCREATORBUG-20061
Change-Id: I6dbb8c94f4d50ae4cc36e52808029e685be11069
Reviewed-by: David Schulz <david.schulz@qt.io>
We used to style overloaded operators in the same way
as C++'s built-in operators. There was no way to tell
if a + token would call a operator+() function or not.
Now, if an operator is overloaded (redefined),
we give it the "Overloaded Operator"-mixin so users
can style it differently.
Note: Calls to overloaded 'new' and 'delete' are not
highlighted by "Overloaded Operator". This is because
clang today always maps these to CXCursor_CXXNewExpr
and CXCursor_CXXDeleteExpr with cursor.spelling == ""
(empty string). So there is no (?) quick way for us
to tell if a new/delete-token was overloaded or not.
After follow-ups, follow symbol will work for operator
overload usages in current translation unit.
Commit is appended by Ivan Donchevskii.
Task-number: QTCREATORBUG-19659
Change-Id: I157855d482a61ad2059642a1ee982089fcb7d312
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
It should be required for every project part which
depends on LLVM.
Change-Id: I8d645661dfa4fc4858bb40e156671a0ecf0bdbe3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Remove some unnecessary #include and use a recently introduced
RunConfiguration::builtTargetInfo() convenience function.
Change-Id: I76750fd66ae2c268b68d225c62aad7d880256d07
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Include interpreter and main script settings.
Change-Id: I91c19ef124ff8b7da34bc67fb1a5ef054c3499b8
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Since the need for code reuse is gone due to the recent changes
in the RunConfiguration base infrastructure, it's easier and less
code to completely separate the cases.
Change-Id: I3fc558ea60e02f34b50869d4b55a43a6360e9208
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Push the stop icon towards (but not completely) the hammer center,
so that there is a visual balance. Also, it is now approximately
aligned with the beetle from the debug button.
Change-Id: Ia277b1ead3ea2357171d386d41e413b38175a691
Reviewed-by: hjk <hjk@qt.io>
Color "SplitterColor" is neither a named color nor a valid color
Fix-up for: 98e26dc6fb
Change-Id: I2d3749a06850e4c630d6a0392e6a1c6e2a75258f
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
As convenience function, and use it in some places.
Change-Id: I02e49f2cdc301bbf1261836032d3fa3a5b188446
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Use the common pattern for PythonEditorPluginPrivate.
Change-Id: Icec8d975e0ab921be7121d123af4dddecd7d0384
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Any SettingsAspect that doesn't refer to the global settings has a
specific RunConfiguration it is about. This can be very handy to know
when constructing the actual settings. Right now there is no way to find
out about it.
Drop the clone() and create() methods. They weren't used anywhere and a
proper implementation should take care of the runConfiguration member.
Change-Id: Ie505a9b19707f8a1b6bf9cae73513cd3c30d0bca
Reviewed-by: hjk <hjk@qt.io>
With Qt 5.9 as minimal build version, we don't need to handle 5.7 or 5.8
Change-Id: Ie1eed95ab46364452b0633f78bebc565a4a63f4a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Split the run config widget according to the two use cases
(direct apply, delayed apply). As basically most data members
and important logic was not shared, the double-use made
the CustomExecutableRunConfiguration implementation needlessly
complicated.
Change-Id: If92ba22bae31378bae29049e0d27095b2bbd6090
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
... over the whole project.
Generate and read serialized files to get diagnostics.
Change-Id: Iafc25fc70443107a040a995efc038aed35102bbf
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
This has been superseded by other items, most notably the buildKey.
Incidentally, even Creator 4.6 is robust enough to handle .user files
without the CMakeProjectManager.CMakeRunConfiguation.Title key without
problem.
Change-Id: Iaecb2c15b31ebfb78146c0bec8b955ae821e4499
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Using QFlags here increases the size of a Node by extending the
m_flags from 16bit to 32bit and adds needless padding.
Change-Id: I9169585a7f91da5b85433fcd6f4d1bb7d39e65c1
Reviewed-by: hjk <hjk@qt.io>
