- In the QDS Manual, edit the "Code" view docs
- In the QDS Manual, add topics related to coding to the "Code"
view docs by using \ingroup and \generatelist commands
Task-number: QTCREATORBUG-29361
Change-Id: I0966986a3b01b3551e8b68265e22fe86d1d5933d
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
The \nexpage and \previouspage links in the QDS Manual are now
automatically generated according to the list in the "All Topics"
topic.
Change-Id: If93c605863269056060b1585641feac167d95f25
Reviewed-by: Esa Törmänen <esa.tormanen@qt.io>
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
- Add a dependency to qtqmltest (Qt Quick Test)
- Fix an internal link
- Fix capitalization in links to Qt docs, which now
seems to matter
- Add the "Qt Qml" link as an external resource, so it works
regardless of the Qt version used
Change-Id: I0550973237b0df7b328ca202a4188d970af3417d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The project manager was passing correctly the system headers, but the
compileroptionsbuilder was ignoring them by having UseSystemHeader::No.
This change makes the project's view to be reflected in clangd's
compile_commands.json.
Fixes: QTCREATORBUG-30474
Change-Id: Ie3b80642e27ada4c8c8725f21e3cfbb2a4051aa0
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
`NSApplicationActivateIgnoringOtherApps` is deprecated and doesn't have
any effect any more. Switch this to `NSApplicationActivateAllWindows`
which we actually want when running an application, and remove an
unneeded cast.
Change-Id: I75849533e4b172db577d5484ef12c8ee4df20d59
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
The running VcsCommand may leak on shutdown. Make them always
a child of a guard object.
Change-Id: Ie2d07d15cd13f1c08636bb1e9c5face09c6a782d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This does not change what you see as values of \previouspage
and \nextpage in the source files. However, when you build the
docs, QDoc replaces those values with links to the next and
previous page from the list in qtdesignstudio-toc.qdoc because
that page contains "\title All Topics".
So, with this change, you need to keep the list in "All Topics"
up to date.
Change-Id: I0996e383cbd60b7f4297524e4141a2d7af6fae13
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
- Replace hasNext()/next() with a `bool advance()` method
- Replace QAFE::FileTime with QFile::FileTime, they are identical
- QAFE methods now return std::unique_ptr, which matches reality as call
sites stored the pointers in a std::unique_ptr anyway
FileIteratorWrapper:
State::BaseIteratorEnd is only needed when using hasNext()/next(),
hasNext() changes m_status to State::BaseIteratorEnd, then next() checks
that and changes m_status to State::Ended; this isn't needed with
advance() since it's only one method.
Change-Id: I4414f334715237a2fc13ace6f4733d975e2cfaa3
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
If an exception is thrown or the program is abortet there is still the
begin of a slice. Because a duration slice is only wirtten at the end we
get no slice.
Change-Id: I8b05e9ae045517a503c2a6f00936b05715b812ca
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
As EventQueueData was derived from EventQueue the order of
initialization was inverted. So we got dangling pointer. Merging
EventQueueData into EventQueue fixes the dangling references.
Change-Id: I3d9cee492304132fa612d6d19324656df597ec99
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
The tuple are constructed on the stack, so we cannot hold references to
it.
Change-Id: Ia02bf21516c97eb67eca8fd56e68dbd10878ca9e
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
widgetInfo() should be cheap but people make expensive stuff inside the
call. So we should try to avoid to many calls.
Change-Id: I66b0a5431471732dca934fc03efb307e2617fd65
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Pointer to temporaries create dangling pointer. So we have to copy the
tuples. The leafes still only contain references.
Change-Id: I37900be569283324178e223829f913fb4ccba16e
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
That terminate handler is only installed if any event queue is
activated. That is only the case if you compile with a special
option.
Change-Id: I4d8661c0fa11d8bb14b49b7b963471f626b3b950
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
The constructor for the category was missing. Otherwise the CTAD is not
working.
Change-Id: I4d4c2aaba8915fbbade0b8ce4f1310046d748cd1
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
The QmlDesigner landing page appears if a *.ui.qml document is open, and
user selects the "design" mode. Between QtC 12 and 13, the landing page
broke (unnoticed) due to the removal of the "Welcome_*" theme colors.
This change lets the Landing page use the new color tokens. A few fixes
in the PushButton component were needed.
Fixes: QTCREATORBUG-30547
Change-Id: I93319665bb283fba7f7a8892b671aaeb11479c7e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The warning was not shown when opening a project with the QML debugging
option enabled.
The `changeHandler` was explicitly called at construction, but at this
point the `warningLabel` doesn't have a parent. The `setVisible` call
was skipped in this case, to prevent opening a toplevel window (for a
short time) for it until it has a parent.
Unfortunately there is no Qt API for setting the "visibility to the
parent". Instead invert the logic: Let the label have default visibility
to start with (which is "visible if the parent is visible"), and force
it to hidden in `changeHandler` if necessary.
Amends eda5fbd645
Change-Id: I69b86a967ee1fe7bd3d5d035765349981b64eb72
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
In cases when a CMake project is using a CMake preset with a toolchain
file, the CMAKE_C|XX_COMIPLER value was not set in the CMakeCache.txt.
This commit makes sure that the cache from the CMake preset probe
contains CMAKE_C|XX_COMPILER values.
Task-number: QTCREATORBUG-30474
Change-Id: I63ac6fe2b043e49dda98e286b6d85950e34be920
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Using the same value for two topics hides the old topic, but
QDoc did not complain during local builds.
Change-Id: Id5d927cca60c9d288323429c99969475c9ecd15b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
ConPTY on windows will send "clear line" characters in response
to resizing the PTY.
During re-showing the terminal pane the widget receives a "height=0"
resize event. We have to ignore this otherwise the conpty might try to
clear the screen.
Another issue was that we are calling resize on the pty even thought the
process has ended and won't be able to respond to the clear attempty by
the pty anymore.
Fixes: QTCREATORBUG-30523
Change-Id: I24caeaffb31d255a0640952e2d35bda23fd16280
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Otherwise the cog menu appears below the popup
Change-Id: If3b541bd98b2d771687373c9259ad017349d4215
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Other code expects all of them to be collapsed, but Creator 13 expands
them when checking. This change makes sure they are collapsed afterwards.
The new code is backwards compatible with the old behavior.
Change-Id: Ic698fb17f3ad1573195e7e0f7bcf722beed74ffc
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
...to "Configuring Projects"
Turn "Linking Projects with GitLab" to a separate how-to
topic.
Some style edits.
Change-Id: I3fd68b303126770965c7ca68ca2e041daf593d74
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Url properties should be set as urls to avoid asserts.
Change-Id: I990e731f4555943ce35443226ab053286c58bd58
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Deeply under the hood, the color for ther Spinner was determined by the
QApplication palette, color role "Text".
In order to run the spinner on a dark toolbar (in a non-dark theme),
though, the color needs to be bright. It is the case for the
ScreenRecorder.
This change adds a color setter to the Spinner classes, adds colored
Spinners to tst_spinner and makes use of the feature in the
ScreenRecorder.
The default color of the Spinner remains QApplication palette, color
role "Text".
Change-Id: Ia75758707f225b1f994e73c5a314478101c80f5e
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
If the user selects "Record Screen" while the ffmpeg/ffprobe are not
set, the ScreenRecorder settings are shown. The ScreenRecorder dialog
did open up after the settings page, even if the user just pressed OK
without setting the tools.
With this change, not the settings page return value determines whether
to show the ScreenRecorder dialog, but rather a second check if the
tools are set/registered.
Change-Id: I35b8f4e3afe7ea5e6834fcff74ce8f73d3a115b4
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Put the future into the future synchronizer.
Otherwise, when (un)registedDocumentationNow() is still executed
on shutdown we are destroying the locked mutex and crash.
Change-Id: Ic8e7f8252719a3015101a0f5fc7b48ba57956562
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The old sources used deprecated features.
Done by:
1. Assuming that current Creator works correctly because
it is passing the test with the old sources.
2. Replacing the .tsv's contents with what Creator
generates from the new sources on Linux.
3. Removing everything from the .tsv which is not found
in the same place on Windows.
Change-Id: I31f0f1a46c1972d8c717c216275dd453ca74fc27
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>