Commit Graph

68765 Commits

Author SHA1 Message Date
hjk
2a07253a42 Debugger: Rename debuggerkitinformation.{cpp,h}
... to debuggerkitaspect.{cpp,h}

Change-Id: Ia6316fcdc893ca066933658a52c78ef1587a76e8
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-08-16 07:33:43 +00:00
hjk
a3b93481da Debugger: Hide KitAspectFactory
Change-Id: If98f4598efb273852a602a9ed7379341a3720a60
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-08-16 07:27:10 +00:00
Marcus Tillmanns
ae51ad8c92 Copilot: Move to Settings::setLayouter()
Change-Id: I1d7d9872f12aa5436f03107bdd5fedfbe2829700
Reviewed-by: hjk <hjk@qt.io>
2023-08-16 06:55:06 +00:00
Marcus Tillmanns
f2d62c6d91 Copilot: Add support for proxy settings
For easier testing a docker file is added. You can start
"buildandrun.sh" in copilot/tests/proxy to get a simple
proxy server up and running. The argument "PWDMODE" in
buildandrun.sh can be set to "with" and "without" to get
a proxy server that needs a password or not. The username
and password are user/1234.

Fixes: QTCREATORBUG-29485
Change-Id: I3859c9ad04ebd4f9349e25665ba710e23fb64dea
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-08-16 06:54:54 +00:00
Christian Stenger
91596316f2 WinPty: Fix qbs build on Windows
Change-Id: I993fa3c8d9bc364c00e9e9eedba021a7432d908f
Reviewed-by: hjk <hjk@qt.io>
2023-08-16 06:49:48 +00:00
hjk
f53e18ee73 Test: Avoid some Id::withSuffix calls
Saves cycles and is arguably clearer.

Change-Id: Ib53207704806d4b6ea184633a15ab98fb2eeb89a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-08-16 06:06:55 +00:00
Tim Jenssen
91a931dd21 QmlDesigner: build it only if Qt is GREATER_EQUAL 6.4.3
Change-Id: Iccd05a7d4f4ace47fd9398bdc78584e3919ec595
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-08-15 18:57:48 +00:00
hjk
0690b65abc LanguageServer: Compile fix for Qt 6.2
QLatin1StringView ist ein alias fuer QLatin1String, aber erst ab 6.4

Change-Id: I9b04d39722bf2707c327c6596a4bfe9ee719bae8
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-08-15 16:04:47 +00:00
Marco Bubke
007467898b QmlDesigner: Fix crash for missing null pointer check
Change-Id: I49e971ee9037847dcaa591e98fa8933cff162658
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-08-15 15:46:39 +00:00
Marco Bubke
f4492f567b QmlDesigner: Fix qml file name filter
Change-Id: I40b40a4c6235566830510b244752ec120759f500
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-08-15 15:19:26 +00:00
Marco Bubke
c24ae64411 QmlDesigner: Remove useless semicolon
Change-Id: I3b829ac7a050dfaf1f0ea75e9bef68155930bf60
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-08-15 15:15:39 +00:00
Ali Kianian
0f9a6a2ccc QmlDesigner: Use Designer icons for 3d view toolbar
Designer Icons are updated for the toolbar usage.
Disabled colors are changed for the View 3D toolbar.

Task-number: QDS-10044
Change-Id: I98e7e43d39af4d57a1527fd1a9600c964e49114c
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-08-15 13:56:10 +00:00
Ali Kianian
86d4fbab79 QmlDesigner: Import only mandatory libraries or directories
Only mandatory files are imported by the newly created component.
In the case that the import data is empty, All parent imports would be
included.

Task-number: QDS-9829
Change-Id: Ie96e2bc04a10e00b15ae12c5e58b5dc2392886ae
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-08-15 13:55:49 +00:00
hjk
5aa138bb68 ProjectExplorer: Hide some KitAspectFactory implementations
Change-Id: If84dd7aeb72e87d2cb35635689ad1c9c2e09a825
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-08-15 13:49:59 +00:00
Mahmoud Badri
e2f5b37fce QmlDesigner: Add 3 icons to the icon font
added icons: help, drag marks, and code.

Fixes: QDS-10459
Change-Id: I87c7e28d8858e49c98a4e9e2d991ee5d87df5a23
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-08-15 13:44:09 +00:00
Marcus Tillmanns
02e2a642dc ProcessStub: Add missing if
When not starting in debug mode, the inferior is not waiting
for ptrace(DETACH), so the code that calls DETACH waits for
something that does not happen.

Fixes: QTCREATORBUG-29503
Change-Id: Ic00a52b9e4f3a797d1be337a2ce53afc6ee63927
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-08-15 13:32:45 +00:00
Marcus Tillmanns
013b71b301 Utils: Allow cascaded aspect "setEnabler"
Change-Id: I4e519c0ef27460b42c4e44a755e5e6cbbf49ebdf
Reviewed-by: hjk <hjk@qt.io>
2023-08-15 13:30:06 +00:00
Marcus Tillmanns
bc1ab260b4 Utils: Add password input dialog
Task-number: QTCREATORBUG-29485
Change-Id: I2b55e7d39f848f1c89d3a365a2cadd44e8aac97c
Reviewed-by: hjk <hjk@qt.io>
2023-08-15 13:17:19 +00:00
Mahmoud Badri
bf6ea8496a QmlDesigner: Refactor Effect maker nodes view
Also add node click handler

Change-Id: I4b4e327f5c69f27d64ef2f2c3d13628aea46f0af
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-08-15 13:08:33 +00:00
hjk
123793fbb1 Utils: Add an 'If' LayoutItem
Change-Id: I700e28d03b6dc39e96fa969152f236760989bdb7
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-08-15 13:03:11 +00:00
Marcus Tillmanns
b0d5e44235 Utils: Add Password display to StringAspect
Task-number: QTCREATORBUG-29485
Change-Id: I8da46be4c63f97595aa1e93b6ac4905bdbb54799
Reviewed-by: hjk <hjk@qt.io>
2023-08-15 13:02:31 +00:00
hjk
876d9fb1e0 ProjectExplorer: Separate KitAspectFactory storage from live kits
Change-Id: Ic4d4f4938a11e209c31dcba73d1a793d359fe135
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-08-15 12:54:05 +00:00
Jarek Kobus
d6068c3ce5 TaskTree: Make TreeStorage final
Allow TreeStorageBase to be subclasses only by TreeStorage.

Change-Id: I6e119d6b6f2f99cc7846752cf55f9fb92f3834c7
Reviewed-by: hjk <hjk@qt.io>
2023-08-15 12:46:46 +00:00
Tim Jenssen
8812c1816b Merge remote-tracking branch 'origin/11.0' into qds/dev
Change-Id: I23063e42621b272bd4b04a06746955e6b5768b49
2023-08-15 12:32:47 +00:00
Marco Bubke
a7987380cd QmlDesigner: Silence bogus warning by Clang
The parens are needed by the fold expression.

Change-Id: Ib53596f2be2f3bcdb6040c1690f5f6dfe6249583
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2023-08-15 12:31:00 +00:00
Mehdi Salem
10feedf9de Axivion: integrate generated DTOs
We are not yet making use of the integrated DTOs as this will happen
in a future commit along with the network requests to fetch the data.

Change-Id: I72cf9005cae052c41a7e906e0fae5dbe176e0882
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Andreas Loth <andreas.loth@qt.io>
2023-08-15 11:35:02 +00:00
Marcus Tillmanns
5ae116618e Tracing: Remove useless code
runSceneGraphTest() did nothing but create an opengl context and
offscreen surface. It did nothing with the provided QSGNode.
The only thing it does is make the test fail if the opengl context
can't be created for instance on test machines without opengl.

Change-Id: I376c3565f5afcee6e123a7ef8b9832e679e645a0
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2023-08-15 11:04:36 +00:00
hjk
9b18e73fac Utils: Switch FileIconProviderImplementation::icon() overloads
The FilePath based one seems to be called primarily, so make that
the primary implementation, saving a FilePath <-> QFileInfo round trip.

Change-Id: Ib3427a5168e559b8a583570ac1c82dfe658644da
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-08-15 10:52:16 +00:00
Marcus Tillmanns
324e924178 Utils: Fix FilePath::isRootPath()
Change-Id: I287bae74469ba501ecb03d51f04f7aaa5f4a7268
Reviewed-by: hjk <hjk@qt.io>
2023-08-15 10:50:24 +00:00
David Schulz
01cac8299b ProjectExplorer: fix Interpreter::changed emits
Only emit changed if the current interpreter changes.
This is more in line with the other aspects.

This fixes the pyside detection since the changed signal was not
emitted in all relevant code paths.

Change-Id: I53409b17f260b35914e39de894b48d7bd1ce27c0
Reviewed-by: hjk <hjk@qt.io>
2023-08-15 10:44:53 +00:00
Jarek Kobus
b8acef5d8c AndroidManager: Rename runAdbCommandDetached() into startAdbProcess()
The process wasn't started detached in fact.

Change-Id: I60aee6d4de3be2499727ea43c3492c1c478f5e94
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-15 10:40:21 +00:00
Artem Sokolovskii
b01fcf5e7a DAP: Add enable/disable breakpoint support
Change-Id: Ice1c17e1c1e257d9f828bb6a54c643f7ecf7b387
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-15 10:23:16 +00:00
Henning Gruendl
c7d2b9bec1 ADS: Fix potential crash
Base repository commit
7a362b7ee3048ecee521ad4ba51647bc8a98193e

Change-Id: Id888b92b3738136a534ae7758f585f915777b07d
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-08-15 10:19:22 +00:00
Jarek Kobus
ae51dedbd1 AndroidManager: Remove deleteOnFinish arg from runAdbCommandDetached()
Change-Id: I6a54c85921e27a2256417f730f56c41b1152fefc
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-08-15 10:02:23 +00:00
hjk
6ee7989c61 KitManager: Move the instance setup to a function
Slightly nicer code and works well with settingspages nowadays.

Change-Id: Ic12ff58f4b0f8db226843961eb2ab6fb8879429c
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-08-15 09:54:18 +00:00
Yasser Grimes
8f948c28a9 McuSuport: Use qsTrId() instead of qsTr in QtMCUs templates
Task-number: QTCREATORBUG-29258
Change-Id: I0e386b12308b04df0e2ca023d77c01a8d481b9a5
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Sivert Krøvel <sivert.krovel@qt.io>
2023-08-15 09:47:58 +00:00
hjk
4cb6858410 Meson: Remove unused header file
Change-Id: Iff0793eef63094b5ab680c436963e77c92f278c8
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-15 09:33:59 +00:00
hjk
86979b682d ProjectExplorer: Rename a few KitAspect related items
Mostly local variables and KitManager::kitAspectFactories() to
match closer what they are.

Change-Id: I8f837357528f9e1110888898077f82b5097003f0
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-08-15 09:00:02 +00:00
hjk
aa25fdcc69 QtSupport: Rename qtkitinformation.{h,cpp} -> qtkitaspect.{h,cpp}
Change-Id: I12229e5e98b468101d32edd35be74bbda0921d89
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-08-15 08:59:52 +00:00
Jarek Kobus
c82f06d834 Utils: Drop unneeded Q_OBJECT macros from public headers
Change-Id: Ia495397179dc8fd1308bac982d5fb27903444884
Reviewed-by: hjk <hjk@qt.io>
2023-08-15 08:35:58 +00:00
hjk
017d7c0e47 ProjectExplorer: Rename kitinformation.{h,cpp} to kitaspects.{h,cpp}
Change-Id: I069bddeb457366210d339edcbb8ffb359a40fab8
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-08-15 07:31:03 +00:00
hjk
9a69c20c40 ProjectExplorer: Hide filtered items on TargetSetupPage
Instead of destroying/recreating them.

Fixes: QTCREATORBUG-29494
Change-Id: I70e673bf2fb72c0ed31248c6ea18b1fb1a8f30a8
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-08-15 07:11:43 +00:00
hjk
e2a370f280 LSP: Use 8-bit keys in Json wrapper
Sufficient, smaller, faster.

Change-Id: I0d740785109538e04fc674c11d578ded8d2815fb
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-08-15 07:11:31 +00:00
hjk
1818236b2b Utils/QmlJS: Move contents of utils/json.{h,cpp} to qmljs
This is a special version of JSON only used in the QmlJSEditor,
demote it accordingly.

Change-Id: Id21ea16c022fb8554d87e9ba90c3494978e4cd80
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-15 07:11:07 +00:00
hjk
576769e54c ProjectExplorer: Fully pimpl TargetSetupPage
Just re-organization relate to, but not a fix for the linked issue.

Task-number: QTCREATORBUG-29494
Change-Id: I0c5413b2dc97738a03b737e764194c4d90d3f086
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-08-15 07:10:14 +00:00
hjk
1748ce6822 Utils: Reduce default indent for navigation tree levels
Further, from 90% to 70%.

Change-Id: Ief5407933a43b1fcdf906e431221dc664ae78d28
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-15 06:40:12 +00:00
Marco Bubke
aa39093a3f QmlDesigner: Simplify and optimize property getter
So far we create all AbtractProperties and then filter and cast them. So
we throw most of them away.

Now we filter before we create them and we create directly the type we
want.

Change-Id: Ic1b32e11f2b934edfcf890e27de323af38051784
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-14 14:53:16 +00:00
Marco Bubke
1b6f9db8e6 QmlDesigner: Use view instead of values
In the case of the has and remove functions we don't need the value. If
we use views we can use const expressions.

We have to change from QHash to std::map because QHash can not handle
different types for the find function.

The patch is removing a double lookup too.

Change-Id: I89bb942d7948127344d230ee61ac166102354ccb
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2023-08-14 14:53:10 +00:00
Marco Bubke
bdd076efcd QmlDesigner: Improve Model
Make node collection a little bit more explicit. Before we created,
copied and destroyed node lists. Now we send a list
around where we add nodes.

Use raw pointer for properties. Properties are used as internal pointer
plus the property name. The repesentation as an shared pointer is a
implementation detail and could be removed in the future.

Use raw pointer for internal nodes if we don't handle ownership but only
access member.

Remove double checks for properties. One lookup is better than two or
three.

Change-Id: If162f365db3e8869cbc19913abfc44d57c2d8324
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2023-08-14 14:53:02 +00:00
Jarek Kobus
5bce234986 Valgrind: Refactor Parser
Make it implicitly threaded.

Get rid of ThreadedParser.

Don't move QTcpSocket instances, received by
QTcpServer::nextPendingConnection(), into another thread,
as docs says it's not safe.

Use wait condition for waiting for new data.

Don't potentially leak the Parser in loadXmlLogFile():
store a unique pointer to the running parser.

Introduce Parser::setData() method and use it with
QFile device in loadXmlLogFile().

Pass QAbstractSocket into the parser instead of
QIODevice and get rid of downcasting. The QIODevice
couldn't really work with non-socket and non-file devices
(like e.g. QProcess), as it lacks general error and finished
reporting signals (it has only general readyRead() signal).

Change-Id: I9352aec694564d4d2a26898841ed964bed470d82
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-08-14 14:42:16 +00:00