Commit Graph

68765 Commits

Author SHA1 Message Date
hjk
578ecfc846 SdkTool: Don't destroy :// parts in qmake paths
Change-Id: I1b8fef656550b7d2e59e6a606728d0f3e85d5af2
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-08-09 11:32:57 +00:00
Jarek Kobus
fe1aeb3057 EasingCurve: Avoid iterating double
Iterate int instead. Store the x() value of QPointF,
instead of storing the whold QPointF instance.

Change-Id: I8c19eaa81cd60c4a164392afd5429ad9a2d222bd
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Knud Dollereder <knud.dollereder@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-08-09 10:21:33 +00:00
hjk
4b4cbd142c Debugger: Rename main option page to DebuggerSettingsPage
That's the page in the 'Kits' category.

Also, move code to the canonical place at the end of the file
and self-register the factory at plugin load.

Change-Id: I6bdf7288a6a475447ea8a5a57b9118d49831a7b2
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-08-09 09:52:48 +00:00
Marcus Tillmanns
1ca8487e91 Utils: Fix for invalid docker paths from installer
Some installers wrote "docker:/" into the settings instead of
"docker://". This adds a workaround for that.

Fixes: QTCREATORBUG-29474
Change-Id: I49a69d6fa9e4fe383257313e534660814c4a011f
Reviewed-by: hjk <hjk@qt.io>
2023-08-09 09:49:57 +00:00
Cristian Adam
6528bd3eed CMakePM: Find the right AUTOUIC generated header
Amends c4e15769ec

When using ui files in static libraries AUTOUIC reports fake header file
names.

By using the target that includes the source ui file we can find the
correct header file name.

Change-Id: I1c8e0b81ad2c670be87c3620f98bd0f5cce40cd1
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-08-09 09:48:27 +00:00
hjk
9f1c99cb98 Debugger: Call DebuggerItemManager::restoreDebuggers() more directly
Change-Id: I77a293a8754e2aa3dd521e0810006c5f10ae23ff
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-08-09 08:59:28 +00:00
Christian Kandeler
048f77b961 CppEditor: Let users specify a preferred doxygen command prefix
Fixes: QTCREATORBUG-8096
Change-Id: I08bf4e3e0092fc775b50be6e5f4cefb9ed6979a5
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-08-09 08:42:15 +00:00
hjk
aa5b3b670e Beautifier: Rename settingspage classes
*SettingsPage is the predominant name.

Also move the code to the canonical location at the end of the file.

Change-Id: Ib8e0d1f7a87576c4fd8019896102907c77c30f2f
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-08-09 07:22:34 +00:00
hjk
2c353c37ea Utils: Base AspectContainer on BaseAspect
Change-Id: I78b11727af6e465da5731ba36bbae476d11d11ee
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-08-09 06:59:01 +00:00
David Schulz
fbb9946331 Copilot: avoid crash on misconfigured agent
When setting up a wrong or unusable agent.js the client used inside the
AuthWidget get's deleted eventually. In that case we need to reset the
tracked client otherwise we use a pointer to the deleted client in the
destructor of AuthWidget.

Change-Id: Ide4067c01cdcd05a33d44bc9460acfe9a56c7815
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
2023-08-09 04:20:55 +00:00
hjk
5a9cc840d5 Perforce: Allow delay-created settings
... in theory. The first argument of the connect() call in
perforceplugin.cpp:555 currently spoils the fun.

Change-Id: I041c7707264d8ba64098c37f8fbb5ee4ea1e1753
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-08-08 16:53:42 +00:00
hjk
130f92c4d9 VcsBase: Remove a few now unnecessary Q_OBJECT uses
Change-Id: I41d50e437b3bcfb964d2ef27541ea6a55855ec2f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-08-08 16:34:46 +00:00
Jarek Kobus
f573af5f69 Valgrind: Split parse() into setIODevice() and start()
Make the API more TaskTree friendly.

Change-Id: I5119e38b5fc3cce234395fc5db5c73cf0c474ac0
Reviewed-by: hjk <hjk@qt.io>
2023-08-08 16:23:44 +00:00
Jarek Kobus
0a320185dc Valgrind: Merge parsers' finished() and internalError() signals
Replace them with done() signal.

Change-Id: I5f03df927ddefd803d9cb0b06d3f4c1601a15381
Reviewed-by: hjk <hjk@qt.io>
2023-08-08 16:23:39 +00:00
Burak Hancerli
eb13b7274d QmlProjectManager: Fix a crash while accessing an uninitialized aspect
Task-number: QDS-8145
Change-Id: I1ee9688a2ae860291878c64305cb5e6b2e0df277
Reviewed-by: hjk <hjk@qt.io>
2023-08-08 16:07:43 +00:00
Jarek Kobus
3970a834bc Valgrind: Replace global toolTipForFrame() with Frame::toolTip()
Change-Id: I66cc481d588c468b9388e3b3863ed35aab406fa2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-08-08 15:10:47 +00:00
hjk
bb6c26cac9 QtSuppoer: De-O_OBJECT-ify QScxmlGenerator
Change-Id: I2732aaf838144d6da4c0b51bdfc2c8bb6cc8e21b
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-08-08 14:30:17 +00:00
Artem Sokolovskii
1836b50f5d DAP: Separate CMake and Gdb logic in DAP engine
This commit refactors the Debug Adapter Protocol (DAP) engine
to separate the logic for CMake-based projects and Gdb-based
debugging.

- Moved CMake-specific code to a new CMakeDAPEngine class
- Moved Gdb-specific code to a new GdbDAPEngine class

Change-Id: Ia616e7b7ea2ff2071bcadd26b28b620f9aca6ac4
Reviewed-by: hjk <hjk@qt.io>
2023-08-08 14:15:30 +00:00
Artem Sokolovskii
8fcf3a695f DAP: Fix windows support
- Added using named pipe for windows

Change-Id: I45561481d63c5dd81bda14e6ace4fb0374d1b488
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-08-08 13:20:14 +00:00
hjk
f3e1aece83 QtSupport: De-Q_OBJECT-ify UicGenerator
Change-Id: I6934fc1553b2f32e042aef0c8a0141fee93a52cd
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-08-08 13:20:06 +00:00
Marcus Tillmanns
31f7ed44b6 FilePath: Use isSameDevice
Some places compared the scheme and host of a filepath to
decide whether its the same device. This is incorrect and
leads to false negatives. isSameDevice is the correct way
to decide whether two paths are from the same device.

Fixes: QTCREATORBUG-29474
Change-Id: Iced8f434dadb931f6595f47f95647b341c48d3aa
Reviewed-by: hjk <hjk@qt.io>
2023-08-08 13:19:35 +00:00
Christian Kandeler
b92ac9a941 TextEditor: Introduce a per-project variant of the comments settings
These settings can clearly differ per project.
Note that the classes have to live in the ProjectExplorer plugin, which
has a (questionable) dependency on TextEditor.

Change-Id: I7e3816da30cecd1ccb66549a2226b44dc0a26cb4
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-08-08 12:50:58 +00:00
Jarek Kobus
468a08bb2b DirectoryFilter: Set future synchronizer for the async recipe task
Change-Id: I2c337f35b818e4c1748e34a2479dc21f66bd50de
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-08-08 12:50:55 +00:00
hjk
f65b343c8a Utils: Allow (encoded) colons in host parts of FilePath
Change-Id: I6acd8ac8ab44cb895cc08ce6b1972802f79a2a53
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-08-08 12:16:32 +00:00
hjk
f09b61651e Utils: Approach aspect update signalling more systematicly
This was pretty much ad-hoc so far. Now do the actual value proliferation
inside the aspect first and collect information on what changed. Signal
changes in the end centrally. At that time the aspect internal state is
consistent again.

Additional design desision implemented here: setDefaultValue and
fromMap/readSetting do _not_ signal, user code with unusual needs
has to check on its own.

Change-Id: I1e46282558e014f51933d1044a72bf5c67437ec5
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-08 12:06:16 +00:00
hjk
d7d7b4bbca Terminal: Compile with Qt 6.2.x
Change-Id: Id98d6073205b2d40fe114e66e2bac65e1a628cdc
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Mehdi Salem
2023-08-08 12:05:34 +00:00
Christian Kandeler
45f4ea6da5 CppEditor: Pass CommentsSettings into DoxygenGenerator
... instead of forwarding each member separately.

Change-Id: I0639cc81716df70e8f286cb4b5f02554e1f56b95
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-08-08 11:58:35 +00:00
Amr Essam
64377d9e0c QmlDesigner: Implement effect maker view
Initial basic logic for a view and simple functionality to be extended.
The view is hidden by default during development and enabled via an env var.

Task-number: QDS-10401
Change-Id: I5c2e1e20aca6c53c1ed273136ee6204145f15def
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Amr Elsayed <amr.elsayed@qt.io>
2023-08-08 11:56:31 +00:00
Miikka Heikkinen
a05ba1696f QmlDesigner: Fix orthographic camera zoom
Scale no longer affects cameras, so use magnification instead to do
orthographic camera zooming.

Fixes: QDS-10241
Change-Id: Ic31abfdf741369a494b8178109fa1c5b95fbdd1c
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-08-08 11:27:54 +00:00
Christian Kandeler
68c76e072d CppEditor: De-obfuscate DoxygenGenerator
- m_startComment was always false.
- One of the two public generate() functions is an internal helper.

Change-Id: I03a860bf7f44aab8f98c5656bc2b36f9fe5e1ef2
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-08-08 10:50:38 +00:00
Jarek Kobus
c6587de684 QmlProjectManager: Get rid of foreach
Change-Id: Iab2933ac8cf06c81d667ab94a26b86241a3a0c24
Reviewed-by: Burak Hancerli <burak.hancerli@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-08 10:03:17 +00:00
Artem Sokolovskii
8b0b190b49 DAP: Fix breakpoint behavior
Before adding and removing breakpoints when debugging is running
didn't work for cmake debugging. Fixes that.

Change-Id: I59fd4ec3905365647b552753bc06da855e83ac7c
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-08 09:39:26 +00:00
Jarek Kobus
7e572841f7 Valgrind: Make tool name hash static
Change-Id: I326c45e1be293dc5066271839b26b7f22d53eabb
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-08 09:28:43 +00:00
Jarek Kobus
fbb06f1a02 ToolChain: Introduce asGccToolChain()
Instead of downcasting by qobject_cast.

Change-Id: If868a41eb6233e18e0ea96441001fe02b5f3090e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-08-08 09:24:33 +00:00
Jarek Kobus
ec53435e04 ThreadedParser: Simplify implementation
Get rid of unused errorString().
Remove pimpl and keep the QPointer to the Thread.

Change-Id: I6398d35b4df17b548ff06185fe516d0d19ed9bc0
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-08 09:24:26 +00:00
Jarek Kobus
94f4c21740 ValgrindMemcheckParserTest: Fix const correctness
Simplify list c'tors.

Change-Id: Ib2534acfda1e0b24d8cfd10c7f48b585c881929a
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-08 09:23:32 +00:00
Jarek Kobus
fbf9325395 ValgrindPlugin: Use QList instead of QVector
Change-Id: Ib1bd223b73d1f7399008f91a3c26ff515ab03a0c
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-08 09:23:25 +00:00
Jarek Kobus
00a34e60fc Valgrind test: Hide Recorder and Dumper in cpp file
Inline Recorder's and Dumper's slots.
Clean some namespace specifiers.

Change-Id: I1111e8fb3c912dc1f253ebb2ed7f8e9c3fff67e0
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-08-08 09:23:15 +00:00
Jarek Kobus
91f01c17f9 ValgrindRunner: Hide ThreadedParser
Expose its signals instead.

Change-Id: I0daeb2e510c30678f4f13d880bc8108510c4f32e
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-08 09:23:08 +00:00
Jarek Kobus
43dca6ec78 ThreadedParser: Remove unused signals
Change-Id: Ib158902f9d433cc48bdba58aa6b685aa7d41f5b4
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
2023-08-08 09:22:57 +00:00
Jarek Kobus
4e56305a01 MemcheckToolRunner: Remove unused suppressionCount() signal
Change-Id: I887f4bf9f373da07389e84bf62829a17debc103d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
2023-08-08 09:22:49 +00:00
Christian Kandeler
099fe7d5d1 CppEditor: Let users fold/unfold all comment blocks
Fixes: QTCREATORBUG-2449
Change-Id: Ib090f1bb0d0866f14ddb6dfb10bf2ff2563585e0
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-08-08 08:52:55 +00:00
Christian Kandeler
f93836b25d CppEditor: Add quickfix for converting comments from C++ to C style
... and vice versa.

Fixes: QTCREATORBUG-27501
Change-Id: I8584cc1e86718b3fe0f0ead2a3436495303ca3c8
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-08-08 07:33:41 +00:00
The Qt Project
d201899a0a Merge "Merge remote-tracking branch 'origin/11.0'" 2023-08-08 06:35:47 +00:00
Marcus Tillmanns
7a8c4adf95 Utils: Don't complain about non-existing devices
FilePath::exists() does not need to warn if the device does not exist.

Change-Id: I2ce6a5dec8806a8ee0a2f0e53a2c556c1d8c9e5b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-08-08 06:29:39 +00:00
David Schulz
0ece08c9dc Merge remote-tracking branch 'origin/11.0'
Change-Id: Iad820911996f8daff6ce63b4f0267bd15d35d176
2023-08-08 07:34:26 +02:00
Jarek Kobus
33d628f111 PerfParser: Update the tool
Change-Id: Ie79c28b39f62af91843106bc1e312d6be27ba9cf
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-08-07 12:26:34 +00:00
hjk
cb6a5f6119 Ios: Merge settings page related file pairs [2/2]
Rename *settingswidget* into *settingspage*.

Change-Id: Ib635ed0dc8b7d2bf3979977e89206b194b116d47
Reviewed-by: hjk <hjk@qt.io>
2023-08-07 09:55:04 +00:00
Christian Kandeler
e421ca97a1 TextEditor: Introduce dedicated comments settings page
We will soon add more comments settings.

Change-Id: I91798b9d1071acefda70db523dcc72fdc2480cd7
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-08-07 08:38:59 +00:00
hjk
68fbfe671c Ios: Merge settings page related file pairs [1/2]
Move all to *widget.cpp, to keep the diff small.

Will be renamed in step #2 to *page.cpp again.

Change-Id: I391e4c823d796f5af0970067642e1b3eaec2637e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-08-07 08:38:07 +00:00