Commit Graph

68765 Commits

Author SHA1 Message Date
Alessandro Portale
4605bf57dd CMakeProjectManager: Deselect "Stage for installation" for BareMetal
There is no CMake install target for BareMetal. Therefore, the "Stage
for installation" option needs to be deseleceted, like it is being done
for other devices.

Amends: 2387e9e37a

Fixes: QTCREATORBUG-29293
Change-Id: Ic0e61ab19318f6383f55e6330b7559a734706a0e
Reviewed-by: hjk <hjk@qt.io>
2023-08-14 14:41:35 +00:00
Alessandro Portale
6f9a97fd13 CMakeProjectManager: Deselect "Stage for installation" for iOS Simulator
There is no CMake install target for iOS Simulator. Therefore, the
"Stage for installation" option needs to be deseleceted, like it is
being done for iOS device.

Amends: 2387e9e37a

Fixes: QTCREATORBUG-29293
Fixes: QTCREATORBUG-29475
Change-Id: I6406446534c1ddedbf01cdab4d074bddc44dc495
Reviewed-by: hjk <hjk@qt.io>
2023-08-14 14:41:28 +00:00
Artem Sokolovskii
3ab2da691d DAP: Add check that cmake 3.27 or higher
If CMake version is lower then 3.27
- Shows the warning in general message
- Starts CMake without debugging
- Stops debugging correctly

Change-Id: Ibb13555c20ae2961c0a3c2ef6ec0fcc25930dddc
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-14 13:41:39 +00:00
Amr Essam
a4fbbb2463 QmlDesigner: Create effect node entity members
The EffectNode entity members and initial implementation for loading effect resources

Task-number: QDS-10402
Change-Id: I36913731f15fdc89e7bbaa1a7b40088a817e3086
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-08-14 13:34:44 +00:00
Artem Sokolovskii
83d2ee56b7 DAP: Add run to line support
Note:
"Run to line" feature is disabled for CMake.

Change-Id: If8dc271fe51c6e5695f2544a71be544c7575bfa9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-08-14 12:16:36 +00:00
Artem Sokolovskii
888e7e0c6d DAP: Add select thread support
Change-Id: Ib85d7d4413284d5919a2b19016aec503c9cb5fca
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-08-14 12:16:31 +00:00
Artem Sokolovskii
8b1047aa8f DAP: Refactor dap responses handling
Change-Id: Iebc16d7e497b4f3a1deec6f52f7b89815c2cde3b
Reviewed-by: hjk <hjk@qt.io>
2023-08-14 09:58:11 +00:00
Mahmoud Badri
56303d62a6 QmlDesigner: Load effect maker nodes' icons
Also remove some unused code.

Fixes: QDS-10426
Change-Id: I71c4fde339261e2856472c15bde56ee8850ed236
Reviewed-by: Amr Elsayed <amr.elsayed@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-08-14 09:15:27 +00:00
Miikka Heikkinen
46800c6f97 QmlDesigner: Improve helper grid handling in 3D edit view
Changed the grid spacing to depend on view distance rather than
zoom factor, making it more understandable. Also it now takes into
account the distance of the lookat point from the grid plane to improve
spacing when focusing objects far away from the grid plane.

Simplified the logic on how subdivision alpha is calculated, making
it more flexible in case we want to allow configurable grid spacing.

Also, now the grid steps are bit more sensible numbers, i.e. multiples
of 50 instead of multiples of 55.

Change-Id: I37bcdb9469273b3ac8981519182096aa789d5b77
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-08-11 14:12:13 +00:00
David Schulz
7bb49b58df Core: fix IDocuments aboutToSave and saved filePath
The function emiting those signals can be called with an empty file
path. Use the document file path in this case like in
TextDocument::saveImpl.

Change-Id: I9e3381999a25c49df1d5db060ef5467b12220ad4
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-08-11 14:08:04 +00:00
Miikka Heikkinen
b4db8a2d84 QmlDesigner: Enable shader caching in puppet
When shaders are cached in addition to pipeline caching, further
speedup of another 20% or so is achieved on resetting puppets in
complex 3D projects.

Task-number: QTBUG-103802
Change-Id: I55c950b14c7d854ca3b4de40558ecd26889aa134
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-08-11 13:32:37 +00:00
Mahmoud Badri
f90755c6dc Only add .qen to the effect maker nodes model
Also capitalize first letter of category name.

Change-Id: I1a86a27d98a4cf666c0b748193eb093061ad2a3c
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-08-11 13:29:40 +00:00
David Schulz
28754ba08a LanguageClient: fix showing obsolete proposals
When receiving a null proposal and the processor is not running after
updating a proposal we need to make sure the previous visible proposal
widget gets closed.

Change-Id: Icb0a7293698e603df3ba8cab34a08c10fe6784da
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-08-11 12:38:08 +00:00
Mahmoud Badri
dcbab3b5dd QmlDesigner: Load effect maker nodes from path
...instead of from Qt SDK

Change-Id: I10d3104477b7cd7c729121175c66a7402ea49651
Reviewed-by: Amr Elsayed <amr.elsayed@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-08-11 12:06:14 +00:00
Mahmoud Badri
6e2c62776b QmlDesigner: Implement effect maker nodes popup and load data in it
Change-Id: I95625f2eaf8aac71679b2f816dd20a9167849830
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-08-11 10:13:04 +00:00
hjk
658db809ef ProjectExplorer: Remove Q_OBJECT from KitAspectFactories
None of the functionality it provides is actively used.

The QObject inheritance itself is left as the factories act as
guard objects in some connections.

Change-Id: Ia6f2707a3a0a4e2810acdb4dd566afee855468b4
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-08-11 09:49:30 +00:00
hjk
605e23a3ce McuSupport: Rename some of the KitAspect related classes
... and split out the static interface.

Change-Id: I5f9e3ed1e0c75fe26fa843858014070cb6cc0e6f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-08-11 09:46:46 +00:00
Artem Sokolovskii
a7fcb71b90 ClangFormat: Add warning for clangformat version
Added warning when current clangformat major version does not
match with version what checks was generated for.

Change-Id: I818c9a4f79385cba4e492ea5428bb051f329a9d4
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-08-11 08:40:01 +00:00
hjk
3e9886bd90 QtSupport: Rename some of the KitAspect related classes
... and split out the static interface.

Change-Id: I5fdd851bd230a062440be6be9a4bf1fce4f00861
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-08-11 07:01:02 +00:00
hjk
1fa67e1c67 Qbs: Rename some of the KitAspect related classes
... and split out the static interface.

Change-Id: I62d2a188e75bbc3e3d912c3ebf0c4300bec9fb79
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-11 07:00:55 +00:00
hjk
bb06155f09 Meson: Rename some of the KitAspect related classes
... and split out the static interface.

Change-Id: Iaa92ab8e0b29e47736af6c2b5ed146369f2d7294
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-08-11 07:00:43 +00:00
hjk
e9266f53ec CMakeProjectManager: Rename some of the KitAspect related classes
... and split out the static interface.

Change-Id: I28cdb2765a00d1bd19790f46a3b2b0da8690e929
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-11 07:00:37 +00:00
hjk
329541a42c ProjectExplorer: Rename some of the KitAspect related classes
... and split out the static interface.

Change-Id: I0a1bb1c2fa71fa41fe54a3cbedd69f5a8f73713b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-08-11 07:00:28 +00:00
hjk
cde3156050 Qmake: Rename some of the KitAspect related classes
... and split out the static interface.

Change-Id: I9767c858a850b1fe16c97acc4848e8f69ae3342e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-08-11 07:00:15 +00:00
Christian Kandeler
74a0313fcf CPlusPlus: Support associating comments with a declaration
This will serve as the basic building block for several comment-related
features.

Task-number: QTCREATORBUG-6934
Task-number: QTCREATORBUG-12051
Task-number: QTCREATORBUG-13877
Change-Id: Ic68587c0d7985dc731da9f539884590fcec764de
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-08-10 14:26:27 +00:00
Christian Kandeler
66a6cceaf4 CppEditor: Fix possible null pointer access
Fixes: QTCREATORBUG-29484
Change-Id: I047ea13e6808902a3b0fb94b9eacdd48e411a22a
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-08-10 13:48:39 +00:00
David Schulz
b128c585d9 TextEditor: render suggestion with the tab width of the editor
Fixes: QTCREATORBUG-29483
Change-Id: Id8da019130055ce40bd639d038eb1e74d9787884
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-08-10 13:37:33 +00:00
hjk
0a3aad0093 Debugger: Name KitAspect related classes more similar to their bases
Change-Id: I2f18f382ccedfde343c72f8a9562f900faa43756
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-08-10 13:03:27 +00:00
hjk
fde372b81e ProjectExplorer: Rename KitAspect related classes
KitAspect -> KitAspectFactory
KitAspectWidget -> KitAspect

KitAspect::createConfigWidget() -> KitAspectFactory::createKitAspect()

Possibly not perfect yet, but closer to what it does and is.

There will be follow-ups to rename derived classes.

Change-Id: I226f6f025f1e6462c348b68663f776f5a2e8c42d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-08-10 13:03:21 +00:00
Christian Kandeler
88dc7cf7e0 Debugger: Fix qbs build
Change-Id: I660bfd4053ef52881c9a64f1492631819321d2c1
Reviewed-by: hjk <hjk@qt.io>
2023-08-10 12:31:18 +00:00
Christian Kandeler
b3c7e3abd6 Valgrind: Fix build
Amends ec53435e04.

Change-Id: Iaee2b355a98bf92c94bd66a8a615befec08b11c3
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-08-10 12:31:05 +00:00
hjk
3ad1a6ecdd Revert "Utils: Allow (encoded) colons in host parts of FilePath"
This reverts commit f65b343c8a.

It's not needed anymore for the problem it was supposed to help with
(bad docker imange/qmake paths written by sdktool) and complicates
reasoning in this area.

Change-Id: Idef2ef9147d73e83461589907aa68c09721755cb
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-08-10 10:36:03 +00:00
hjk
256ee1c05a Perforce: Inline PerforcePluginPrivate::applySettings
... into its only user, hope is to move it into the settings proper
at some time.

Change-Id: I5877e7e19f4c3ef0ad5dba2761b12545ab59a1e8
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-08-10 09:25:54 +00:00
David Schulz
d2434d90dc ProjectExplorer: prefer git ssh over windows ssh
In contrast to the git provided ssh the current ssh provided in windows
ignores the SSH_ASKPASS environment variable. So we should prefer the
implementation of git. This was done correctly in previous versions of
Qt Creator since Environment::searchInPath first went through the
additional provided directories before looking into the PATH environment
variable. This behavior changed in 11.0 and now we look first into the
entries of PATH.

Change-Id: I4f3c21866d2d1a5151998fd527978ed482946ef8
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-08-10 08:42:25 +00:00
Christian Kandeler
9fc53ef745 RemoteLinux: Do not reject sftp deployment when no info is available
We would set up a non-working deploy configuration for devices that
existed before 11.0.
Amends 3cd0dad3d4.

Change-Id: If9d79207c9781e158635e35e211c0071109101db
Reviewed-by: hjk <hjk@qt.io>
2023-08-10 08:22:30 +00:00
Jarek Kobus
bce2dde117 Valgrind test: Use Utils::Process instead of QProcess
Change-Id: Id7a0611fd7d36adc22993f50cce87cd30c6a336c
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-10 08:19:33 +00:00
Marcus Tillmanns
f13d9cc736 ProcessStub: Wait for detach to finish
Without calling waitpid() after detaching from the inferior
a race condition could occur where the ptrace(...) call would
finish before it was actually detached, leading to the following
gdb to fail attaching as the stub was still attached to it.

Calling waitpid here solves the race condition.

Fixes: QTCREATORBUG-29463
Change-Id: Ia1d79a18a96078bbf72589bebbc7d7ac027dea0d
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-10 08:14:29 +00:00
hjk
0be0772fc9 Merge remote-tracking branch 'origin/11.0'
Change-Id: Ib67c8ecb1865ee31ca6485c9287039ba877c68cd
2023-08-10 10:03:04 +02:00
hjk
0e4710b708 BareMetal: Move some code from *.h to *.cpp
Change-Id: I4acedd7ca6c27e371fe2c651e0d769591bed99ff
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-08-10 07:58:16 +00:00
Mahmoud Badri
63dd551b06 QmlDesigner: Add effect maker nodes popup window
Barebone combobox custom popup implementation. This allows the popup to
extend outside the Qml limits. Window content to be implemented
separately.

Task-number: QDS-10403
Change-Id: Ic59d6a8436630d1dcd76063425ce311e5bdff190
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-10 07:57:33 +00:00
hjk
cf0cf0fa9b Debugger: Make DebuggerItemManager a namespace
It had only static functions left.

Change-Id: If0c76373a8428ae7015017b4644e3f974e14a36e
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-08-10 07:52:58 +00:00
Marcus Tillmanns
8ac37d3df4 Qt: Fix slow options page
For remote devices, reading and parsing all the information
of a qt version, can take a long time. This patch delays the read
until the user actually opens the details widget.

Change-Id: I7bd34d05acc8d01f17609996e84630f958091b3a
Reviewed-by: hjk <hjk@qt.io>
2023-08-10 04:41:57 +00:00
Aaron Barany
d1deeb2c0d App: Use PassThrough high DPI rounding policy
When high DPI is enabled, use PassThrough rounding policy to allow
for fractional scaling without having to manually set an environment
variable.

The high DPI setting is now respected even if various Qt scale/ratio
environment variables are set, which is the case in valid default
situations such as setting the global scaling factor for KDE Plasma.

Task-number: QTCREATORBUG-29461
Change-Id: Ife2820d205b3440646255dc997744b2b8867bc70
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-08-09 18:50:44 +00:00
Christian Kandeler
9c2527eea6 QmakeProjectManager: Do not run the clean steps spuriously
Amends c732667838.

Fixes: QTCREATORBUG-29451
Fixes: QTCREATORBUG-29481
Change-Id: Ib79977d49ec7650f025887ec956efde45a8efb7c
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-08-09 16:03:51 +00:00
Burak Hancerli
e7fa015a4c QmlProjectManager: Fix for absolute import path problem
Task-number: QDS-10145
Change-Id: I11998b474a25351901ca0eb45716e1d3e309c572
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2023-08-09 14:43:16 +00:00
Jarek Kobus
7630801293 Valgrind: Make Parser's API similar to the ThreadedParser's API
Change-Id: I39634c881dac44fc857a4aa2049e9c2618daec9b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-08-09 13:54:33 +00:00
hjk
e84369bbfa Core: Remove IOptionPage::setSettings()
The last user is gone, setSettingsProvider is the thing to use,
and allows delay-created settings.

Change-Id: Ic6491e2b0ba2ceaad7786cf37248d734f9714437
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-09 13:17:56 +00:00
Jarek Kobus
97461f6f18 AndroidRunnerWorker: Replace jdb process with Utils::Process
Change-Id: I269c9910a6d0ca1f259a3632abe3601bcdb19f8e
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-08-09 12:41:16 +00:00
Jarek Kobus
af731de4df CubicSegment: Avoid iterating double
Change-Id: I7f98247a20228a1087291138394ebc7469ad7b18
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Knud Dollereder <knud.dollereder@qt.io>
2023-08-09 12:26:21 +00:00
Jarek Kobus
81d38bb711 AndroidRunnerWorker: Replace adbLogcat process with Utils::Process
Change-Id: Ia4e0e7e0b49ca1847bac537a7672c39b069bf767
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-08-09 11:46:30 +00:00